mirrors
/
vkd3d-proton
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vkd3d: Drop redundant validate of PSO state blob from disk cache. 

If we get an entry, it's implicitly validated.

Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
This commit is contained in:
Hans-Kristian Arntzen 2022-03-16 14:29:39 +01:00
parent 8dc8b72807
commit 5044975152
1 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
libs/vkd3d/state.c
View File

@ -3709,21 +3709,14 @@ HRESULT d3d12_pipeline_state_create(struct d3d12_device *device, VkPipelineBindP
if (SUCCEEDED(vkd3d_pipeline_library_find_cached_blob_from_disk_cache(&device->disk_cache, if (SUCCEEDED(vkd3d_pipeline_library_find_cached_blob_from_disk_cache(&device->disk_cache,
&object->pipeline_cache_compat, &cached_pso))) &object->pipeline_cache_compat, &cached_pso)))
{ {
/* Validation is somewhat redundant, but we need to be very careful about potential corruption. /* Validation is redundant. We only accept disk cache entries if checksum of disk blob passes.
* It should never fail in normal operation, but ... * The key is also entirely based on the PSO desc itself. */
* However, unlike app-proved blob, it's not fatal if we fail, so just fall back. */ if ((vkd3d_config_flags & VKD3D_CONFIG_FLAG_PIPELINE_LIBRARY_LOG) &&
if (SUCCEEDED(hr = d3d12_cached_pipeline_state_validate(device, &cached_pso, desc->cached_pso.blob.CachedBlobSizeInBytes)
&object->pipeline_cache_compat)))
{ {
if ((vkd3d_config_flags & VKD3D_CONFIG_FLAG_PIPELINE_LIBRARY_LOG) && INFO("Application provided cached PSO blob, but we opted for disk cache blob instead.\n");
desc->cached_pso.blob.CachedBlobSizeInBytes)
{
INFO("Application provided cached PSO blob, but we opted for disk cache blob instead.\n");
}
desc_cached_pso = &cached_pso;
} }
else desc_cached_pso = &cached_pso;
FIXME("Failed to validate internal pipeline which was fetched from disk cache. This should not happen.\n");
} }
} }