mesa/src/intel/compiler/brw_disasm_info.c

207 lines
6.8 KiB
C
Raw Normal View History

/*
* Copyright © 2014 Intel Corporation
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
* IN THE SOFTWARE.
*/
#include "brw_cfg.h"
#include "brw_eu.h"
#include "brw_disasm_info.h"
#include "dev/intel_debug.h"
#include "compiler/nir/nir.h"
__attribute__((weak)) void nir_print_instr(UNUSED const nir_instr *instr,
UNUSED FILE *fp) {}
void
dump_assembly(void *assembly, int start_offset, int end_offset,
struct disasm_info *disasm, const unsigned *block_latency)
{
const struct brw_isa_info *isa = disasm->isa;
const char *last_annotation_string = NULL;
const void *last_annotation_ir = NULL;
void *mem_ctx = ralloc_context(NULL);
const struct brw_label *root_label =
brw_label_assembly(isa, assembly, start_offset, end_offset, mem_ctx);
foreach_list_typed(struct inst_group, group, link, &disasm->group_list) {
struct exec_node *next_node = exec_node_get_next(&group->link);
if (exec_node_is_tail_sentinel(next_node))
break;
struct inst_group *next =
exec_node_data(struct inst_group, next_node, link);
int start_offset = group->offset;
int end_offset = next->offset;
if (group->block_start) {
fprintf(stderr, " START B%d", group->block_start->num);
foreach_list_typed(struct bblock_link, predecessor_link, link,
&group->block_start->parents) {
struct bblock_t *predecessor_block = predecessor_link->block;
fprintf(stderr, " <-B%d", predecessor_block->num);
}
if (block_latency)
fprintf(stderr, " (%u cycles)",
block_latency[group->block_start->num]);
fprintf(stderr, "\n");
}
if (last_annotation_ir != group->ir) {
last_annotation_ir = group->ir;
if (last_annotation_ir) {
fprintf(stderr, " ");
nir_print_instr(group->ir, stderr);
fprintf(stderr, "\n");
}
}
if (last_annotation_string != group->annotation) {
last_annotation_string = group->annotation;
if (last_annotation_string)
fprintf(stderr, " %s\n", last_annotation_string);
}
brw_disassemble(isa, assembly, start_offset, end_offset,
root_label, stderr);
if (group->error) {
fputs(group->error, stderr);
}
if (group->block_end) {
fprintf(stderr, " END B%d", group->block_end->num);
foreach_list_typed(struct bblock_link, successor_link, link,
&group->block_end->children) {
struct bblock_t *successor_block = successor_link->block;
fprintf(stderr, " ->B%d", successor_block->num);
}
fprintf(stderr, "\n");
}
}
fprintf(stderr, "\n");
ralloc_free(mem_ctx);
}
struct disasm_info *
disasm_initialize(const struct brw_isa_info *isa,
const struct cfg_t *cfg)
{
struct disasm_info *disasm = ralloc(NULL, struct disasm_info);
exec_list_make_empty(&disasm->group_list);
disasm->isa = isa;
disasm->cfg = cfg;
disasm->cur_block = 0;
disasm->use_tail = false;
return disasm;
}
struct inst_group *
disasm_new_inst_group(struct disasm_info *disasm, unsigned next_inst_offset)
{
struct inst_group *tail = rzalloc(disasm, struct inst_group);
tail->offset = next_inst_offset;
exec_list_push_tail(&disasm->group_list, &tail->link);
return tail;
}
void
disasm_annotate(struct disasm_info *disasm,
struct backend_instruction *inst, unsigned offset)
{
const struct intel_device_info *devinfo = disasm->isa->devinfo;
const struct cfg_t *cfg = disasm->cfg;
struct inst_group *group;
if (!disasm->use_tail) {
group = disasm_new_inst_group(disasm, offset);
} else {
disasm->use_tail = false;
group = exec_node_data(struct inst_group,
exec_list_get_tail_raw(&disasm->group_list), link);
}
if (INTEL_DEBUG(DEBUG_ANNOTATION)) {
group->ir = inst->ir;
group->annotation = inst->annotation;
}
if (bblock_start(cfg->blocks[disasm->cur_block]) == inst) {
group->block_start = cfg->blocks[disasm->cur_block];
}
/* There is no hardware DO instruction on Gfx6+, so since DO always
* starts a basic block, we need to set the .block_start of the next
* instruction's annotation with a pointer to the bblock started by
* the DO.
*
* There's also only complication from emitting an annotation without
* a corresponding hardware instruction to disassemble.
*/
if (devinfo->ver >= 6 && inst->opcode == BRW_OPCODE_DO) {
disasm->use_tail = true;
}
if (bblock_end(cfg->blocks[disasm->cur_block]) == inst) {
group->block_end = cfg->blocks[disasm->cur_block];
disasm->cur_block++;
}
}
void
disasm_insert_error(struct disasm_info *disasm, unsigned offset,
intel/eu: Handle compaction when inserting validation errors When the EU validator encountered an error, it would add an annotation to the disassembly. Unfortunately, the code to insert an error assumed that the next instruction would start at (offset + sizeof(brw_inst)), which is not true if the instruction with an error is compacted. This could lead to cascading disassembly errors, where we started trying to decode the next instruction at the wrong offset, and getting lots of scary looking output: ERROR: Register Regioning patterns where [...] (-f0.1.any16h) illegal(*** invalid execution size value 6 ) { align1 $7.src atomic }; (+f0.1.any16h) illegal.sat(*** invalid execution size value 6 ) { align1 $9.src AccWrEnable }; illegal(*** invalid execution size value 6 ) { align1 $11.src }; (+f0.1) illegal.sat(*** invalid execution size value 6 ) { align1 F@2 AccWrEnable }; (+f0.1) illegal.sat(*** invalid execution size value 6 ) { align1 F@2 AccWrEnable }; (+f0.1) illegal.sat(*** invalid execution size value 6 ) { align1 $15.src AccWrEnable }; illegal(*** invalid execution size value 6 ) { align1 $15.src }; (+f0.1) illegal.sat.g.f0.1(*** invalid execution size value 6 ) { align1 $13.src AccWrEnable }; Only the first instruction was actually wrong - the rest are just a result of starting the disassembler at the wrong offset. Trash ensues! To fix this, just pass the instruction size in a few layers so we can record the next offset properly. Cc: mesa-stable Reviewed-by: Francisco Jerez <currojerez@riseup.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17624>
2022-07-19 08:27:29 +01:00
unsigned inst_size, const char *error)
{
foreach_list_typed(struct inst_group, cur, link, &disasm->group_list) {
struct exec_node *next_node = exec_node_get_next(&cur->link);
if (exec_node_is_tail_sentinel(next_node))
break;
struct inst_group *next =
exec_node_data(struct inst_group, next_node, link);
if (next->offset <= offset)
continue;
intel/eu: Handle compaction when inserting validation errors When the EU validator encountered an error, it would add an annotation to the disassembly. Unfortunately, the code to insert an error assumed that the next instruction would start at (offset + sizeof(brw_inst)), which is not true if the instruction with an error is compacted. This could lead to cascading disassembly errors, where we started trying to decode the next instruction at the wrong offset, and getting lots of scary looking output: ERROR: Register Regioning patterns where [...] (-f0.1.any16h) illegal(*** invalid execution size value 6 ) { align1 $7.src atomic }; (+f0.1.any16h) illegal.sat(*** invalid execution size value 6 ) { align1 $9.src AccWrEnable }; illegal(*** invalid execution size value 6 ) { align1 $11.src }; (+f0.1) illegal.sat(*** invalid execution size value 6 ) { align1 F@2 AccWrEnable }; (+f0.1) illegal.sat(*** invalid execution size value 6 ) { align1 F@2 AccWrEnable }; (+f0.1) illegal.sat(*** invalid execution size value 6 ) { align1 $15.src AccWrEnable }; illegal(*** invalid execution size value 6 ) { align1 $15.src }; (+f0.1) illegal.sat.g.f0.1(*** invalid execution size value 6 ) { align1 $13.src AccWrEnable }; Only the first instruction was actually wrong - the rest are just a result of starting the disassembler at the wrong offset. Trash ensues! To fix this, just pass the instruction size in a few layers so we can record the next offset properly. Cc: mesa-stable Reviewed-by: Francisco Jerez <currojerez@riseup.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17624>
2022-07-19 08:27:29 +01:00
if (offset + inst_size != next->offset) {
struct inst_group *new = ralloc(disasm, struct inst_group);
memcpy(new, cur, sizeof(struct inst_group));
cur->error = NULL;
cur->error_length = 0;
cur->block_end = NULL;
intel/eu: Handle compaction when inserting validation errors When the EU validator encountered an error, it would add an annotation to the disassembly. Unfortunately, the code to insert an error assumed that the next instruction would start at (offset + sizeof(brw_inst)), which is not true if the instruction with an error is compacted. This could lead to cascading disassembly errors, where we started trying to decode the next instruction at the wrong offset, and getting lots of scary looking output: ERROR: Register Regioning patterns where [...] (-f0.1.any16h) illegal(*** invalid execution size value 6 ) { align1 $7.src atomic }; (+f0.1.any16h) illegal.sat(*** invalid execution size value 6 ) { align1 $9.src AccWrEnable }; illegal(*** invalid execution size value 6 ) { align1 $11.src }; (+f0.1) illegal.sat(*** invalid execution size value 6 ) { align1 F@2 AccWrEnable }; (+f0.1) illegal.sat(*** invalid execution size value 6 ) { align1 F@2 AccWrEnable }; (+f0.1) illegal.sat(*** invalid execution size value 6 ) { align1 $15.src AccWrEnable }; illegal(*** invalid execution size value 6 ) { align1 $15.src }; (+f0.1) illegal.sat.g.f0.1(*** invalid execution size value 6 ) { align1 $13.src AccWrEnable }; Only the first instruction was actually wrong - the rest are just a result of starting the disassembler at the wrong offset. Trash ensues! To fix this, just pass the instruction size in a few layers so we can record the next offset properly. Cc: mesa-stable Reviewed-by: Francisco Jerez <currojerez@riseup.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17624>
2022-07-19 08:27:29 +01:00
new->offset = offset + inst_size;
new->block_start = NULL;
exec_node_insert_after(&cur->link, &new->link);
}
if (cur->error)
ralloc_strcat(&cur->error, error);
else
cur->error = ralloc_strdup(disasm, error);
return;
}
}