mirror of https://gitlab.freedesktop.org/mesa/mesa
7f6491b76d
Every nir_ssa_def is part of a chain of uses, implemented with doubly linked lists. That means each requires 2 * 64-bit = 16 bytes per def, which is memory intensive. Together they require 32 bytes per def. Not cool. To cut that memory use in half, we can combine the two linked lists into a single use list that contains both regular instruction uses and if-uses. To do this, we augment the nir_src with a boolean "is_if", and reimplement the abstract if-uses operations on top of that list. That boolean should fit into the padding already in nir_src so should not actually affect memory use, and in the future we sneak it into the bottom bit of a pointer. However, this creates a new inefficiency: now iterating over regular uses separate from if-uses is (nominally) more expensive. It turns out virtually every caller of nir_foreach_if_use(_safe) also calls nir_foreach_use(_safe) immediately before, so we rewrite most of the callers to instead call a new single `nir_foreach_use_including_if(_safe)` which predicates the logic based on `src->is_if`. This should mitigate the performance difference. There's a bit of churn, but this is largely a mechanical set of changes. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22343> |
||
|---|---|---|
| .. | ||
| compiler.h | ||
| disassemble.c | ||
| disassemble.h | ||
| helpers.h | ||
| meson.build | ||
| midgard.h | ||
| midgard_address.c | ||
| midgard_compile.c | ||
| midgard_compile.h | ||
| midgard_derivatives.c | ||
| midgard_emit.c | ||
| midgard_errata_lod.c | ||
| midgard_helper_invocations.c | ||
| midgard_liveness.c | ||
| midgard_nir.h | ||
| midgard_nir_algebraic.py | ||
| midgard_nir_lower_image_bitsize.c | ||
| midgard_ops.c | ||
| midgard_ops.h | ||
| midgard_opt_copy_prop.c | ||
| midgard_opt_dce.c | ||
| midgard_opt_perspective.c | ||
| midgard_print.c | ||
| midgard_print_constant.c | ||
| midgard_quirks.h | ||
| midgard_ra.c | ||
| midgard_ra_pipeline.c | ||
| midgard_schedule.c | ||
| mir.c | ||
| mir_promote_uniforms.c | ||
| mir_squeeze.c | ||
| nir_fuse_io_16.c | ||