mirror of https://gitlab.freedesktop.org/mesa/mesa
The spec is quite clear this is not allowed: From Section 4.4. (Layout Qualifiers) of the GLSL 4.60 spec: "Layout qualifiers can appear in several forms of declaration. They can appear as part of an interface block definition or block member, as shown in the grammar in the previous section. They can also appear with just an interface-qualifier to establish layouts of other declarations made with that qualifier: layout-qualifier interface-qualifier ; Or, they can appear with an individual variable declared with an interface qualifier: layout-qualifier interface-qualifier declaration ;" From Section 4.10 (Memory Qualifiers) of the GLSL 4.60 spec: "Layout qualifiers cannot be used on formal function parameters, and layout qualification is not included in parameter matching." However on the Nvidia binary driver they actually fail to compile if image function params don't have a layout qualifier. This results in applications such as No Mans Sky using layout qualifiers on params. I've submitted a CTS test to expose this problem in the Nvidia driver but until that is resolved this patch will help Mesa drivers work around the issue. Reviewed-by: Marek Olšák <marek.olsak@amd.com> |
||
---|---|---|
.. | ||
amd | ||
broadcom | ||
compiler | ||
egl | ||
gallium | ||
gbm | ||
getopt | ||
glx | ||
gtest | ||
hgl | ||
intel | ||
loader | ||
mapi | ||
mesa | ||
util | ||
vulkan | ||
Makefile.am | ||
SConscript | ||
meson.build |