mirrors
/
mesa
mirror of https://gitlab.freedesktop.org/mesa/mesa
1
0
Fork 0
Code Issues 9 Packages Projects Releases Wiki Activity

radv: disable DCC with signedness reinterpretation on GFX11 

All formats should be compatible on GFX11 but for some weird reasons
DCC with signedness reinterpretation doesn't work as expected, like
R8_UINT<->R8_SINT. Note that RadeonSI also has issues with this.

This might be a hardware bug on RDNA3.

This fixes DCC issues with Cyberpunk and A Plague Tale: Requiem.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8020
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8371
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21755>
(cherry picked from commit e6735409ee)
This commit is contained in:
Samuel Pitoiset 2023-03-06 19:06:17 +01:00 committed by Eric Engestrom
parent 8292375d11
commit acb42bea9c
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.pick_status.json
View File

@ -157,7 +157,7 @@
"description": "radv: disable DCC with signedness reinterpretation on GFX11",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null
},

14
src/amd/vulkan/radv_formats.c
View File

@ -2096,10 +2096,6 @@ radv_dcc_formats_compatible(enum amd_gfx_level gfx_level, VkFormat format1, VkFo
unsigned size1, size2;
int i;
/* All formats are compatible on GFX11. */
if (gfx_level >= GFX11)
return true;
if (format1 == format2)
return true;
@ -2122,8 +2118,16 @@ radv_dcc_formats_compatible(enum amd_gfx_level gfx_level, VkFormat format1, VkFo
(type1 == dcc_channel_float) != (type2 == dcc_channel_float) || size1 != size2)
return false;
if (type1 != type2)
if (type1 != type2) {
/* FIXME: All formats should be compatible on GFX11 but for some reasons DCC with signedness
* reinterpretation doesn't work as expected, like R8_UINT<->R8_SINT. Note that disabling
* fast-clears doesn't help.
*/
if (gfx_level >= GFX11)
return false;
*sign_reinterpret = true;
}
return true;
}