mirrors
/
mesa
mirror of https://gitlab.freedesktop.org/mesa/mesa
1
0
Fork 0
Code Issues 9 Packages Projects Releases Wiki Activity

intel/brw: Update CSEL source type validation 

Gfx9 can only have F, but newer GPUs can have F, HF, *D, or *W. The
source and destination types must still match in size.

v2: Simplify the float vs integer logic. Suggested by Ken.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29095>
This commit is contained in:
Ian Romanick 2024-05-08 11:51:11 -07:00 committed by Marge Bot
parent 3f151c03af
commit 504b742b83
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/intel/compiler/brw_eu_validate.c
View File

@ -2122,8 +2122,22 @@ instruction_restrictions(const struct brw_isa_info *isa,
src_type = brw_inst_3src_a16_src_type(devinfo, inst);
}
ERROR_IF(src_type != dst_type,
"CSEL source type must match destination type");
if (devinfo->ver == 9) {
ERROR_IF(src_type != BRW_TYPE_F,
"CSEL source type must be F");
} else {
ERROR_IF(src_type != BRW_TYPE_F && src_type != BRW_TYPE_HF &&
src_type != BRW_TYPE_D && src_type != BRW_TYPE_UD &&
src_type != BRW_TYPE_W && src_type != BRW_TYPE_UW,
"CSEL source type must be F, HF, *D, or *W");
ERROR_IF(brw_type_is_float(src_type) != brw_type_is_float(dst_type),
"CSEL cannot mix float and integer types.");
ERROR_IF(brw_type_size_bytes(src_type) !=
brw_type_size_bytes(dst_type),
"CSEL cannot mix different type sizes.");
}
}
}