mirrors
/
mesa
mirror of https://gitlab.freedesktop.org/mesa/mesa
1
0
Fork 0
Code Issues 9 Packages Projects Releases Wiki Activity

ac/nir: explicitly use pack_half_2x16_rtz 

rtz matters for constant folding.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28730>
This commit is contained in:
Georg Lehmann 2024-04-13 13:34:49 +02:00 committed by Marge Bot
parent 1b8cf06fc7
commit 4287358f59
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/amd/common/ac_nir_lower_ps.c
View File

@ -547,7 +547,7 @@ emit_ps_color_export(nir_builder *b, lower_ps_state *s, gl_frag_result slot, uns
switch (spi_shader_col_format) {
case V_028714_SPI_SHADER_FP16_ABGR:
if (type_size == 32)
pack_op = nir_op_pack_half_2x16;
pack_op = nir_op_pack_half_2x16_rtz_split;
break;
case V_028714_SPI_SHADER_UINT16_ABGR:
if (type_size == 32) {
@ -606,9 +606,13 @@ emit_ps_color_export(nir_builder *b, lower_ps_state *s, gl_frag_result slot, uns
lo = lo ? lo : nir_undef(b, 1, type_size);
hi = hi ? hi : nir_undef(b, 1, type_size);
nir_def *vec = nir_vec2(b, lo, hi);
outputs[i] = nir_build_alu1(b, pack_op, vec);
if (nir_op_infos[pack_op].num_inputs == 2) {
outputs[i] = nir_build_alu2(b, pack_op, lo, hi);
} else {
nir_def *vec = nir_vec2(b, lo, hi);
outputs[i] = nir_build_alu1(b, pack_op, vec);
}
if (s->options->gfx_level >= GFX11)
write_mask |= BITFIELD_BIT(i);