mirrors
/
mesa
mirror of https://gitlab.freedesktop.org/mesa/mesa
1
0
Fork 0
Code Issues 9 Packages Projects Releases Wiki Activity

lavapipe: set render_condition_enabled=false for vkCmdClearDepthStencilImage 

this command ignores conditional rendering

fixes:
dEQP-VK.conditional_rendering.conditional_ignore.clear_condition_host_memory_expect_noop
dEQP-VK.conditional_rendering.conditional_ignore.clear_condition_host_memory_secondary_buffer_expect_noop
dEQP-VK.conditional_rendering.conditional_ignore.clear_condition_host_memory_secondary_buffer_expect_noop_inverted
dEQP-VK.conditional_rendering.conditional_ignore.clear_condition_host_memory_secondary_buffer_inherited_expect_noop
dEQP-VK.conditional_rendering.conditional_ignore.clear_condition_local_memory_expect_noop_inverted
dEQP-VK.conditional_rendering.conditional_ignore.clear_condition_local_memory_secondary_buffer_expect_noop
dEQP-VK.conditional_rendering.conditional_ignore.clear_condition_local_memory_secondary_buffer_expect_noop_inverted
dEQP-VK.conditional_rendering.conditional_ignore.clear_condition_local_memory_secondary_buffer_inherited_expect_noop

Fixes: fe53c22294 ("lavapipe: fix only clearing depth or stencil paths.")

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21814>
(cherry picked from commit e6e1d01be0)

Conflicts:
	src/gallium/frontends/lavapipe/ci/lvp-fails.txt
This commit is contained in:
Mike Blumenkrantz 2023-03-09 09:32:34 -05:00 committed by Dylan Baker
parent 146760db7b
commit 1153a8d8c4
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.pick_status.json
View File

@ -19934,7 +19934,7 @@
"description": "lavapipe: set render_condition_enabled=false for vkCmdClearDepthStencilImage",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "fe53c22294900142c358b75d39c43710ccfd414e",
"notes": null

2
src/gallium/frontends/lavapipe/lvp_execute.c
View File

@ -2994,7 +2994,7 @@ static void handle_clear_ds_image(struct vk_cmd_queue_entry *cmd,
cmd->u.clear_depth_stencil_image.depth_stencil->depth,
cmd->u.clear_depth_stencil_image.depth_stencil->stencil,
0, 0,
width, height, true);
width, height, false);
state->pctx->surface_destroy(state->pctx, surf);
}
}