2b3b7b692b
Yes this is a round trip, but X_PresentPixmap is not itself a blocking operation, it just instructs the server to do the next presentation at some time. More importantly, if _we_ don't catch the presentation error, xlib's error queue will, and the calling code is certainly not prepared to handle errors from Present. Forcing the round trip here is also a bit more correct semantically. This is the end of the Vulkan client part of the present queue, and the X_PresentPixmap request transfers the queue operation to the server, so we should not return until we are sure the handoff has happened. Fixes some flakiness with piglit@glx-visuals-* with zink+radv. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17685> |
||
|---|---|---|
| .. | ||
| meson.build | ||
| wsi_common.c | ||
| wsi_common.h | ||
| wsi_common_display.c | ||
| wsi_common_display.h | ||
| wsi_common_drm.c | ||
| wsi_common_drm.h | ||
| wsi_common_private.h | ||
| wsi_common_queue.h | ||
| wsi_common_wayland.c | ||
| wsi_common_win32.c | ||
| wsi_common_x11.c | ||