Kenneth Graunke
1b5d35319e
iris: don't trip on param asserts
...
I'd rather not rewrite i965's compute system value handling right now :(
2019-02-21 10:26:10 -08:00
Kenneth Graunke
f4829a2fe1
iris: don't support pull constants.
...
I don't think it matters, we won't have any params anyway, but let's
be sure it doesn't try
2019-02-21 10:26:10 -08:00
Kenneth Graunke
911f9e8f3f
iris: regather info so we get CLIP_DIST slots, not CLIP_VERTEX
2019-02-21 10:26:09 -08:00
Kenneth Graunke
6d19fe376d
iris: enable push constants if we have sysvals but no uniforms
2019-02-21 10:26:09 -08:00
Kenneth Graunke
1ef68d77c0
iris: drop iris_setup_push_uniform_range
...
it doesn't do anything, we have no params. I guess I thought there
would be some, but they all get dead code eliminated even if we try
to make them exist in the first place.
2019-02-21 10:26:09 -08:00
Kenneth Graunke
7eeb124c02
iris: fix more uniform setup
2019-02-21 10:26:09 -08:00
Kenneth Graunke
50743eb748
iris: fix num clip plane consts
2019-02-21 10:26:09 -08:00
Kenneth Graunke
a98634a28f
iris: actually upload clip planes.
2019-02-21 10:26:09 -08:00
Kenneth Graunke
c60ce3f4fd
iris: bypass params and do it ourselves
...
the backend keeps dead code eliminating them all, so we can't do that,
plus we don't want to because params[] is lame
2019-02-21 10:26:09 -08:00
Kenneth Graunke
78fc760bab
iris: dodge backend UCP lowering
2019-02-21 10:26:09 -08:00
Kenneth Graunke
deb6d588a6
iris: fix system value remapping
2019-02-21 10:26:09 -08:00
Kenneth Graunke
2b0a2915dc
iris: hook up key stuff for clip plane lowering
2019-02-21 10:26:09 -08:00
Kenneth Graunke
2876dd1a37
iris: lower user clip planes
2019-02-21 10:26:09 -08:00
Kenneth Graunke
80c856cbee
iris: only bother with params if there are any...
2019-02-21 10:26:09 -08:00
Kenneth Graunke
2186d83185
iris: fill out params array with built-ins, like clip planes
2019-02-21 10:26:09 -08:00
Kenneth Graunke
d3e8ff143d
iris: add param domain defines
2019-02-21 10:26:09 -08:00
Kenneth Graunke
ecb28b2802
iris: drop unnecessary param[] setup from iris_setup_uniforms
...
the backend just considers these dead anyway
2019-02-21 10:26:09 -08:00
Kenneth Graunke
ed08f022f0
iris: Defer cbuf0 upload to draw time
2019-02-21 10:26:09 -08:00
Kenneth Graunke
e98cf9c24b
iris: Clone the NIR
...
The backend compiler used to do this for us, but after a rebase, it's
now the driver's responsibility. This lets us alter it for say, clip
vertex lowering, at the global level rather than the per-variant level.
2019-02-21 10:26:09 -08:00
Kenneth Graunke
587e438128
iris: Print the batch name when decoding
2019-02-21 10:26:09 -08:00
Kenneth Graunke
2727a942a4
iris: partial set_query_active_state
...
used to avoid OQ during clears for example
fixes occlusion_query_meta_no_fragments
2019-02-21 10:26:09 -08:00
Kenneth Graunke
64af1d9248
iris: Fix multiple RTs with non-independent blending
...
rt[i] isn't filled out in this case, so we have to use rt[0]
2019-02-21 10:26:09 -08:00
Kenneth Graunke
58507c02ce
iris: Fix TextureBarrier
...
I don't know how I came up with the old one, this is now what i965 does
Also we now do compute batches too
2019-02-21 10:26:09 -08:00
Kenneth Graunke
e5d84bbd36
iris: Fix MSAA smooth points
...
Fixes bin/ext_framebuffer_multisample-point-smooth 2 -auto -fbo
2019-02-21 10:26:09 -08:00
Kenneth Graunke
4d219b0eb3
iris: implement scratch space!
...
we borrow the approach from anv rather than i965, as it works better
with pre-baked state that needs to contain scratch BO addresses
fixes a bunch of varying packing tests
2019-02-21 10:26:09 -08:00
Kenneth Graunke
9511b89ef9
iris: tidy more warnings
2019-02-21 10:26:09 -08:00
Kenneth Graunke
846316b258
iris: Enable msaa_map transfer helpers
...
This does the downsampling for us. It'll use BLORP anyway because
it uses blit(), and that uses BLORP.
2019-02-21 10:26:09 -08:00
Kenneth Graunke
9ec927497e
iris: Actually create/destroy HW contexts
...
The intention is that render and compute use their own contexts,
and each is PIPELINE_SELECT'd to the right pipeline. But we hadn't
actually made them, so we got the fd-default context.
Thanks to Chris Wilson for catching this!
2019-02-21 10:26:09 -08:00
Kenneth Graunke
cb5f47f585
iris: Don't leak the compute batch
2019-02-21 10:26:09 -08:00
Kenneth Graunke
fbe5d75f11
iris: cross batch flushing
2019-02-21 10:26:09 -08:00
Kenneth Graunke
c3cc525c7a
iris: Cross-link iris_batches so they can potentially flush each other
...
This makes e.g. the render batch aware of the compute batch, so it can
ask questions like "is this BO referenced by some other batch?" and do
something about that.
2019-02-21 10:26:09 -08:00
Dave Airlie
ed016b2a0b
iris: fix crash in sparse vertex array
...
this fixes crash in array-stride piglit.
2019-02-21 10:26:09 -08:00
Kenneth Graunke
bcac11c8f1
iris: Use at least 1x1 size for null FB surface state.
...
Otherwise we get 0 - 1 = 0xffffffff and fail to pack SURFACE_STATE.
Fixes some object namespace pollution gltexsubimage2d tests
2019-02-21 10:26:09 -08:00
Kenneth Graunke
9c8fdf8133
iris: Drop B5G5R5X1 support
...
This is oddly renderable but not supported for sampling, which is the
opposite of other X formats. Just skip it and fall back to BGRA.
2019-02-21 10:26:09 -08:00
Kenneth Graunke
4b31f506f8
iris: Enable A8/A16_UNORM in an inefficient manner
...
These are currently just use the 'A' hardware formats, rather than the
faster 'R' formats. glBitmap handling needs these, it seems. :(
2019-02-21 10:26:09 -08:00
Kenneth Graunke
80497af192
iris: Enable ARB_shader_stencil_export
2019-02-21 10:26:09 -08:00
Kenneth Graunke
3e6aaa1ba5
iris: Disable a PIPE_CONTROL workaround on Icelake
2019-02-21 10:26:09 -08:00
Kenneth Graunke
84a419432d
iris: Flag constants dirty on program changes
...
3DSTATE_CONSTANT_* looks at prog_data->ubo_ranges. We were getting
saved by iris_set_constant_buffers() usually happening when changing
programs (as they usually change uniforms too), but with the clear
shader that doesn't use uniforms, we weren't getting one and were
leaving push constants enabled, screwing things up.
Also clean up a bit of a mess left by the hacks - we were missing
bindings in the VS/FS/CS case, among other issues...
2019-02-21 10:26:09 -08:00
Kenneth Graunke
317ba8796f
iris: allow binding a null vertex buffer
...
PBO upload apparently does this...
2019-02-21 10:26:09 -08:00
Kenneth Graunke
aef1ba5ce4
iris: fix overhead regression from "don't stomp each other's dirty bits"
...
The change from dirty = 0ull to dirty &= ~NOT_MY_BITS broke the "nothing
to do? skip it!" optimization. thanks to Chris for noticing this!
2019-02-21 10:26:09 -08:00
Kenneth Graunke
525d89cafc
iris: delete dead code
2019-02-21 10:26:09 -08:00
Kenneth Graunke
8a98e90415
iris: Fix refcounting of grid surface
2019-02-21 10:26:09 -08:00
Jason Ekstrand
8e8868d5ad
iris/compute: Zero out the last grid size on indirect dispatches
2019-02-21 10:26:09 -08:00
Jason Ekstrand
c16e711ff2
iris/compute: Don't increment the grid size offset
...
It may be in the dynamic state buffer but the fact that we have a
resource takes care of that. We don't need to add in the address of
the dynamic state buffer again.
2019-02-21 10:26:09 -08:00
Kenneth Graunke
a3e813c5af
iris: SO_DECL_LIST fix
2019-02-21 10:26:09 -08:00
Kenneth Graunke
927c4a21bd
iris: Fall back to 1x1x1 null surface if no framebuffer supplied
...
If the state tracker never gave us the framebuffer dimensions via
a set_framebuffer_state() call, just fall back to the unbound texture
null surface, which is 1x1x1. Otherwise we'd use a NULL resource
(no pun intended).
2019-02-21 10:26:09 -08:00
Kenneth Graunke
5d1a9db720
iris: Fix off by one in scissoring, empty scissors, default scissors
2019-02-21 10:26:09 -08:00
Kenneth Graunke
938d63b2e8
iris: Move snapshots_landed to the front.
...
Transform feedback overflow queries need to write additional data,
and it would be nice to have this field remain at a consistent offset.
2019-02-21 10:26:09 -08:00
Kenneth Graunke
ba2a4207f9
iris: Clamp UBO and SSBO access to the actual BO size, for safety
2019-02-21 10:26:09 -08:00
Kenneth Graunke
a9b32f2bbf
iris: Fix texture buffer / image buffer sizes.
...
Also fix image buffers with offsets.
2019-02-21 10:26:09 -08:00