KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

zink: do not request scoped memory barriers 

While barriers in Vulkan are scoped, we do not handle
nir_intrinsic_scoped_barrier, so we do not support them from NIR.

The reason why this hasn't been a problem seems to be that VTN is the
only place that respects them, so we haven't seen them yet.

But if the GLSL compiler starts respecting the setting, things will
start blowing up. There's WIP patches for this in !3339 already.

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9949>
This commit is contained in:
Erik Faye-Lund 2021-03-31 15:45:11 +02:00 committed by Marge Bot
parent 71e39c79fd
commit 70066fb036
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/gallium/drivers/zink/zink_compiler.c
View File

@ -329,7 +329,6 @@ zink_screen_init_compiler(struct zink_screen *screen)
.lower_pack_64_2x32_split = true,
.lower_unpack_64_2x32_split = true,
.lower_vector_cmp = true,
.use_scoped_barrier = true,
.lower_int64_options = 0,
.lower_doubles_options = ~nir_lower_fp64_full_software,
.has_fsub = true,