vc4: Add support for CMP.

This took a couple of tries, and this is the squash of those attempts.

v2: Fix register file conflicts on the args in the
    destination-is-accumulator case.
v3: Rebase on helper change and qir_inst4 change.
This commit is contained in:
Eric Anholt 2014-07-16 08:12:27 -07:00
parent eea1d36915
commit 4c53087c67
4 changed files with 48 additions and 1 deletions

View File

@ -202,7 +202,11 @@ tgsi_to_qir_alu(struct tgsi_to_qir *trans,
{
struct qcompile *c = trans->c;
struct qreg dst = qir_get_temp(c);
qir_emit(c, qir_inst(op, dst, src[0 * 4 + i], src[1 * 4 + i]));
qir_emit(c, qir_inst4(op, dst,
src[0 * 4 + i],
src[1 * 4 + i],
src[2 * 4 + i],
c->undef));
return dst;
}
@ -325,6 +329,7 @@ emit_tgsi_instruction(struct tgsi_to_qir *trans,
[TGSI_OPCODE_SNE] = { QOP_SNE, tgsi_to_qir_alu },
[TGSI_OPCODE_SGE] = { QOP_SGE, tgsi_to_qir_alu },
[TGSI_OPCODE_SLT] = { QOP_SLT, tgsi_to_qir_alu },
[TGSI_OPCODE_CMP] = { QOP_CMP, tgsi_to_qir_alu },
[TGSI_OPCODE_MAD] = { 0, tgsi_to_qir_mad },
[TGSI_OPCODE_DP2] = { 0, tgsi_to_qir_dp2 },
[TGSI_OPCODE_DP3] = { 0, tgsi_to_qir_dp3 },

View File

@ -48,6 +48,7 @@ static const struct qir_op_info qir_op_info[] = {
[QOP_SNE] = { "sne", 1, 2 },
[QOP_SGE] = { "sge", 1, 2 },
[QOP_SLT] = { "slt", 1, 2 },
[QOP_CMP] = { "cmp", 1, 3 },
[QOP_FTOI] = { "ftoi", 1, 1 },
[QOP_RCP] = { "rcp", 1, 1 },

View File

@ -55,6 +55,7 @@ enum qop {
QOP_SNE,
QOP_SGE,
QOP_SLT,
QOP_CMP,
QOP_FTOI,
QOP_RCP,

View File

@ -332,6 +332,46 @@ vc4_generate_code(struct qcompile *c)
}
break;
case QOP_CMP:
queue(c, qpu_inst(qpu_a_MOV(qpu_ra(QPU_W_NOP),
src[0]),
qpu_m_NOP()));
*last_inst(c) |= QPU_SF;
if (dst.mux <= QPU_MUX_R3) {
fixup_raddr_conflict(c, src[1], &src[2]);
queue(c, qpu_inst(qpu_a_MOV(dst, src[1]),
qpu_m_MOV(dst, src[2])));
*last_inst(c) = ((*last_inst(c) & ~(QPU_COND_ADD_MASK |
QPU_COND_MUL_MASK))
| QPU_SET_FIELD(QPU_COND_NS,
QPU_COND_ADD)
| QPU_SET_FIELD(QPU_COND_NC,
QPU_COND_MUL));
} else {
if (dst.mux == src[1].mux &&
dst.addr == src[1].addr) {
queue(c, qpu_inst(qpu_a_MOV(dst, src[1]),
qpu_m_NOP()));
queue(c, qpu_inst(qpu_a_MOV(dst, src[2]),
qpu_m_NOP()));
*last_inst(c) = ((*last_inst(c) & ~(QPU_COND_ADD_MASK))
| QPU_SET_FIELD(QPU_COND_NC,
QPU_COND_ADD));
} else {
queue(c, qpu_inst(qpu_a_MOV(dst, src[2]),
qpu_m_NOP()));
queue(c, qpu_inst(qpu_a_MOV(dst, src[1]),
qpu_m_NOP()));
*last_inst(c) = ((*last_inst(c) & ~(QPU_COND_ADD_MASK))
| QPU_SET_FIELD(QPU_COND_NS,
QPU_COND_ADD));
}
}
break;
case QOP_SEQ:
case QOP_SNE:
case QOP_SGE: