From f16875d195889680bf7cd625c45686ddf2da8b62 Mon Sep 17 00:00:00 2001 From: Hans-Kristian Arntzen Date: Mon, 21 Mar 2022 11:31:51 +0100 Subject: [PATCH] vkd3d: Add FIXME for dubious use of dsv_plane_optimal_mask. Signed-off-by: Hans-Kristian Arntzen --- libs/vkd3d/state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libs/vkd3d/state.c b/libs/vkd3d/state.c index 565c15a8..cd47ca84 100644 --- a/libs/vkd3d/state.c +++ b/libs/vkd3d/state.c @@ -4125,6 +4125,8 @@ VkPipeline d3d12_pipeline_state_create_pipeline_variant(struct d3d12_pipeline_st if (d3d12_graphics_pipeline_state_has_unknown_dsv_format_with_test(graphics) && dsv_format) TRACE("Compiling %p with fallback DSV format %#x.\n", state, dsv_format->vk_format); + /* FIXME: This gets modified on late recompilation, could there be thread safety issues here? + * For GENERAL depth-stencil, this mask should not matter at all, but there might be edge cases for tracked DSV. */ graphics->dsv_plane_optimal_mask = d3d12_graphics_pipeline_state_get_plane_optimal_mask(graphics, dsv_format); if (key)