mirrors
/
vkd3d-proton
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vkd3d: Allow dynamic vertex stride == 0 to go through. 

Eliminates all late pipeline compiles in Scarlet Nexus DX12 (and several
other games).

Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
This commit is contained in:
Hans-Kristian Arntzen 2021-06-27 13:28:02 +02:00
parent c1860a1ead
commit cb5283b6fb
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libs/vkd3d/state.c
View File

@ -3805,7 +3805,17 @@ static bool d3d12_pipeline_state_can_use_dynamic_stride(struct d3d12_pipeline_st
/* The vertex buffer stride must be larger than any attribute offset + format size which accesses a buffer binding.
* This is somewhat awkward, since D3D12 does not have this restriction, although the validation layers do warn about this.
* There might also be similar fallback paths on certain native drivers, who knows ... */
if (dyn_state->vertex_strides[slot] < graphics->minimum_vertex_buffer_dynamic_stride[slot])
/* HACK: Not technically in spec, but allow stride == 0 to pass through.
* The stride >= offset + sizeof(format) rule is for AMD and OOB checks, since
* we need compiler to adjust vtx index and offset in this scenario since checks are against vtx index
* not byte address, but this path is irrelevant for stride == 0.
* This is fairly common to see in games. Scarlet Nexus hits it pretty hard, and
* we really should try to avoid late pipeline compiles here.
* Ideally, we should aim to clarify the Vulkan spec here to allow this case,
* since it's the canonical way to feed a constant attribute. */
if (dyn_state->vertex_strides[slot] &&
dyn_state->vertex_strides[slot] < graphics->minimum_vertex_buffer_dynamic_stride[slot])
{
TRACE("Stride for slot %u is %u bytes, but need at least %u.\n", slot,
(unsigned int)dyn_state->vertex_strides[slot],