From f655af378274f1ba830aa3d28cf82820b3e84711 Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Thu, 13 Apr 2023 20:29:12 +0100 Subject: [PATCH] ci: rework vulkan validation layer build script Initially this was just adding a missing popd, but actually there's no reason to pushd into the build dir, so let's just pass the build dir as arguments to cmake & ninja instead. `--arch x64` was also dropped as it only applies to Windows builds, which this script doesn't support anyway. Fixes: 512f1c160a63a7ba1b00 ("ci/zink: Add coverage using the vulkan validation layer on lvp.") Signed-off-by: Eric Engestrom Reviewed-by: Jesse Natalie Part-of: (cherry picked from commit 3c64f3dcbca003689b4c982d0cb13e5098bbe3cb) --- .gitlab-ci/container/build-vulkan-validation.sh | 12 +++++++----- .pick_status.json | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.gitlab-ci/container/build-vulkan-validation.sh b/.gitlab-ci/container/build-vulkan-validation.sh index ead6c127f505e..572fa71f698b3 100644 --- a/.gitlab-ci/container/build-vulkan-validation.sh +++ b/.gitlab-ci/container/build-vulkan-validation.sh @@ -1,15 +1,17 @@ #!/usr/bin/env bash +# When changing this file, you need to bump the following +# .gitlab-ci/image-tags.yml tags: +# DEBIAN_X86_TEST_GL_TAG + set -ex VALIDATION_TAG="v1.3.238" git clone -b "$VALIDATION_TAG" --single-branch --depth 1 https://github.com/KhronosGroup/Vulkan-ValidationLayers.git pushd Vulkan-ValidationLayers -mkdir build -pushd build -python3 ../scripts/update_deps.py --dir ../external --arch x64 --config debug -cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_TESTS=OFF -DBUILD_WERROR=OFF -C ../external/helper.cmake .. -ninja install +python3 scripts/update_deps.py --dir external --config debug +cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_TESTS=OFF -DBUILD_WERROR=OFF -C external/helper.cmake -S . -B build +ninja -C build install popd rm -rf Vulkan-ValidationLayers diff --git a/.pick_status.json b/.pick_status.json index d0dbbb212fa7b..ee87793e5ce26 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -994,7 +994,7 @@ "description": "ci: rework vulkan validation layer build script", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "512f1c160a63a7ba1b0097166d8ec0324542d639" },