From 3047fd4783a961a631b77798f938341f089bd50c Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Mon, 30 Sep 2019 22:46:47 +0100 Subject: [PATCH] gitlab: convert old REVIEWERS into GitLab's CODEOWNERS The old REVIEWERS file was useful back in the mailing lists days, but nowadays we use GitLab, and we tag people by using their usernames, not email addresses. Most of us know each other's usernames by now, but documentation like this is not meant for us but for everyone else, so that they can talk to us. Let's convert the file into GitLab's CODEOWNERS format, which maps files in the repository to GitLab users that people can look up or tag in their issues or merge requests. See also: https://docs.gitlab.com/ce/user/project/code_owners.html Signed-off-by: Eric Engestrom Reviewed-by: Adam Jackson Reviewed-by: Alyssa Rosenzweig Part-of: --- CODEOWNERS | 107 +++++++++++++++++++++++++++++++++++++++++++++++++ REVIEWERS | 114 ----------------------------------------------------- 2 files changed, 107 insertions(+), 114 deletions(-) create mode 100644 CODEOWNERS delete mode 100644 REVIEWERS diff --git a/CODEOWNERS b/CODEOWNERS new file mode 100644 index 0000000000000..84da2bf90d457 --- /dev/null +++ b/CODEOWNERS @@ -0,0 +1,107 @@ +# This file contains the GitLab handle of the maintainers/reviewers for +# a given file: +# https://docs.gitlab.com/ce/user/project/code_owners.html +# +# Consider these as the list of people who want to be involved in MRs +# touching these files/folders, and whom you can ask your questions and +# tag in issues. +# +# As of GitLab 14.3, all features surrounding this file are premium-only, +# which means this file is only read by humans for now. +# +# Paths starting with a `/` are relative to the git root, otherwise they +# can match any substring of the file's path. +# If multiple lines match, only the last one applies; there is no +# accumulation. + + +################## +# INFRASTRUCTURE # +################## + +# Build system - Meson +meson.build @dbaker @eric +/meson_options.txt @dbaker @eric +/docs/meson.rst @dbaker @eric + +# Compatibility headers +/include/c99* @evelikov +/include/c11* @eric + +# Documentation +/docs/ @eric @evelikov + + +########## +# COMMON # +########## + +# NIR +/src/compiler/nir/ @jekstrand + +# Vulkan +/src/vulkan/ @eric @jekstrand +/include/vulkan/ @eric @jekstrand + + +############# +# PLATFORMS # +############# + +# EGL +/src/egl/ @eric @evelikov +/include/EGL/ @eric @evelikov + +# EGL - Android support +/src/egl/drivers/dri2/platform_android.c @robh @tfiga + +# EGL - Device support +/src/egl/drivers/dri2/platform_device.c @evelikov + +# EGL - Wayland support +/src/egl/wayland/ @daniels @eric +/src/egl/drivers/dri2/platform_wayland.c @daniels @eric + +# Gallium targets +/src/gallium/targets/ @evelikov + +# GLX +/src/glx/ @ajax +/include/GL/glx* @ajax + +# GLVND +/src/egl/main/eglglvnd.c @kbrenneman +/src/egl/main/egldispatchstubs.* @kbrenneman +/src/egl/generate/ @kbrenneman +/src/glx/*glvnd* @kbrenneman + +# Haiku +/include/HaikuGL/ @kallisti5 +/src/egl/drivers/haiku/ @kallisti5 +/src/gallium/frontends/hgl/ @kallisti5 +/src/gallium/targets/haiku-softpipe/ @kallisti5 +/src/gallium/winsys/sw/hgl/ @kallisti5 +/src/hgl/ @kallisti5 + +# Loader - DRI/classic +/src/loader/ @evelikov + +# Loader - Gallium +/src/gallium/auxiliary/pipe-loader/ @evelikov +/src/gallium/auxiliary/target-helpers/ @evelikov + +# Vulkan WSI - Display +/src/vulkan/wsi/wsi_common_display.* @keithp +/src/*/vulkan/*_wsi_display.c @keithp + + +########### +# Drivers # +########### + +# Freedreno +/src/gallium/drivers/freedreno/ @robclark + +# VMware +/src/gallium/drivers/svga/ @brianp @charmainel +/src/gallium/winsys/svga/ @thomash @drawat diff --git a/REVIEWERS b/REVIEWERS deleted file mode 100644 index 81baad876b0e5..0000000000000 --- a/REVIEWERS +++ /dev/null @@ -1,114 +0,0 @@ -Overview: - - This file is similar in syntax (or more precisly a subset) of what is - used by the MAINTAINERS file in the linux kernel. - The purpose is not exactly the same the MAINTAINERS file in the linux - kernel, as there are not official/formal maintainers of different - subsystems in mesa, but is meant to give an idea of who to CC for - various patches for review. - -Descriptions of section entries: - - R: Designated reviewer: FullName - These reviewers should be CCed on patches. - F: Files and directories with wildcard patterns. - A trailing slash includes all files and subdirectory files. - F: drivers/net/ all files in and below drivers/net - F: drivers/net/* all files in drivers/net, but not below - F: */net/* all files in "any top level directory"/net - One pattern per line. Multiple F: lines acceptable. - -Maintainers List (try to look for most precise areas first) - -Note: this is an opt-in system, I have not tried to add anyone who hasn't -either asked me or sent a patch to add themselves. - - ----------------------------------- - -NIR -R: Jason Ekstrand -F: src/compiler/nir/ - -DOCUMENTATION -R: Emil Velikov -R: Eric Engestrom -F: docs/ - -COMPATIBILITY HEADERS -R: Emil Velikov -F: include/c99* - -DRI LOADER -R: Emil Velikov -F: src/loader/ - -EGL -R: Eric Engestrom -R: Emil Velikov -F: src/egl/ -F: include/EGL/ - -HAIKU -R: Alexander von Gluck IV -F: include/HaikuGL/ -F: src/egl/drivers/haiku/ -F: src/gallium/frontends/hgl/ -F: src/gallium/targets/haiku-softpipe/ -F: src/gallium/winsys/sw/hgl/ -F: src/hgl/ - -GALLIUM LOADER -R: Emil Velikov -F: src/gallium/auxiliary/pipe-loader/ -F: src/gallium/auxiliary/target-helpers/ - -GALLIUM TARGETS -R: Emil Velikov -F: src/gallium/targets/ - -ANDROID BUILD -R: Emil Velikov -R: Rob Herring -F: CleanSpec.mk -F: */Android.*mk -F: */Makefile.sources - -MESON BUILD -R: Dylan Baker -R: Eric Engestrom -F: */meson.build -F: meson.build -F: meson_options.txt - -ANDROID EGL SUPPORT -R: Rob Herring -R: Tomasz Figa -F: src/egl/drivers/dri2/platform_android.c - -WAYLAND EGL SUPPORT -R: Daniel Stone -F: src/egl/wayland/* -F: src/egl/drivers/dri2/platform_wayland.c - -FREEDRENO -R: Rob Clark -F: src/gallium/drivers/freedreno/ - -GLX -R: Adam Jackson -F: src/glx/ - -VULKAN -R: Eric Engestrom -F: src/vulkan/ -F: include/vulkan/ - -VMWARE DRIVER -R: Brian Paul -R: Charmaine Lee -F: src/gallium/drivers/svga/ - -VMWARE WINSYS CODE -R: Thomas Hellstrom -R: Deepak Rawat -F: src/gallium/winsys/svga/