From 2d8686ccd55b9df3396be1feb967bc9026f38b15 Mon Sep 17 00:00:00 2001 From: Sagar Ghuge Date: Fri, 19 Apr 2024 08:52:28 -0700 Subject: [PATCH] isl: Update isl_swizzle_supports_rendering comment Bspec 57023: RENDER_SURFACE_STATE:: Shader Channel Select Red "Render Target messages do not support swapping of colors with alpha. The Red, Green, or Blue Shader Channel Selects do not support SCS_ALPHA. The Shader Channel Select Alpha does not support SCS_RED, SCS_GREEN, or SCS_BLUE." Cc: mesa-stable Signed-off-by: Sagar Ghuge Reviewed-by: Lionel Landwerlin Part-of: --- src/intel/isl/isl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 6e3f4f85dc5cf..c0b154cd6c5e3 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -4227,6 +4227,13 @@ isl_swizzle_supports_rendering(const struct intel_device_info *devinfo, * * "For Render Target, this field MUST be programmed to * value = SCS_ALPHA." + * + * Bspec 57023: RENDER_SURFACE_STATE:: Shader Channel Select Red + * + * "Render Target messages do not support swapping of colors with + * alpha. The Red, Green, or Blue Shader Channel Selects do not + * support SCS_ALPHA. The Shader Channel Select Alpha does not support + * SCS_RED, SCS_GREEN, or SCS_BLUE." */ return (swizzle.r == ISL_CHANNEL_SELECT_RED || swizzle.r == ISL_CHANNEL_SELECT_GREEN ||