address PR comments

This commit is contained in:
arthurdead 2022-08-29 02:28:35 -03:00
parent 8bd9bc8b6d
commit 9918bbd0cb
3 changed files with 6 additions and 6 deletions

View File

@ -107,8 +107,10 @@ void JoltPhysicsFluidController::OnJoltPhysicsObjectDestroyed( JoltPhysicsObject
std::erase_if( m_ObjectsInShape, [pObject]( JoltPhysicsObject *pCachedObject ) { return pObject == pCachedObject; } );
#else
for ( auto it( m_ObjectsInShape.begin() ); it != m_ObjectsInShape.end(); ++it ) {
if ( *it == pObject )
it = m_ObjectsInShape.erase(it);
if ( *it == pObject ) {
m_ObjectsInShape.erase(it);
break;
}
}
#endif
}

View File

@ -5,12 +5,10 @@
struct JoltPhysicsContactPair
{
#if __cplusplus < 202002L
JoltPhysicsContactPair( JoltPhysicsObject *object1, JoltPhysicsObject *object2 )
: pObject1(object1), pObject2(object2)
{
}
#endif
JoltPhysicsObject *pObject1 = nullptr;
JoltPhysicsObject *pObject2 = nullptr;

View File

@ -58,7 +58,7 @@ bool JoltPhysicsObjectPairHash::IsObjectPairInHash( void *pObject0, void *pObjec
#if __cplusplus >= 202002L
return pairHashes.contains( pair );
#else
return pairHashes.find( pair ) != pairHashes.cend();
return pairHashes.find( pair ) != pairHashes.end();
#endif
}
@ -79,7 +79,7 @@ bool JoltPhysicsObjectPairHash::IsObjectInHash( void *pObject0 )
#if __cplusplus >= 202002L
return m_Objects.contains( pObject0 );
#else
return m_Objects.find( pObject0 ) != m_Objects.cend();
return m_Objects.find( pObject0 ) != m_Objects.end();
#endif
}