ab96181e91
blockchain: use effective median block weight for penalty from v12
...
It was using the raw block weight median, which was not what was
intended in ArticMine's design
2019-10-11 14:16:09 +00:00
1ba9bafd33
tx_pool: do not divide by 0
...
In case of a 0 tx weight, we use a placeholder value to insert in the
fee-per-byte set. This is used for pruning and mining, and those txes
are pruned, so will not be too large, nor added to the block template
if mining, so this is safe.
CID 204465
2019-10-11 14:09:31 +00:00
fe443bbdec
cryptonote: don't leave block_weight uninitialized
...
CID 204467
2019-10-11 14:09:31 +00:00
88c9d90ac4
protocol: initialize block_weight in block_complete_entry ctor
...
CID 204479
2019-10-11 14:09:31 +00:00
9447e7276d
cryptonote: add function to get weight from a pruned tx
...
The weight of the prunable data is deterministic from the
unpruned data, so it can be determined from a pruned tx
2019-10-11 12:08:36 +00:00
01f660f60f
blockchain: fill in cumulative block weight for alt blocks
2019-10-10 20:26:40 +00:00
e85c838154
simplewallet: do not print warning for locked coinbase txes
...
since they're all locked for a fixed amount
2019-10-10 18:29:30 +00:00
abd376313b
cryptonote: fill in tx weight when syncing from pruned blocks
2019-10-10 11:08:02 +00:00
bf525793c7
Merge pull request #5915
...
8330e77
2019-10-08 15:55:03 -05:00
5920913171
Merge pull request #5948
...
1c600a42675cf4f54301d
2019-10-08 14:48:36 -05:00
b0840a8e01
Merge pull request #5932
...
f3b65c6
2019-10-08 14:45:21 -05:00
a74a82c8b2
Merge pull request #5926
...
74a23e9
2019-10-08 14:42:41 -05:00
342e7f844f
Merge pull request #5921
...
2a7d915
2019-10-08 14:31:53 -05:00
f54301dd75
Fix for miners on reorg
...
Make sure dataset gets re-init'd if a reorg changes the epoch
2019-10-07 09:50:00 +01:00
fd4846134d
Print cdifficulty and don't serialize miner tx hash twice
2019-10-07 12:50:05 +11:00
ec14abdbe8
tx_pool: make spent return-by-reference as intended
2019-10-06 12:28:30 +09:00
2675cf4483
Update to RandomX v1.1.3, simplify
...
We don't need to detect if the cache has changed, just always
call to set it on the VM. The call will be a no-op if the cache
hasn't changed.
2019-10-05 18:51:20 +01:00
4d22317dee
wallet2: don't delete file that may not exist
2019-10-04 20:43:40 +02:00
1c600a492f
Fix randomx cache selection for RPCs
...
Was using the wrong cache slot, and returning invalid PoW hashes to RPC clients
2019-10-03 20:05:17 +01:00
32febd277d
Fix debug feature
2019-10-03 16:05:40 +02:00
235b94eb59
Revert PR #5835 (export view key)
2019-10-03 16:05:40 +02:00
34f28a79bc
Add display address
2019-10-03 16:05:32 +02:00
d25acd7a1d
Add hmac over encrypted value during transaction
2019-10-03 16:01:34 +02:00
4ce40edb27
p2p: reject invalid pruning seeds in peer lists
2019-10-02 19:29:05 +00:00
ec7f2ff9ed
p2p: reject invalid rpc_port in peer lists
2019-10-02 19:04:57 +00:00
93d5cf2441
wallet2: add ignore-outputs-{above/below} option
...
https://github.com/aeonix/aeon/pull/131
2019-10-02 13:04:24 +09:00
16498dc8ef
simplewallet.cpp - clean up welcome message
...
Fixed a typo ("and -are- not visible to the world by default"), removed a few redundant commas, and capitalized words inside the URL.
2019-10-01 02:32:32 +00:00
b60cf6a938
Merge pull request #5939
...
9baf2a7
2019-09-30 18:57:54 -05:00
3f732841f5
Merge pull request #5906
...
bd9c12e
2019-09-30 18:53:10 -05:00
17f063a50f
Merge pull request #5902
...
b9da023
2019-09-30 18:52:11 -05:00
d9cb50870d
Merge pull request #5900
...
6bbc646
2019-09-30 18:49:09 -05:00
e23b9847d0
Merge pull request #5894
...
c89f7ef
2019-09-30 18:45:41 -05:00
c6430f9dd0
Merge pull request #5893
...
Coverity fixes [3a816391bd962d2825f07d099658d46f701cd57a10
2019-09-30 18:43:48 -05:00
d37d30f79a
blockchain: tweak fee as a function of median values
...
Use the lesser of the short and long terms medians, rather then
the long term median alone
From ArticMine:
I found a bug in the new fee calculation formula with using only the long term median
It actually needs to be the lesser of the long term median and the old (modified short term median)
short term median with the last 10 blocks calculated as empty
Yes the issue occurs if there is a large long term median and, the short term median then falls and tries to then rise again
The fees are could be not high enough
for example LTM and STM rise to say 2000000 bytes
STM falls back to 300000 bytes
Fees are now based on 2000000 bytes until LTM also falls
So the STM is could prevented from rising back up
STM short term median LTM long term median
2019-09-28 22:53:41 +00:00
6b4bc0d389
RPC on_transfer_split error consistent with on_transfer if no tx sent
2019-09-28 19:22:15 +02:00
9baf2a7caa
build: link wallet_merged against blockchain_db and hardforks obj
2019-09-28 12:35:33 +00:00
8330e772f1
monerod can now sync from pruned blocks
...
If the peer (whether pruned or not itself) supports sending pruned blocks
to syncing nodes, the pruned version will be sent along with the hash
of the pruned data and the block weight. The original tx hashes can be
reconstructed from the pruned txes and theur prunable data hash. Those
hashes and the block weights are hashes and checked against the set of
precompiled hashes, ensuring the data we received is the original data.
It is currently not possible to use this system when not using the set
of precompiled hashes, since block weights can not otherwise be checked
for validity.
This is off by default for now, and is enabled by --sync-pruned-blocks
2019-09-27 00:10:37 +00:00
81c2ad6d5b
RandomX integration
...
Support RandomX PoW algorithm
2019-09-25 21:29:42 +01:00
3455efafa8
ban peers sending bad pow outright
...
PoW is expensive to verify, so be strict
2019-09-25 16:00:43 +00:00
f3b65c66f8
Request a thread stack size that is large enough for unbound
...
Unbound uses a 64 kb large character array on the stack, which
leads to a stack overflow for some libc implementations. musl
only gives 80 kb in total. This PR changes the stack size for
these threads to 1mb, which solves the segmentation fault.
2019-09-25 16:37:06 +02:00
3f6096867d
Merge pull request #5916
...
7b076d5
2019-09-24 10:42:29 -05:00
5fe38977b5
Merge pull request #5905
...
Revert a96c1a4adc16d2
2019-09-24 10:39:28 -05:00
74a23e9a59
protocol: only print sync complete message when out of precompiled hashes
...
This avoids most premature triggers
2019-09-24 15:29:59 +00:00
44aa7d5439
Merge pull request #5882
...
a444f06
2019-09-24 10:27:22 -05:00
06bee964a8
Merge pull request #5878
...
f9b3f6e
2019-09-24 10:10:28 -05:00
ee6e849627
Merge pull request #5877
...
2cd4fd84ad191f928f4be
2019-09-24 10:08:44 -05:00
8c41d36a08
Merge pull request #5864
...
32f725d
2019-09-24 10:05:21 -05:00
a1736a9429
Merge pull request #5848
...
functional_tests (moneromooo-monero)
2019-09-24 10:04:03 -05:00
d0663837d2
core: move hardforks into its own lib
...
So it can be used by others without encumbrance
2019-09-19 11:28:18 +00:00
a444f06e53
blockchain: enforce 10 block age for spending outputs
...
Some custom wallet code apparently ignores this, which causes users
of that code to be fingerprinted
2019-09-17 11:39:25 +00:00
d53a55204f
functional_tests: add get_transaction_pool_stats
...
Also fix part of the RPC results being returned as binary.
This makes the RPC backward incompatible.
2019-09-17 11:38:29 +00:00
cc4be4fa15
wallet: add edit_address_book RPC
2019-09-17 11:38:23 +00:00
7b076d5170
p2p: fix bans taking port into account
2019-09-16 22:45:45 +00:00
32f725d32f
Properly format multiline logs
...
As a side effect, colouring on Windows should now work
regardless of version
2019-09-16 16:58:01 +00:00
f9b3f6ef3b
Removed Berkeley DB and db switching logic
2019-09-16 16:18:05 +02:00
2c171a9b02
Merge pull request #5861
...
f0356f7
2019-09-14 13:27:18 -05:00
d663e1e3db
Merge pull request #5818
...
f91a06c
2019-09-14 13:25:14 -05:00
dbe31f63e1
Merge pull request #5899
...
7d3bba5
2019-09-14 13:23:28 -05:00
76805b62ce
Merge pull request #5874
...
f380f69
2019-09-14 13:19:01 -05:00
85962ee8e2
Merge pull request #5872
...
495a7e5
2019-09-14 13:16:45 -05:00
d00e511cc6
Merge pull request #5871
...
3407743
2019-09-14 13:14:22 -05:00
e753663d31
Merge pull request #5870
...
83ca764
2019-09-14 13:12:44 -05:00
b526208001
Merge pull request #5868
...
1f1fff2
2019-09-14 13:10:51 -05:00
6e1257cfbd
Merge pull request #5866
...
21f6c80
2019-09-14 13:09:32 -05:00
4a39e1a4a5
Merge pull request #5865
...
11f13da19bfe7e
2019-09-14 13:07:35 -05:00
3e75df42a7
Merge pull request #5854
...
2cb22d4
2019-09-14 13:06:05 -05:00
29e0f11305
Merge pull request #5823
...
26072f1555dc7cd22dfb7
2019-09-14 13:04:41 -05:00
b9da0234e9
blockchain: keep block template timestamp not below recent median
...
Such a template would yield an invalid block, though would require
an attacker to have mined a long blockchain with drifting times
(assuming the miner's clock is roughly correct)
Fixed by crCr62U0
2019-09-11 15:21:52 +00:00
bd9c12e18a
simplewallet: remove erroneously added line under subaddress-lookahead
2019-09-11 10:50:20 +09:00
62fc4bec4c
Revert "cryptonote_protocol: drop peers we can't download from when syncing"
...
This reverts commit a96c1a46d4
2019-09-11 01:04:44 +00:00
ea92a32f72
Revert "Fix check for disconnecting peers when syncing"
...
This reverts commit adc16d2504
2019-09-11 01:04:01 +00:00
f0356f74d3
wallet2: enable ignoring fractional outputs also when sweeping
2019-09-10 12:24:08 +09:00
7d3bba5ca0
wallet2_api: add missing parameter
2019-09-09 16:03:47 +02:00
9325501762
Merge pull request #5855
...
2ec455d
2019-09-08 20:04:00 -05:00
19ef2e99ad
Merge pull request #5850
...
c4da1a2
2019-09-08 20:00:55 -05:00
d30b234f08
Merge pull request #5849
...
b51f4cd
2019-09-08 19:59:05 -05:00
1fd43d3f9f
Merge pull request #5847
...
894cc81
2019-09-08 19:57:49 -05:00
871661f3dc
Merge pull request #5843
...
9f6866950813c1
2019-09-08 19:56:33 -05:00
db87e92b34
Merge pull request #5842
...
87d2f06
2019-09-08 19:53:27 -05:00
86938725ae
Merge pull request #5841
...
cae488d
2019-09-08 19:48:09 -05:00
21290005d7
Merge pull request #5840
...
063eebb
2019-09-08 19:46:03 -05:00
15dabf7d18
Merge pull request #5839
...
e353e3d
2019-09-08 19:45:09 -05:00
3b28ff2d6d
Merge pull request #5838
...
2e26536
2019-09-08 19:43:46 -05:00
4ef3848423
Merge pull request #5835
...
26f7a26
2019-09-08 19:42:49 -05:00
253786c8ea
Merge pull request #5833
...
289d215
2019-09-08 19:41:27 -05:00
da4512639e
Merge pull request #5830
...
5a4c6cc
2019-09-08 19:40:29 -05:00
c89f7effd1
wallet2_api: fix load unsigned tx from file error propagation
2019-09-09 00:03:55 +00:00
d099658522
bootstrap_daemon: resolve CID 203915 (UNCAUGHT_EXCEPT)
...
The issue is triggered by the captured `this` in RPC server, which
passes reference to throwable `core_rpc_server`:
`core_rpc_server.cpp:164: m_bootstrap_daemon.reset(new bootstrap_daemon([this]{ return get_random_public_node(); }));`
The solution is to simply remove noexcept from the remaining `bootstrap_daemon`
constructors because noexcept is false in this context.
>"An exception of type "boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::asio::invalid_service_owner>>" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate()."
2019-09-07 00:29:09 +00:00
1bd962d9f9
wallet2: resolve CID 203918 null pointer deference (NULL_RETURNS)
2019-09-06 23:11:37 +00:00
928f4be953
Make null hash constants constexpr
...
Simplify m_template initialization in miner
2019-09-05 17:37:19 +02:00
2ec455df1f
wallet: fix mismatch between two concepts of "balance"
...
One considers the blockchain, while the other considers the
blockchain and some recent actions, such as a recently created
transaction which spend some outputs, but isn't yet mined.
Typically, the "balance" command wants the latter, to reflect
the recent action, but things like proving ownership wants
the former.
This fixes a crash in get_reserve_proof, where a preliminary
check and the main code used two concepts of "balance".
2019-09-05 11:19:34 +00:00
340774341f
wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_payments
...
Much easier to work with than the raw unlock_time field
2019-09-05 10:54:57 +00:00
bc1144e98e
Fix IP address serialization on big endian
...
IP addresses are stored in network byte order even on little
endian hosts
2019-09-04 14:54:01 +00:00
54fd97ae3f
slow-hash: fix CNv2+ on big endian
2019-09-04 14:53:59 +00:00
4672b5cea9
db_lmdb: print percentages as percentages, not ratios
2019-09-04 14:53:59 +00:00
d046ca1db0
difficulty: fix check_hash on big endian
2019-09-04 14:53:53 +00:00
a567e884b2
Merge pull request #5822
...
839fc62
2019-09-04 09:39:07 -05:00
e4f11a68fe
Merge pull request #5819
...
07cb087
2019-09-04 09:37:32 -05:00
902e4b6ebf
Merge pull request #5806
...
69465e3
2019-09-04 09:28:22 -05:00
0198b76217
Merge pull request #5799
...
082730b
2019-09-04 09:27:02 -05:00
23547e6ed6
Merge pull request #5536
...
1a367d6
2019-09-04 09:18:38 -05:00
4ad191ffa9
Removed unused boost/value_init header
2019-09-02 14:38:29 +02:00
2cd4fd8972
Changed the use of boost:value_initialized for C++ list initializer
2019-09-02 14:16:29 +02:00
98af2e954b
Merge pull request #5793
...
bdfc63a3b24b1d
2019-08-29 14:36:41 -05:00
f380f69c69
simplewallet: warn if invalid default ring size is set and actually ignore the setting
2019-08-29 15:55:53 +09:00
1a367d6a22
simplewallet: lock console on inactivity
2019-08-28 19:01:48 +00:00
495a7e5b97
rpc: don't include an address in mining_status when not mining
...
Best case is an address mined previously and it'll get returned,
worst case it was never initialized in the first place
2019-08-28 16:02:37 +00:00
83ca76435b
wallet_rpc_server: call deinit on exit
2019-08-28 15:59:33 +00:00
1f1fff2679
daemon: print mining algorithm in mining_status even when not mining
2019-08-28 15:55:31 +00:00
21f6c80fcd
rpc: move a leftover light wallet RPC out of daemon RPC
2019-08-28 15:51:28 +00:00
19bfe7e5ab
simplewallet: fix warnings about useless std::move
2019-08-28 15:13:50 +00:00
11f13da8b4
blockchain: fix logging bad number of blocks if first one fails
2019-08-28 14:53:29 +00:00
6bbc646e6f
Fix bug in mempool get_transaction_stats histogram calculation
...
The 98th percentile position in the agebytes map was incorrectly
calculated: it assumed the transactions in the mempool all have unique
timestamps at second-granularity. This commit fixes this by correctly
finding the right cumulative number of transactions in the map suffix.
This bug could lead to an out-of-bounds write in the rare case that
all transactions in the mempool were received (and added to the mempool)
at a rate of at least 50 transactions per second. (More specifically,
the number of *unique* receive_time values, which have second-
granularity, must be at most 2% of the number of transactions in the
mempool for this crash to trigger.) If this condition is satisfied, 'it'
points to *before* the agebytes map, 'delta' gets a nonsense value, and
the value of 'i' in the first stats.histo-filling loop will be out of
bounds of stats.histo.
2019-08-28 16:46:31 +02:00
85014813cf
Merge pull request #5707
...
3a0451a
2019-08-28 02:22:00 -05:00
3a0451a8be
MLSAG speedup and additional checks
2019-08-27 16:22:44 -04:00
f68512e9e4
Merge pull request #5729
...
7c894fcf07524b
2019-08-27 15:19:47 -05:00
8f6f674753
Merge pull request #5609
...
1dc3b1a
2019-08-27 15:14:15 -05:00
3e80f44503
Merge pull request #5559
...
33e91e1
2019-08-27 15:09:37 -05:00
082730b6e5
daemon: automatic public nodes discovering and bootstrap daemon switching
2019-08-27 12:01:49 +00:00
33e91e1a1e
wallet, rpc: add a release field to get_version
...
It does not leak much since you can make a fair guess by RPC
version already, and some people want to avoid non release
clients when using third parties' nodes (because they'd never
lie about it)
2019-08-26 19:28:25 +00:00
f07524b56b
device_ledger: fix uninitialized additional_key
...
Coverity 200185
2019-08-26 12:50:29 +00:00
7c894fc7fd
device_ledger: add paranoid buffer overflow check
...
Coverity 200183
2019-08-26 12:50:26 +00:00
2cb22d4071
core: make the "update probably needed soon" message less scary
2019-08-26 07:56:55 +00:00
c4da1a25c3
wallet2: fix unset_ring tx retrieval checks
2019-08-24 14:46:31 +00:00
87d2f063af
simplewallet: moan harder about untrusted nodes
2019-08-24 12:36:10 +00:00
b51f4cdcaf
daemon: add pruned and publicrpc flags to print_pl
2019-08-23 19:15:45 +00:00
894cc81e83
wallet2: fix cold signing losing tx keys
2019-08-23 16:38:20 +00:00
063eebbd43
daemon: implement 'set_bootstrap_daemon' command
2019-08-23 12:09:02 +00:00
cae488dc9b
p2p: reject incoming connections to self
2019-08-22 17:08:29 +00:00
63186a01ce
Wallet: Option to export data to ASCII
...
New CLI wallet variable: export-format with options "binary" (the default),
or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert
data to ASCII using base64.
Reading files from the disk tries to auto detect what format has been
used (using a magic string added when exporting the data).
Implements https://github.com/monero-project/monero/issues/2859
2019-08-22 16:03:22 +02:00
50813c103e
ringdb: fix bug in blackballing
2019-08-22 21:34:48 +09:00
2425f27acd
blockchain_blackball: use is_output_spent instead of ringdb.blackballed for spentness test
2019-08-22 21:34:47 +09:00
9f68669503
blockchain_blackball: add --historical-stat which prints historical stats of spent ratio
2019-08-22 21:34:40 +09:00
1dc3b1a516
wallet: add --extra-entropy command line flag
...
It lets the user add custom entropy to the PRNG.
It does this by hashing the new data and xoring the resulting
hash with the PRNG state.
2019-08-22 11:12:57 +00:00
cdfa2e58df
Merge pull request #5827
...
30779de
2019-08-21 15:54:10 -05:00
2be47ae02a
Merge pull request #5817
...
50ec40e
2019-08-21 15:49:51 -05:00
7bdff6005f
Merge pull request #5815
...
adc16d2
2019-08-21 15:48:09 -05:00
d8244eb39c
Merge pull request #5808
...
5a91b83ae7bf37
2019-08-21 15:41:42 -05:00
0a42fddde4
Merge pull request #5807
...
4b1df4e
2019-08-21 15:38:35 -05:00
28e0a28b96
Merge pull request #5800
...
6ca033d
2019-08-21 15:36:05 -05:00
11ab328ce3
Merge pull request #5778
...
8703aa5
2019-08-21 15:31:11 -05:00
eea0123de4
Merge pull request #5755
...
7a3e458
2019-08-21 15:23:58 -05:00
1bd3f1a1fb
Merge pull request #5750
...
884df82
2019-08-21 15:20:51 -05:00
de30131abd
Merge pull request #5743
...
65f29a8
2019-08-21 15:17:26 -05:00
b488ee8188
Merge pull request #5742
...
0d916a6
2019-08-21 15:13:16 -05:00
9e8179ca84
Merge pull request #5740
...
256d286
2019-08-21 15:11:32 -05:00
8956e90c63
Merge pull request #5731
...
c393e82
2019-08-21 15:09:48 -05:00
65e937168e
Merge pull request #5722
...
8be5fea
2019-08-21 15:08:10 -05:00
e353e3d757
p2p: sanitize peer lists
...
Also remove the delta time fixup, since we now ignore those
as they're attacker controlled
2019-08-21 15:54:27 +00:00
2e2653602f
p2p: move log away from global
...
It was here while debugging, and I forgot to move it away
2019-08-21 14:00:43 +00:00
moneromooo-monero
luigi1111
Howard Chu
Doyle
stoffu
selsta
Howard Chu
cslashm
xiphon
SomaticFanatic
binaryFate
Martijn Otto
Jesus Ramirez
anonimal
Lev Sizov
Tom Smeding
Sarang Noether
Tadeas Moravec