8e3f46dd0a
Merge pull request #6881
...
11b20229c
2020-10-18 23:25:54 -07:00
142489bd60
Merge pull request #6882
...
fcbfb0a00
2020-10-18 23:25:32 -07:00
543d600042
Merge pull request #6875
...
a12a8174e
2020-10-18 23:25:08 -07:00
fc2f97177b
wallet2: wait for propagation timeout before marking tx as failed
2020-10-18 14:00:56 +00:00
c67fa32496
bump default number of connections from 8 to 12
2020-10-18 13:25:05 +00:00
b7dd8349f4
Allow setting start block on export
...
And make import honor the starting block# recorded in a bootstrap file
2020-10-18 14:01:44 +01:00
519740a1d3
Merge pull request #6905
...
88fde0309
2020-10-18 05:51:43 -07:00
88fde0309a
blockchain: fix sync at v14 boundary
...
Miners with MLSAG txes which they'd already verified included
a couple in that block, but the consensus rules had changed
in the meantime, so that block is technically invalid and any
node which did not already have those two txes in their txpool
could not sync. Grandfather them in, since it has no effect in
practice.
2020-10-18 11:52:33 +00:00
70eb0d1844
wallet2_api: implement stop() to interrupt refresh() loop once
2020-10-17 02:56:15 +00:00
13350f79df
Do not use peer_id tracking method over i2p/tor
2020-10-15 16:47:59 +00:00
593ae2e9f9
device: Ledger - update status codes
2020-10-13 22:53:19 +00:00
e503688a6b
Merge pull request #6828
...
1b3f220
2020-10-13 10:39:05 -05:00
ec14e4b8cd
wallet2: skip reorgs exceeding max-reorg-depth wallet setting
2020-10-13 15:23:35 +00:00
b49f48962b
fix next_seed_height regression in getblocktemplate rpc
2020-10-13 11:07:59 +01:00
4cf3545a31
core_rpc_server: on_get_blocks - forward bootstrap daemon error
2020-10-13 00:44:59 +00:00
ad7ea2c60c
core_rpc_server: on_send_raw_tx - fix bootstrap daemon mode check
2020-10-12 23:49:37 +00:00
fcbfb0a00a
wallet2: fix missing m_state field in wallet serialization
2020-10-12 15:35:52 +00:00
11b20229c9
tx_pool: silence spammy harmless warning till we fix the bug
2020-10-12 14:07:40 +00:00
a12a8174e0
Dandelion++: skip desynced peers in stem phase
2020-10-12 13:44:06 +00:00
7414e2bac1
Change epee binary output from std::stringstream to byte_stream
2020-10-10 15:28:40 +00:00
dff1d8067c
Fix tx flush callback queueing
2020-10-06 16:07:49 +00:00
3cbb44a2fd
Merge pull request #6841
...
b6c4f8cd5
2020-09-27 16:17:17 -07:00
f4b2382713
rpc_private_headers declaration fix
2020-09-27 13:41:44 +01:00
b6c4f8cd54
fix a couple bugs found by OSS-fuzz
...
- index out of bounds when importing outputs
- accessing invalid CLSAG data
2020-09-24 15:30:38 +00:00
4846743fdc
daemon: Windows - fix FAT32 warning, trailing backslash is required
2020-09-20 13:57:44 +00:00
64e9526509
Extend TransactionInfo with coinbase and description attributes in wallet/api
2020-09-19 22:54:23 +02:00
1b3f220251
Allow AddressBook description edits via wallet/api interface
2020-09-19 18:29:46 +02:00
83da867474
Update error messages in daemon
...
When given a wrong argument, some daemon commands failed with "unknown
command" error, instead of a meaningful error message. This patch
brings consistency into the error messages.
In several places, this patch removes relatively useful messages,
and replaces them with more generic ones. E.g.,
- std::cout << "use: print_pl [white] [gray] [<limit>] [pruned]
[publicrpc]" << std::endl;
+ std::cout << "Invalid syntax: Too many parameters. For more
details, use the help command." << std::endl;
There are two reasons for this:
1. Consistency.
2. Removing duplicates.
The detailed information about the parameters is present in
the help messages already. Having it in two places increases
the risk that the messages would get out of date.
2020-09-18 14:04:19 +02:00
d27d4526fe
Merge pull request #6819
...
c3f354e
2020-09-15 19:59:36 -05:00
5b3614e6a9
Merge pull request #6816
...
929ea98
2020-09-15 19:58:39 -05:00
2b1488ef6f
Merge pull request #6793
...
de9a9fb
2020-09-15 19:56:49 -05:00
80e535c95a
wallet2: adapt to deterministic unlock time
2020-09-15 11:40:31 +00:00
4971219c2c
blockchain: deterministic UNIX time unlock checks
...
Based on a patch by TheCharlatan <seb.kung@gmail.com>
2020-09-15 11:40:28 +00:00
c3f354e6c1
simplewallet fix wrong persistent-rpc-client-id name in help
2020-09-14 20:50:35 +00:00
9bba1a24ea
Merge pull request #6815
...
ef4325f
2020-09-14 11:47:06 -05:00
2993d2004a
Merge pull request #6813
...
a3844e2
2020-09-14 11:45:55 -05:00
f240b1dd88
build: prepare v0.17
2020-09-14 16:52:42 +02:00
929ea98662
Remove unused macros from cryptonote_config.h
2020-09-14 00:20:58 +02:00
ef4325fd41
wallet2: fix tx sanity check triggering on pre-rct outputs
2020-09-12 17:51:41 +00:00
a3844e257e
Fix typo in command line argument description
2020-09-09 10:18:32 -04:00
836067b68b
Merge pull request #6805
...
fc2cb22
2020-09-07 15:31:20 -05:00
9c9c689db4
Merge pull request #6804
...
5498142
2020-09-07 14:34:46 -05:00
3a761e10d2
Merge pull request #6800
...
036da6d
2020-09-07 14:32:28 -05:00
fd657c7706
Merge pull request #6798
...
4e44306
2020-09-07 14:30:41 -05:00
fc2cb224a9
blockchain: fix pow skipping for old blocks without precalc hash
2020-09-07 01:57:19 +00:00
5498142e8f
rpc: assume randomx from v13 onwards
2020-09-07 01:13:06 +00:00
aefa7740c3
Merge pull request #6111
...
d20ff4f646a0b3b1f89d42649d5
2020-09-06 15:49:37 +02:00
036da6d45b
Let stagenet hardfork happen before mainnet.
2020-09-04 22:47:05 +01:00
4e4430603f
enable CLSAG support for Trezor client
2020-09-04 01:24:58 +02:00
9fb2243db0
Merge pull request #6794
...
b09cc3d
2020-09-03 12:27:18 -05:00
ee0b02d0db
Merge pull request #6757
...
6a37da8
2020-09-03 12:25:59 -05:00
b09cc3d03d
hardforks: add v13/v14 for testnet
2020-09-02 17:56:48 +00:00
de9a9fb340
update error message "No unlocked balance in the specified account"
2020-09-01 17:30:00 -04:00
6a37da837e
threadpool: guard against exceptions in jobs, and armour plating
...
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
2020-09-01 14:33:33 +00:00
2d8a197b91
Merge pull request #6789
...
bdcf587
2020-08-31 16:58:13 -05:00
94b056c06e
Merge pull request #6786
...
975ae22333ae550a3c5a6
2020-08-31 16:54:51 -05:00
a51ccc036f
Merge pull request #6770
...
bdc6b10
2020-08-31 16:50:18 -05:00
bdcf587c79
net: fix get_tcp_endpoint, boost address_v4 ip in host byte order
2020-08-29 18:07:46 +00:00
fa06c39d97
Bind signature to full address and signing mode
2020-08-28 19:38:00 -04:00
743608ec16
wallet: allow signing a message with spend or view key
2020-08-28 19:25:17 -04:00
e6c81c5ea7
ringct: fix CLSAG serialization after boost/epee changes
...
also fix a an assert message refering t MLSAG
2020-08-28 11:52:54 +00:00
975ae22211
Fix send scalar z in plaintext
...
The scalar z has not been generated on the HW thus it can't be sent
encrypted. The value is derived from the exported private view key.
2020-08-28 12:01:57 +02:00
333ae55fef
Update minimal Ledger Monero app version
2020-08-28 12:00:25 +02:00
0a3c5a605b
Update protocol version with Ledger's HW
2020-08-28 11:59:02 +02:00
d20ff4f648
functional_tests: add a large (many randomx epochs) p2p reorg test
2020-08-27 15:13:04 +00:00
6a0b3b1f8a
functional_tests: add randomx tests
2020-08-27 15:13:03 +00:00
9d42649d58
core: fix mining from a block that's not the current top
2020-08-27 15:13:00 +00:00
1660fe8a25
draft support of clsag
2020-08-27 12:44:18 +00:00
703944c4d4
CLSAG device support
2020-08-27 12:44:04 +00:00
641b08c920
CLSAG optimizations
2020-08-27 12:44:04 +00:00
82ee01699c
Integrate CLSAGs into monero
...
They are allowed from v12, and MLSAGs are rejected from v13.
2020-08-27 12:44:04 +00:00
4b328c6616
CLSAG signatures
2020-08-27 12:43:29 +00:00
0c101f1236
Merge pull request #6767
...
07442a605
2020-08-27 03:07:32 -07:00
27b49033fd
Merge pull request #6763
...
728ba38b1
2020-08-27 03:02:30 -07:00
b04da25e4d
Merge pull request #6760
...
844fb4e94
2020-08-27 03:01:28 -07:00
4fe2858b4d
Merge pull request #6746
...
20f603c6b
2020-08-27 02:58:53 -07:00
dd7fd2ef80
Merge pull request #6753
...
4ff2074c7
2020-08-27 02:58:45 -07:00
a06c83db73
Merge pull request #6752
...
85899230de916201f1
2020-08-27 02:58:23 -07:00
42519b48a7
Merge pull request #6731
...
db5d6e460
2020-08-27 02:55:48 -07:00
bad5d8d6f0
Merge pull request #6690
...
7175dcb10
2020-08-27 02:54:30 -07:00
38914fe6fa
Merge pull request #6613
...
55363c594
2020-08-27 02:52:59 -07:00
a6f1fa0194
Merge pull request #6607
...
eb1b321fe
2020-08-26 12:53:09 -07:00
844fb4e940
enforce claiming maximum coinbase amount
...
Claiming a slightly lesser amount does not yield the size gains
that were seen pre rct, so this closes a fingerprinting vector
2020-08-21 12:36:53 +00:00
bdc6b10d62
Fix ZMQ pruned bulletproof transactions
2020-08-19 00:36:06 -04:00
765db1ae7a
Revert "Use domain-separated ChaCha20 for in-memory key encryption"
...
This reverts commit 921dd8dde5
2020-08-17 14:08:59 -05:00
7175dcb107
replace most boost serialization with existing monero serialization
...
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.
For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.
Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.
Some tests and tools also do, this will stay as is for now.
2020-08-17 16:23:58 +00:00
55363c5941
Avoid some temporary strings when reading off the database
2020-08-17 14:02:27 +00:00
43f5369bec
Merge pull request #6733
...
4f01cf4b4429d49512d745d2433
2020-08-16 12:56:03 -07:00
d73b1b6560
Merge pull request #6727
...
13eee1d6a92e6b7df26dd95d53090016ad74
2020-08-16 12:55:25 -07:00
569d07d60b
Merge pull request #6722
...
c1b03fb1a
2020-08-16 12:54:42 -07:00
01b512f3a9
Merge pull request #6716
...
76c16822d
2020-08-16 12:52:21 -07:00
f40b9e34e0
Merge pull request #6715
...
3d6bc0a68
2020-08-16 12:51:57 -07:00
43f91ee12e
Merge pull request #6703
...
8baa7bb23
2020-08-16 12:50:43 -07:00
0b0da2aa81
Merge pull request #6689
...
afd002c31ec7bba079
2020-08-16 12:47:36 -07:00
236256f114
Merge pull request #6679
...
2f1ad3b3d
2020-08-16 12:46:51 -07:00
eba2189925
Merge pull request #6677
...
f9e3fcdf3
2020-08-16 12:46:27 -07:00
bc48494731
Merge pull request #6661
...
267ce5b71
2020-08-16 12:45:37 -07:00
8f02e7a7fc
Merge pull request #6632
...
ef694d028
2020-08-16 12:44:59 -07:00
c6c4ead44e
Merge pull request #6614
...
fb31167b1
2020-08-16 12:44:03 -07:00
a08df6eb1b
Merge pull request #6603
...
4e2377995
2020-08-16 12:43:38 -07:00
009ca6fcd3
Merge pull request #6601
...
98c151ecb60627c9f2fe96e66eb
2020-08-16 12:43:11 -07:00
0f5eb0e70c
Merge pull request #6546
...
eda167585
2020-08-16 12:40:51 -07:00
461651fce5
Merge pull request #6542
...
35665df20
2020-08-16 12:40:37 -07:00
6d29ee6c52
Merge pull request #6493
...
921dd8dde
2020-08-16 12:39:59 -07:00
e2e09d00c2
Merge pull request #6337
...
a11ec4ac1
2020-08-16 12:38:44 -07:00
13549d590e
Merge pull request #6329
...
6bfcd3101
2020-08-16 12:37:43 -07:00
728ba38b11
rpc: always send raw txes through P2P (don't use bootstrap daemon)
...
It turns out that some remote (bootstrap) nodes silently drop /
don't broadcast client's transactions.
2020-08-16 17:34:28 +00:00
07442a6059
Fix build with Boost 1.74
...
Thanks iDunk for testing
2020-08-16 16:23:26 +00:00
4e2377995d
Change ZMQ-JSON txextra to hex and remove unnecessary base fields
2020-08-14 23:01:00 +00:00
98c151ecb8
Optimize ZMQ-JSON vector reading; GetBlocksFast reads 24%+ faster
2020-08-14 19:47:19 +00:00
60627c9f24
Switch to insitu parsing for ZMQ-JSON; GetBlocksFast reads 13%+ faster
2020-08-14 19:46:59 +00:00
fe96e66ebe
Fix pruned tx for ZMQ's GetBlocksFast
2020-08-14 19:46:33 +00:00
85899230d1
simplewallet: allow setting tx keys when sending to a subaddress
...
The tx key derivation is different then
2020-08-10 21:25:51 +00:00
4ff2074c74
cryptonote_protocol: don't synced pruned blocks before v11
...
There are a few Borromean proofs txes in the v8 era, and these
aren't supported by get_pruned_transaction_weight. Moreover, only
only the most recent variant of bulletproofs is currently supported.
2020-08-10 16:17:39 +00:00
921dd8dde5
Use domain-separated ChaCha20 for in-memory key encryption
2020-08-09 19:11:54 -04:00
6bfcd31015
Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests.
2020-08-09 18:42:15 -04:00
c108c5e2f0
Merge pull request #6354
...
67ade8005
2020-08-09 06:42:49 -07:00
e916201f12
wallet2: fix setting tx keys when another is already set
...
insert doesn't actually insert if another element with the
same key is already in the map
2020-08-08 14:40:03 +00:00
20f603c6be
Fix broken multisig pubkey sorting
...
The sort predicate is a boolean ordered-before value, but these are
returning the memcmp value directly, and thus returns true whenever the
pubkeys aren't equal. This means:
- it isn't actually sorting.
- it can (and does) segfault for some inputs.
2020-08-05 12:42:27 -03:00
9414194b1e
Merge pull request #6571
...
1d31e6c00
2020-08-05 07:57:54 -07:00
4f01cf4b46
Tweak format, add option for difficulty
...
Set input, output, ringsize averages to 2 decimal places precision
Add option to show min/max/av per-block difficulty
2020-08-03 13:13:14 +01:00
429d495121
Add options to print daily coin emission and fees
...
Closes #6735
2020-08-01 20:48:42 +01:00
d745d24333
Don't forget size of prunable txn part
...
Fixes #6732
2020-08-01 13:41:38 +01:00
db5d6e4602
wallet2: fix wrong name when checking RPC cost
2020-07-31 14:17:23 +00:00
13eee1d6ab
rpc: reject wrong sized txid
...
Reporter requested credit to be given to Decred
2020-07-30 22:52:14 +00:00
90016ad744
blockchain: guard against exceptions in add_new_block/children
...
Reporter requested credit to be given to Decred
2020-07-30 22:52:11 +00:00
c1b03fb1a6
rpc: return empty txid get_outs rather than 00..00 when not requested
...
It's more obvious there's no txid, and it saves space
2020-07-25 17:01:21 +00:00
8baa7bb238
daemon: don't print "(pruned)" for coinbase txes
...
Pruned coinbase txes are the same as unpruned ones, so the
prunable data is empty
2020-07-24 13:42:20 +00:00
fb31167b12
Wallet, daemon: From 'help_advanced' back to 'help', and new 'apropos' command
2020-07-24 07:12:11 +02:00
76c16822d0
wallet2_api: implement runtime proxy configuration
2020-07-20 13:45:12 +00:00
3d6bc0a680
wallet2: throw a error on wallet initialization failure
2020-07-20 04:40:34 +00:00
2a82258dff
Merge pull request #6580
...
ed901798d
2020-07-19 03:42:43 -07:00
3434cc24a2
Merge pull request #6578
...
a6803231e
2020-07-19 03:41:55 -07:00
9871fefbf9
Merge pull request #6565
...
72cdfa4a2
2020-07-19 03:40:19 -07:00
c0a6e1aab9
Merge pull request #6557
...
bd69e3b37
2020-07-19 03:39:53 -07:00
bb0241da6e
Merge pull request #6538
...
7178bb5c8
2020-07-19 03:38:53 -07:00
61e5208181
Merge pull request #6537
...
5e0ea6e95
2020-07-19 03:38:07 -07:00
6d6c691a0f
Merge pull request #6536
...
bd9653663
2020-07-19 03:37:15 -07:00
36d50d93f2
Merge pull request #6534
...
7bd66b01b
2020-07-19 03:36:39 -07:00
814e617117
Merge pull request #6526
...
5d882f4f1
2020-07-19 03:34:52 -07:00
3ba6c7fd30
Merge pull request #6516
...
8656a8c9f
2020-07-19 03:34:28 -07:00
a0d179e528
Merge pull request #6512
...
5ef0607da
2020-07-19 03:32:59 -07:00
5041de8a3b
Merge pull request #6488
...
99684e3e
2020-07-16 06:14:30 -07:00
332d60719a
tx_pool: mine stem txes in fake chain mode
...
This fixes the functional tests, since txes would not be mined
after being sent to the daemon (they'd be waiting for the
dandelion timeout first)
2020-07-09 14:52:13 +00:00
0fd6ccef21
blockchain: fix timestamp/difficulty cache getting out of sync
...
The cache is discarded when a block is popped, but then gets
rebuilt when the difficulty for next block is requested.
While this is all properly locked, it does not take into account
the delay caused by a database transaction being only committed
(and thus its effects made visible to other threads) later on,
which means another thread could request difficulty between
the pop and the commit, which would end up using stale database
view to build the cache, but that cache would not be invalidated
again when the transaction gets committed, which would cause the
cache to not match the new database data.
To fix this, we now keep track of when the cache is invalidated
so we can invalidate it again upon database transaction commit
to ensure it gets calculated again with fresh data next time it
is nedeed.
2020-07-08 22:31:51 +00:00
99b14ccd6a
Merge pull request #6647
...
4d8d121
2020-07-08 17:25:01 -05:00
18bb011afe
Merge pull request #6629
...
795e186
2020-07-08 17:23:28 -05:00
e8d87fccc2
Merge pull request #6627
...
4df8f9c
2020-07-08 17:22:33 -05:00
0376195015
Merge pull request #6611
...
dc1a053
2020-07-08 17:21:31 -05:00
3057f52f89
Merge pull request #6599
...
6e4a55b9b86e14
2020-07-08 17:20:29 -05:00
Alexander Blair
xiphon
moneromooo-monero
Howard Chu
Lee Clagett
luigi1111
Alexis Enston
Michal m@lbit Malicki
dsc
Tadeas Moravec
TheCharlatan
selsta
Reinaldulin
Riccardo Spagni
Norman Moeschter
Dusan Klinec
woodser
Sarang Noether
François Colas
cslashm
cohcho
Jason Rhinelander
rbrunner7