97f5a130d6
Merge pull request #4028
...
2a19697b
2018-07-03 15:19:24 +02:00
e451c76181
Merge pull request #4005
...
b85acb4c
2018-07-03 15:18:05 +02:00
27ca6ca594
Merge pull request #4004
...
bc443494
2018-07-03 15:16:37 +02:00
58cceaad71
wallet2: fix double counting outs if the tx pubkey is duplicated
2018-07-03 14:16:30 +01:00
a4272de797
wallet2: unlock keys file before calling verify_password (needed for Windows)
...
Also added notes to WalletManager::verifyWalletPassword (which afaik seems unused
by anyone at the moment) regarding the need to unlock the keys file beforehand.
2018-07-03 18:07:20 +09:00
d6d78f157b
Allow fractional outputs to be ignored
2018-07-03 18:04:31 +09:00
8c4db68ff7
node_rpc_proxy: factor a few RPC calls using get_info
...
Takes advantage of caching
2018-07-02 17:59:44 +01:00
438d52deaf
remove epee from link lines where it's redundant
...
For some reason, this confuses and kills ASAN on startup
as it thinks const uint8_t ipv4_network_address::ID is
defined multiple times.
2018-06-28 16:45:22 +01:00
a9b83f5a6e
Merge pull request #4067
...
9a39b7d
2018-06-27 21:28:34 -05:00
29254fc06e
api/wallet: add missing arg to wallet2::refresh()
2018-06-28 10:24:05 +09:00
ba0a7294d0
Merge pull request #4000
...
4510f41
2018-06-27 20:18:41 -05:00
4c6de54ee2
Merge pull request #3994
...
1d1764759de6f83d623a8
2018-06-27 20:17:25 -05:00
4510f417f9
Wallet API: add some missing override keyword
...
Also remove dust() from UnsignedTransactionImpl (already in PendingTransactionImpl)
2018-06-28 09:59:09 +09:00
3d623a86d1
wallet: prevent the same wallet file from being opened by multiple processes
2018-06-28 09:41:43 +09:00
9a39b7dd7f
wallet2: fix build for windows (std::max again)
2018-06-28 00:47:48 +01:00
9b38551c3c
wallet_rpc_server: fix build - forgot to build rpc version
2018-06-27 23:34:02 +01:00
2329d2f4c8
Merge pull request #3907
...
dcbc17e
2018-06-27 16:32:33 -05:00
8a27caeb22
Merge pull request #3998
...
8db23df
2018-06-27 16:30:38 -05:00
9453573581
Merge pull request #3995
...
0a5292c
2018-06-27 16:28:57 -05:00
c28a2b0d7d
Merge pull request #3992
...
25c15dc
2018-06-27 16:26:23 -05:00
5eb2e01216
Merge pull request #3991
...
798dfcf
2018-06-27 16:25:03 -05:00
3ad4ecd4ff
Merge pull request #3982
...
08b85a80cf80ba
2018-06-27 15:38:23 -05:00
dcbc17e97e
wallet: include a suggested number of confirmations based on amount
...
This is based on how much an attacking miner stands to lose in block
rewardy by mining a private chain which double spends a payment.
This is not foolproof, since mining is based on luck, and breaks
down as the attacking miner nears 50% of the network hash rate,
and the estimation is based on a constant block reward.
2018-06-27 21:38:21 +01:00
a844844cda
Merge pull request #3716
...
a2b557f6795bd0209ec96ed2c81ea830db257ea90231a895eba8331cf7f191741be339f025ae9ef2cb63dcfd2995d3e70227046242771a180e4c7d0
2018-06-27 15:33:01 -05:00
0e4c7d0fae
wallet2: cache ringdb key while refreshing
...
Speeds up syncing with a lot of outgoing outputs as key generation
runs Cryptonight.
2018-06-26 22:15:38 +01:00
2771a18e85
threadpool: allow leaf functions to run concurrently
...
Decrease the number of worker threads by one to account
for the fact the calling thread acts as a worker thread now
2018-06-26 22:15:22 +01:00
2704624eae
wallet2: remove unneeded divisions
2018-06-26 22:15:20 +01:00
5d3e70229e
wallet2: remove old blockchain size cache hack
2018-06-26 22:15:18 +01:00
dcfd299239
wallet2: speedup refresh
...
key derivation and checking for incoming outputs are threaded
in batch before adding blocks to the local blockchain. Other
minor bits and bobs are also cached.
2018-06-26 22:15:16 +01:00
f025ae9760
wallet2: avoid re-parsing blocks when refreshing in a loop
2018-06-26 22:15:12 +01:00
41be339655
wallet2: avoid duplicate parsing of tx extra
2018-06-26 22:15:10 +01:00
f7f1917ed4
wallet2: remove useless device locking
2018-06-26 22:14:35 +01:00
ba8331ce41
wallet2: parse blocks in the RPC thread, not the processing thread
...
Processing typically is the bottleneck
2018-06-26 22:14:33 +01:00
31a895e876
wallet2: simplify/speedup process_blocks
2018-06-26 22:14:31 +01:00
57ea90285c
wallet: don't process miner tx if we're refreshing with no-coinbase
2018-06-26 22:14:26 +01:00
ed2c81ed95
replace std::list with std::vector on some hot paths
...
also use reserve where appropriate
2018-06-26 22:14:21 +01:00
6795bd0d4e
rpc: add option to skip coinbase info in get_blocks.bin
2018-06-26 22:14:16 +01:00
a2b557fe5c
wallet2: use std::move on containers where appropriate
2018-06-26 22:14:14 +01:00
506be80601
Merge pull request #3955
...
d7a6b72
2018-06-25 15:09:48 -05:00
26562e9f3c
Merge pull request #3941
...
bf26920
2018-06-25 14:54:54 -05:00
df9d50a8a4
wallet2: fix read buffer overflow in import_key_images
2018-06-23 09:22:20 +01:00
3e46db97e5
rpc: add a non binary get_transaction_pool_hashes RPC
2018-06-21 09:02:42 +01:00
46e90b7780
Wallet API: add support for wallet creation from hardware device
2018-06-21 12:36:27 +09:00
8fc0cdb96f
wallet2: lower default for subaddress lookahead when restoring with hardware
2018-06-21 12:35:23 +09:00
66df13a58b
wallet-rpc.getaddress: throw if index is out of bound
2018-06-21 10:49:03 +09:00
9a3712541e
Merge pull request #3939
...
62c8c07
2018-06-20 14:52:55 -05:00
51cdd76bbd
Merge pull request #3897
...
63d0ab0
2018-06-20 14:19:30 -05:00
2a19697bd4
wallet2: fix double header in unsigned transfer file
2018-06-19 22:30:02 +01:00
896512b2b6
Merge pull request #3878
...
5a412b7
2018-06-19 12:57:59 -05:00
d841339b09
Merge pull request #3829
...
4764929
2018-06-19 12:43:10 -05:00
9226acca4b
Merge pull request #3804
...
89e51ec
2018-06-16 14:15:52 -05:00
4e7897e57c
Merge pull request #3780
...
9c2a7b4
2018-06-16 14:12:57 -05:00
e3012444fb
Merge pull request #3762
...
eb9f3a3
2018-06-16 14:10:11 -05:00
7af0b7fffc
Merge pull request #3735
...
4812c06
2018-06-16 14:07:25 -05:00
b85acb4cb8
Fix RPC crashes that didn't check for an open wallet
2018-06-15 20:18:41 +01:00
bc443494f3
wallet2: fix out of sync account tag cache
...
This would cause crashes when trying to tag an account that was
just created
2018-06-15 20:18:12 +01:00
8db23df581
wallet: on first refresh, start off with a quantized height
...
for privacy reasons, so an untrusted node can't easily track
wallets from IP address to IP address, etc. The granularity
is 1024 blocks, which is about a day and a half.
2018-06-13 22:44:27 +01:00
63d0ab09b5
mlog: --max-log-files to set the max number of rotated log files
2018-06-13 12:44:27 +09:00
798dfcfe79
wallet: allow unspendable unmixable outputs to be discarded
2018-06-13 11:56:40 +09:00
0a5292c339
wallet2: use decoded amount when reporting repeated output key
2018-06-13 01:06:44 +09:00
25c15dca5c
wallet2: use correct fee for split txes
2018-06-12 12:06:51 +09:00
08b85a8e00
cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X
2018-06-11 20:17:02 +09:00
6884db7b31
Merge pull request #3599
...
8787fd8
2018-06-08 14:45:46 -05:00
00635bd68b
Merge pull request #3598
...
b21bc00
2018-06-08 14:40:06 -05:00
1af890287b
Merge pull request #3890
...
f80b157
2018-06-07 12:12:28 -05:00
d7a6b72c15
wallet2: fix bulletproof cold signing
...
Cold signing was always using Borromean range proofs, causing
a larger tx, and an incorrect fee
2018-06-07 12:29:30 +01:00
bf26920f27
wallet2: fix get_approximate_blockchain_height for stagenet
2018-06-06 20:33:01 +09:00
62c8c07c47
wallet: do not log by default if we're not asked to log to console
...
This means monero-wallet-rpc still does, but the user level program
does not.
2018-06-06 10:15:13 +01:00
4764929ecb
use deterministic viewkey if not supplied
2018-06-05 19:32:03 -04:00
9c2a7b4638
wallet-rpc: watch-only and cold wallet features added
...
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs
Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx
- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
2018-06-03 13:21:00 +02:00
503d2693fd
Merge pull request #3640
...
f36132a
2018-05-31 14:44:54 -05:00
3ee6a1b706
Merge pull request #3635
...
c1bda09
2018-05-31 14:43:18 -05:00
b6eb7484d1
Merge pull request #3592
...
90a16b16a61f52
2018-05-31 14:41:17 -05:00
3a373c3d3a
Merge pull request #3489
...
47fdb7447fdb74
2018-05-31 14:34:34 -05:00
f80b1571c6
wallet2: don't ask for pruned txes yet, we still parse the entire tx
2018-05-31 16:46:58 +01:00
0da5d37bf3
wallet: fix shared ring db path
2018-05-31 08:16:45 +09:00
5b189ce2a8
Merge pull request #3405
...
80d2f80
2018-05-29 12:52:43 -05:00
5a412b7a3f
disable file size sanity check when loading the wallet cache
2018-05-28 14:58:22 +01:00
709658d166
Merge pull request #3832
...
cb9c7972
2018-05-21 20:57:52 +02:00
d6cefbd1b8
Merge pull request #3745
...
b13bddc3
2018-05-21 20:56:20 +02:00
cb9c7972b6
Fix output shuffling for multisig
2018-05-20 09:38:41 +09:00
89e51ecd38
simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet
2018-05-15 15:28:42 +10:00
a58d9738c9
wallet2: consider 6 outputs or less to be unmixable from v7
2018-05-10 21:19:33 +01:00
eb9f3a3294
check_spend_proof
...
My intention is to mitigate #3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: https://github.com/monero-integrations/monerophp/issues/72 & my temp fix: https://github.com/monero-integrations/monerophp/pull/74
2018-05-06 17:42:27 +01:00
4812c062c5
add .load() to make Boost 1.67 happy with its new is_integral check
2018-05-05 21:44:28 +02:00
b13bddc3c9
Wallet API: allow log path to be non-default & console output to be configurable
2018-05-04 10:21:25 +09:00
93e76e14a2
Merge pull request #3685
...
ffeeefde2dae0f20
2018-04-28 16:56:22 +02:00
35299644b2
Merge pull request #3650
...
5bd7f760
2018-04-28 16:54:37 +02:00
b21bc00704
Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api)
2018-04-25 17:55:54 +03:00
2dae0f203a
wallet2: add missing parameters to get_output_histogram
2018-04-23 10:54:25 +01:00
f36132a837
wallet cli/rpc: terminate execution with code 0 when --help or --version is given
2018-04-22 11:48:44 +09:00
5bd7f760e9
import_multisig_info: fix sanity check crash in detach_blockchain
2018-04-21 23:25:01 +03:00
a3a617f35f
Merge pull request #3576
...
f82c10dc
2018-04-21 21:58:10 +02:00
03ff3be10e
Merge pull request #3672
...
875c1cab70f232178c7363fb
2018-04-21 21:54:08 +02:00
875c1cabb9
wallet2: increase rpc timeout for get_output_distribution
2018-04-19 16:06:26 +01:00
70f2321763
add top height to get_output_distribution, and cache it for rct
...
This should cache the vast majority of calls for long running wallets
2018-04-19 16:06:22 +01:00
c1bda097c1
wallet_rpc_server: add a get_version RPC
2018-04-14 13:34:05 +01:00
8787fd899b
WalletApi: publicMultisigSignerKey method
2018-04-13 13:15:20 +03:00
b5d6c723e9
wallet2: store subaddress lookahead settings
2018-04-12 22:23:53 +09:00
94b899db26
Use 'boost' mutex instead of 'std' mutex
2018-04-12 13:58:57 +02:00
2c274e05fe
Fix sub-address tx scan.
...
When additional keys was needed, the TX scan failed because the
derivation data was always recomputed with the main tx_key and not
the corresponding additional one.
Moreover this patch avoid perf decreasing when not using HW device.
2018-04-12 13:58:57 +02:00
5e08fd89ea
Merge pull request #3549
...
73951cbd25fe67e4
2018-04-12 13:49:33 +02:00
14c870ee5f
Merge pull request #3615
...
24acb66e
2018-04-12 13:47:54 +02:00
3b8704b0fa
Merge pull request #3555
...
0b26c4d5
2018-04-12 13:47:39 +02:00
5d8439e310
Merge pull request #3534
...
eecfb57d
2018-04-12 13:47:20 +02:00
8703f1d80e
Merge pull request #3516
...
1e0958c0
2018-04-12 13:46:18 +02:00
24acb66eac
wallet2: fix misc issues when the ringdb can't be initialized
2018-04-12 11:07:07 +01:00
5053f8f40b
Merge pull request #3502
...
11c933e1
2018-04-12 11:14:43 +02:00
96b2fee721
Merge pull request #3536
...
c77d2bfa100b7bc1641dfc99
2018-04-12 11:12:33 +02:00
1b4dc46129
Merge pull request #3473
...
eaa8bfe70a619f78
2018-04-12 11:05:31 +02:00
ebb55f797b
Merge pull request #3468
...
0098ed33
2018-04-12 11:00:47 +02:00
6a61f520e2
unit_tests: add ringdb unit tests
2018-04-11 11:43:39 +01:00
73951cbd39
wallet2: request transactions in slices when scanning for known rings
...
This avoid massive memory consumption for huge wallets
2018-04-07 08:31:46 +01:00
25fe67e4cf
rpc: allow getting pruned blocks from gettransactions
...
and get them pruned in find_and_save_rings, since it does not need
the pruned data in the first place.
Also set decode_to_json to false where missing, we don't need this
either.
2018-04-07 08:29:11 +01:00
f82c10dc96
WalletManagerImpl: reuse existing connection to daemon instead of reconnectivng every time
2018-04-07 14:06:29 +09:00
0b26c4d57c
wallet2: move segregation height to v7
...
since people seem to really want to use things the wrong way.
2018-04-05 12:49:38 +01:00
c77d2bfaa0
Add the possibility to export private view key for fast scan.
...
On client startup the device asks for authorization to export the private view key.
If user agree, the client hold the private view key allowing a fast blockchain scan.
If the user does not agree, the blockchain scan is fully done via the device.
2018-03-31 18:00:33 +02:00
eecfb57df9
wallet: warn if not using the default ring size
2018-03-31 15:47:02 +01:00
1e0958c083
wallet: fix default mixin (4 -> 6)
2018-03-28 09:30:11 -07:00
5a96056600
WalletApi: getMultisigInfo entry for gui wallets
...
WalletApi: makeMultisig call introduced
WalletApi: finalizeMultisig call introduced
WalletApi: new calls exportMultisigImages and importMultisigImages
WalletApi: method to return multisig wallet creation state
WalletApi: create multisig transaction, sign multisig transaction, commit transaction and get multisig data are added
WalletApi: identation and style fixes
2018-03-28 18:22:13 +03:00
47fdb74273
Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings
...
WalletApi: added method statusWithErrorString to atomically retrieve error with error string
2018-03-28 16:11:16 +03:00
11c933e137
fix lambda compile error on openbsd
2018-03-27 14:48:36 +01:00
eaa8bfe7c0
wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly
...
The previous expression
req_t.from_height = X ? Y >= Z : 0;
forces the parameter to take the value of either 0 or 1.
2018-03-22 20:02:25 +09:00
0a619f789b
wallet2: enable the mitigation only after the fork height
2018-03-22 20:02:14 +09:00
0098ed338c
wallet2: fix for loading settings of key reuse mitigation
2018-03-22 12:10:46 +09:00
5730049178
wallet: catch exceptions dealing with ringdb and warn
2018-03-21 14:29:49 +00:00
1e393f4bb7
wallet: make the segregation height settable
...
via user setting first, then DNS TXT record, hardcoded fallback
2018-03-17 14:56:31 +00:00
5cd36e48bf
Merge pull request #3421
...
9732a37e
2018-03-17 16:52:46 +02:00
9732a37e9a
wallet_rpc_server: add sweep_unmixable as alias for sweep_dust
2018-03-17 11:22:58 +00:00
b86f1e5dad
Add command line option allowing to restrict the default sub-address lookahead in order to avoid
...
so looooong time of set-up when creating a HW based wallet.
2018-03-16 18:00:28 +01:00
0f27fc57ac
Merge pull request #3336
...
57c0b1ed
2018-03-16 18:08:07 +02:00
eac3a11ed3
wallet: more user friendly print_ring
...
It can now take a txid (to display rings for all its inputs),
and will print rings in a format that set_ring understands
2018-03-16 12:07:45 +00:00
798535149d
wallet2_api: add key reuse mitigations API
2018-03-16 12:07:42 +00:00
b057a21d56
wallet2_api: add ring api
2018-03-16 10:33:05 +00:00
d32ef7b0f2
ringdb: factor ring addition code
2018-03-16 10:33:02 +00:00
a7da8208f5
wallet2_api: add blackball api
2018-03-16 10:32:59 +00:00
504428ab4a
ringdb: use the genesis block as a db name
...
This will avoid careless forkers polluting the shared database
even if they make their own chain. They'll then automatically
start using another subdb, and any key-reusing fork of those
forks will reuse their subdbs.
2018-03-16 10:32:54 +00:00
b09e5181cc
wallet: add a set_ring command
...
This is so one can set rings for spent key images in case the
attackers don't merge the ring matching patch set.
2018-03-16 10:32:51 +00:00
db10dd6d83
wallet: make ringdb an object with database state
2018-03-16 10:32:42 +00:00
d29ea0455a
wallet: add an output blackball list to avoid using those in rings
2018-03-16 10:32:37 +00:00
18eaf19489
wallet: key reuse mitigation options
...
If a pre-fork output is spent on both Monero and attack chain,
any post-fork output can be deduced to be a fake output, thereby
decreasing the effective ring size.
The segregate-per-fork-outputs option, on by default, allows
selecting only pre-fork outputs in this case, so that the same
ring can be used when spending it on the other side, which does
not decrease the effective ring size.
This is intended to be SET when intending to spend Monero on the
attack fork, and to be UNSET if not intending to spend Monero
on the attack fork (since it leaks the fact that the output being
spent is pre-fork).
If the user is not certain yet whether they will spend pre-fork
outputs on a key reusing fork, the key-reuse-mitigation2 option
should be SET instead.
If you use this option and intend to spend Monero on both forks,
then spend real Monero first.
2018-03-16 10:32:34 +00:00
5f146873c5
wallet: add shared ring database
...
This maps key images to rings, so that different forks can reuse
the rings by key image. This avoids revealing the real inputs like
would happen if two forks spent the same outputs with different
rings. This database is meant to be shared with all Monero forks
which don't bother making a new chain, putting users' privacy at
risk in the process. It is placed in a shared data directory by
default ($HOME/.shared-ringdb on UNIX like systems). You may
use --shared-ringdb-dir to override this location, and should
then do so for all Monero forks for them to share the database.
2018-03-16 10:32:29 +00:00
41f727ce42
add RPC to get a histogram of outputs of a given amount
2018-03-16 10:32:26 +00:00
57c0b1ed9f
Fix typos in various files
2018-03-15 18:25:38 +02:00
a7266d6d7b
wallet2+cli+rpc: eliminate redundant m_http_client from cli/rpc and delegate calls to wallet2
2018-03-15 22:01:51 +09:00
80d2f8007c
wallet2: Update function parameter documentation
...
This completes and fixes various parameters docs
2018-03-14 16:41:24 +01:00
71d186566e
replace invoke_http_json("/json_rpc",...) with invoke_http_json_rpc("/json_rpc",methodname,...) to reduce boilerplate
2018-03-14 23:23:59 +09:00
a69c713f8e
Merge pull request #3398
...
c577abab
2018-03-14 16:18:15 +02:00
2fe1504c03
Merge pull request #3399
...
1d39b265
2018-03-14 16:17:59 +02:00
8b90e3141a
Merge pull request #3386
...
9abeff59
2018-03-14 16:10:00 +02:00
7a44301675
Merge pull request #3385
...
ec41006c
2018-03-14 16:09:40 +02:00
4405e4fc73
wallet2: check_tx_key() shouldn't require hardware encryption
2018-03-14 21:00:18 +09:00
27a196b126
device: untangle cyclic depenency
...
When #3303 was merged, a cyclic dependency chain was generated:
libdevice <- libcncrypto <- libringct <- libdevice
This was because libdevice needs access to a set of basic crypto operations
implemented in libringct such as scalarmultBase(), while libringct also needs
access to abstracted crypto operations implemented in libdevice such as
ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct
into libringct_basic and libringct, where the basic crypto ops previously in
libringct are moved into libringct_basic. The cyclic dependency is now resolved
thanks to this separation:
libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct
This eliminates the need for crypto_device.cpp and rctOps_device.cpp.
Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and
get_subaddress_secret_key() were previously implemented in libcryptonote_basic
(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,
which is odd because libdevice is supposed to be independent of libcryptonote_basic.
Therefore, those functions were moved to device_default.cpp.
2018-03-14 21:00:15 +09:00
c9b38b4765
device: made function prototypes consistent with pre-#3303 codebase
2018-03-14 21:00:06 +09:00
f2e8e8d23c
Merge pull request #3377
...
aa8bef0c
2018-03-14 13:38:50 +02:00
3bc2537f5a
Merge pull request #3369
...
1979d53d
2018-03-14 13:37:14 +02:00
0f2d6d40b4
Merge pull request #3360
...
1ff35fda
2018-03-14 13:37:00 +02:00
117cf12509
Merge pull request #3355
...
0bbd521f
2018-03-14 13:36:36 +02:00
33158f089d
Merge pull request #3354
...
ffe70b8f
2018-03-14 13:36:25 +02:00
2dfb4f098e
Merge pull request #3353
...
73dd883d
2018-03-14 13:36:14 +02:00
cfc5a3d4d4
Merge pull request #3345
...
e0cda74a
2018-03-14 13:35:53 +02:00
67978b78ce
Merge pull request #3337
...
91d97dd45f85cc7e
2018-03-14 13:35:41 +02:00
3fed788603
Merge pull request #3315
...
649a1b7a
2018-03-14 13:35:11 +02:00
5f85cc7e3d
wallet2: guard against overflowing of subaddress indices
2018-03-14 11:34:06 +00:00
1d39b26556
wallet2: fix use_fork_rules() when querying version that is defined but not enabled yet
2018-03-14 19:02:21 +09:00
c577abab61
wallet: fix auto low priority so that it takes effect only when saved default is 0
2018-03-14 18:33:43 +09:00
73dd883d51
Ledger HW Bug fixes
...
Fix the way the REAL mode is handle:
Let create_transactions_2 and create_transactions_from construct the vector of transactions.
Then iterate on it and resign.
We just need to add 'outs' list in the TX struct for that.
Fix default secret keys value when DEBUG_HWDEVICE mode is off
The magic value (00...00 for view key and FF..FF for spend key) was not correctly set
when DEBUG_HWDEVICE was off. Both was set to 00...00.
Add sub-address info in ABP map in order to correctly display destination sub-address on device
Fix DEBUG_HWDEVICE mode:
- Fix compilation errors.
- Fix control device init in ledger device.
- Add more log.
Fix sub addr control
Fix debug Info
2018-03-12 10:43:06 +01:00
9abeff5911
wallet2: handle no blocks returned in refresh to mean no new blocks
...
This is not a possible return from the daemon, but I want this in
now so all wallets handle this when the daemon starts doing so.
2018-03-11 21:16:15 +00:00
ec41006cad
node_rpc_proxy: fix target height caching
2018-03-11 13:11:49 +00:00
649a1b7ae6
wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets
...
Previously, a file containing the unencrypted Monero address was
created by default in the wallet's directory. This file might pose
as a privacy risk. The creation of this file is now opt-in and can
be enabled by providing
--create-address-file
2018-03-10 16:28:23 +01:00
aa8bef0cb3
fix error message typo in wallet2.cpp
2018-03-09 17:22:26 -05:00
e9f41e405f
Merge pull request #3368
...
38657fd0
2018-03-08 18:47:41 +02:00
3a12f2588a
Merge pull request #3365
...
55a65f32
2018-03-08 18:44:18 +02:00
60c8544e77
Merge pull request #3347
...
9a6be3da
2018-03-08 18:42:24 +02:00
1979d53d78
wallet: fixes and tweaks to the save_watch_only command
...
- save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly
- catch any exception (eg, I/O errors) and error out
- print the new keys filename in simplewallet
2018-03-07 14:24:14 +00:00
38657fd0e9
Bump min ring size from 5 to 7 from v7
2018-03-07 13:19:04 +00:00
55a65f3269
Wallet API: corrected testnet/mainnet ordering
2018-03-07 13:56:17 +09:00
1ff35fda7c
Wallet API: make nettype non-defaulted to disambiguate from deprecated versions (and make libwallet_api_tests compilable)
2018-03-06 21:14:52 +09:00
0bbd521fa2
libwallet_merged: added missing libdevice
2018-03-06 02:36:37 +09:00
ffe70b8f61
Make mixin optional with default for rpc transfer
2018-03-05 12:27:22 -05:00
237f0179b7
Merge pull request #3313
...
43026822
2018-03-05 19:15:54 +02:00
baf640887d
Merge pull request #3343
...
3d452367
2018-03-05 19:14:03 +02:00
5b25cbb5a7
Merge pull request #3314
...
71bff546
2018-03-05 19:12:24 +02:00
4f93f74528
Merge pull request #3277
...
0e7ad2e2af773211cc9a0bee55f8d917450306a0#3318 (stoffu)
9f9e095a#3261 (Jean Pierre Dudey)
2018-03-05 19:11:20 +02:00
033ead4bad
Merge pull request #3273
...
f3b74e75
2018-03-05 19:11:07 +02:00
fbcc91c2a4
Correct spelling mistakes.
2018-03-05 17:00:40 +00:00
3d452367b0
allow using ring size instead of mixin for rpc transfer
2018-03-05 10:10:35 -05:00
0e7ad2e2c9
Wallet API: generalize 'bool testnet' to 'NetworkType nettype'
2018-03-05 23:59:16 +09:00
9a6be3da25
wallet_manager: fixed typo deviuce/device.hpp
2018-03-05 11:57:30 +09:00
af773211cb
Stagenet
2018-03-05 11:55:05 +09:00
e0cda74ace
wallet2_api: add info/error/warning entry points
2018-03-04 18:07:30 +00:00
e745c1e38d
Code modifications to integrate Ledger HW device into monero-wallet-cli.
...
The basic approach it to delegate all sensitive data (master key, secret
ephemeral key, key derivation, ....) and related operations to the device.
As device has low memory, it does not keep itself the values
(except for view/spend keys) but once computed there are encrypted (with AES
are equivalent) and return back to monero-wallet-cli. When they need to be
manipulated by the device, they are decrypted on receive.
Moreover, using the client for storing the value in encrypted form limits
the modification in the client code. Those values are transfered from one
C-structure to another one as previously.
The code modification has been done with the wishes to be open to any
other hardware wallet. To achieve that a C++ class hw::Device has been
introduced. Two initial implementations are provided: the "default", which
remaps all calls to initial Monero code, and the "Ledger", which delegates
all calls to Ledger device.
2018-03-04 12:54:53 +01:00
71bff546d3
wallet api: when restoring from EnglishOld, set language to English
2018-02-25 22:04:36 +09:00
430268224d
Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows
2018-02-25 12:57:58 +01:00
2ac3da1251
Merge pull request #3256
...
df5273de
2018-02-20 17:53:38 +02:00
cfa3af4078
Merge pull request #3247
...
89ad162af2c4c399
2018-02-20 17:46:40 +02:00
6920fdaf4f
Merge pull request #3246
...
3c33e1310133b348
2018-02-20 17:46:29 +02:00
0fc5eec9cd
Merge pull request #3235
...
6866ed46
2018-02-20 17:46:00 +02:00
89ad162a3f
wallet2: remove unused m_subaddresses_inv
2018-02-16 17:13:09 +00:00
f2c4c39971
wallet2: speed up subaddress generation (by about a third)
2018-02-16 17:13:06 +00:00
Riccardo Spagni
moneromooo-monero
stoffu
luigi1111
Howard Chu
cryptochangements34
Dusan Klinec
jcktm
itssteven
Teutone
naughtyfox
Mikhail Mitkevichl
cslashm
sneurlax
Dimitris Apostolou
Leon Klingele
cryptochangements34
Edward Betts
rbrunner7