ff5626d785
ringct: handle exceptions verifying bulletproofs in worker threads
2018-01-15 11:48:23 +00:00
6fbb0b065d
cmake: set API header install path to what Qt wallet expects
2018-01-14 20:14:07 -05:00
6cf56682bc
perf_timer: add faster x86_64 timers, and pause/resume
2018-01-15 00:35:55 +00:00
411da337d2
perf_timer: use std::unique_ptr instead of new/delete
2018-01-15 00:35:24 +00:00
c4f437796d
crypto: add a ge_p3_identity constant
2018-01-15 00:30:46 +00:00
13b4c90e01
crypto: add scalar mult functions returning ge_p3 instead of ge_p2
...
ge_scalarmult_p3
ge_double_scalarmult_precomp_vartime2_p3
ge_double_scalarmult_base_vartime_p3
This makes it possible to reuse the result without having to
convert back to unsigned char[32] and back to ge types.
2018-01-15 00:30:26 +00:00
269ba25228
wallet2::import_blockchain fix import loop
2018-01-14 20:30:35 +01:00
fb5c971cc6
Allow retrieving spend key via RPC
2018-01-14 06:23:12 +01:00
be1826c0fb
Keep readline optional
2018-01-11 13:51:13 -05:00
b56f46457c
cryptonote_protocol: fix size_t used in wire format
...
This is 32 bits on 32 bit platforms, but 64 bits on 64 bit platforms.
2018-01-11 17:31:47 +00:00
6d40a92026
Reserve proof
2018-01-10 20:37:18 +09:00
deeffaeb5c
blockchain: remove minor floating point usage
2018-01-10 11:05:30 +00:00
e61f655440
Merge pull request #3061
...
fc041b58
2018-01-10 11:55:35 +01:00
00f4ff26c8
Merge pull request #3021
...
dc6729a6
2018-01-10 11:55:19 +01:00
4e3716a2d2
Merge pull request #3005
...
369884a6
2018-01-10 11:54:38 +01:00
0b5994fbec
Merge pull request #3004
...
a2c845c7
2018-01-10 11:54:23 +01:00
990389f09d
Merge pull request #3002
...
9996d5e9eadaa6aa
2018-01-10 11:54:11 +01:00
229e1ce7d1
Merge pull request #2997
...
7c4f01a7
2018-01-10 11:53:57 +01:00
d08aee7a7e
Merge pull request #2993
...
776b44f1
2018-01-10 11:53:26 +01:00
f9c66ba67c
Merge pull request #2990
...
2d17feb0
2018-01-10 11:53:05 +01:00
6c7eb5109d
Merge pull request #2989
...
66eeeaa1
2018-01-10 11:52:49 +01:00
529ca39e9d
Merge pull request #2988
...
8a4610c3
2018-01-10 11:52:32 +01:00
ab8a32429a
Merge pull request #2985
...
6d8b29effdd4c5e540ab12a7
2018-01-10 11:50:58 +01:00
3ce7f2bead
Merge pull request #2983
...
6fc4fc85
2018-01-10 11:50:36 +01:00
a71db6d239
Merge pull request #2981
...
b63afbaa
2018-01-10 11:50:21 +01:00
bfe580787d
Merge pull request #2976
...
c765f951
2018-01-10 11:49:14 +01:00
420a803ff8
Merge pull request #2973
...
277a5aef
2018-01-10 11:48:42 +01:00
c951bf1f72
Merge pull request #2972
...
586ee642
2018-01-10 11:48:12 +01:00
0a110aefbb
Merge pull request #2971
...
ae860230
2018-01-10 11:45:15 +01:00
6d8b29ef28
fix some link errors in debug mode for macos
2018-01-10 01:57:56 +00:00
fdd4c5e577
move memwipe to epee to avoid common<->crypto circular dependencies
2018-01-10 01:57:54 +00:00
40ab12a773
epee: remove dependency on common
2018-01-10 01:57:51 +00:00
d188840cc2
Improved terminology from create to generate
2018-01-09 21:46:44 +01:00
5f5a51a6c8
util: warn if unbound was not built with threads
...
This can causes crashes in libunbound
2018-01-08 10:58:50 +00:00
fa5c0bab44
Implement #3045 , fixing RPC snakecases
2018-01-06 15:11:36 -06:00
0811b9242b
fix some confirmation dialog, add missing symbols
...
Change some confirmation dialog to look like other ones (add symbol ":" and space)
So, it will look like: (Y/Yes/N/No): y
Now it look: (Y/Yes/N/No)y
2018-01-06 22:04:04 +07:00
9ffa97fe98
Factor the monero donation address
...
Signed-off-by: Maxithi <34792056+Maxithi@users.noreply.github.com>
2018-01-05 12:58:40 +01:00
301ec15c49
Change cryptonote::COMMAND_RPC_SET_LIMIT::response to use int64_t
2018-01-04 21:01:10 -06:00
d507167fa5
Removed unused mac-specific output folder path
2018-01-04 21:16:44 +01:00
3e635a3cef
wallet2: allow failing parse_tx_extra
...
It can fail if it fails to parse extra, while still having filled
the returned data with partial contents
2018-01-04 15:38:49 +00:00
fc041b58d6
common cmake: make sure translation_files.h is generated for i18n.cpp
2018-01-04 12:24:06 +09:00
a529f0a6c9
Merge pull request #3019
...
294adc83d52b732e
2018-01-02 00:32:12 +02:00
aa4195e199
Merge pull request #2977
...
c70e8daa
2018-01-02 00:31:56 +02:00
803f54b9fd
Merge pull request #2967
...
55556fab
2018-01-02 00:31:30 +02:00
ee02c7ab03
Merge pull request #2962
...
14c29814
2018-01-02 00:30:01 +02:00
eb617be8f4
Merge pull request #2960
...
5cbcf0aa
2018-01-02 00:29:36 +02:00
dd11bfb89c
Merge pull request #2934
...
db2bc965
2018-01-02 00:28:45 +02:00
69f9a07553
cryptonote_protocol: fix missing space in version mismatch message
2017-12-31 17:32:57 +00:00
776b44f17b
Add misc hardening flags to the cmake machinery
...
See https://wiki.debian.org/Hardening#User_Space
2017-12-31 14:26:12 +00:00
eb39a3d7d3
wallet_api: make this optional but not built by default
...
It means it can still be built with make -C build/debug wallet_api
but still not DoS us while debugging
2017-12-31 11:14:20 +00:00
a4b006f965
wallet2 bugfix: initialize subaddress table when generating from keys
2017-12-29 15:53:28 +09:00
294adc8341
Additional fix for core_tests
...
Reset thread-local info if it doesn't match the current env.
Only happens when a process opens/closes env multiple times in the
same process, doesn't affect monerod.
2017-12-28 20:24:08 +00:00
dc6729a66a
wallet2: std::unordered_set ctor is sometimes explicit
2017-12-28 10:20:12 +00:00
a1a8262355
Merge pull request #2949
...
e20e489a
2017-12-28 09:00:00 +02:00
3bbe2481ce
Merge pull request #2946
...
1a686bf8
2017-12-28 08:59:31 +02:00
95a687d584
Merge pull request #2945
...
9e07ccf1
2017-12-28 08:59:16 +02:00
0ae3651cc9
Merge pull request #2942
...
4f45f9da
2017-12-28 08:58:46 +02:00
5f562cf9e6
Merge pull request #2941
...
d0d38dc8
2017-12-28 08:58:30 +02:00
8980aacbe8
Merge pull request #2940
...
da0fd71d81b04cfa
2017-12-28 08:57:59 +02:00
03ac389022
zmq: use older 3-arg version of setsockopt
2017-12-28 13:15:49 +09:00
d52b732efb
Fix stale readcursor flags
...
Reset thread-specific flags when a write txn is started.
Also remove some redundant start-readtxn code.
2017-12-28 00:59:04 +00:00
b63afbaa99
simplewallet: detect typo for incoming_transfers options
2017-12-28 07:53:31 +09:00
6fc4fc850e
sweep_below: do not prematurely exclude subaddresses set
2017-12-28 07:52:53 +09:00
f06603a439
cryptonote_protocol: update target height when receiving blocks
2017-12-27 13:54:19 +00:00
fe436eca46
apply_permutation.h: add #pragma once
2017-12-27 12:15:51 +00:00
619bb7233b
daemon+simplewallet: given an unknown command, show it
2017-12-27 15:23:34 +09:00
07da9c806d
Resolve addresses in get_transfers
2017-12-27 01:35:48 +01:00
50786ac70c
simplewallet: Correct 3 multisig command usage help texts, e.g. for 'export_multisig_info'
2017-12-26 14:57:08 +01:00
da0fd71d3e
only include the easylogging++ stack trace code when needed
2017-12-26 11:40:15 +00:00
e3530789d3
wallet-api: added Utils::onStartup
2017-12-26 08:23:32 +09:00
40df4905fd
Merge pull request #3006
...
7e7b1a82
2017-12-25 22:08:56 +02:00
7e7b1a8252
Revert "return subaddress in get_bulk_payments"
...
This reverts commit b60f48f0e3
2017-12-25 20:04:40 +00:00
ca8c7e863f
Merge pull request #2895
...
5ad312a11e5491e9
2017-12-25 22:00:44 +02:00
0a5bfa7c73
Merge pull request #2938
...
aaae94f0
2017-12-25 21:42:22 +02:00
5ad312a1c3
wallet2: switch to chacha20 instead of chacha8
...
Wallet caches and keys files are loaded with chacha8 as needed,
but only saved with chacha20. Other data (eg, cold wallet data
files, etc) will be incompatible.
2017-12-25 19:28:06 +00:00
1e5491e942
Add a chacha20 variant to go with chacha8
2017-12-25 19:28:03 +00:00
409e9bb029
Merge pull request #2931
...
04349492
2017-12-25 21:21:00 +02:00
b38f6dcf0b
Merge pull request #2929
...
ae55bacdfe0fae50
2017-12-25 21:20:22 +02:00
c611cca462
Merge pull request #2928
...
d28c388f
2017-12-25 21:19:58 +02:00
db09247c68
Merge pull request #2926
...
6b5bd129
2017-12-25 21:19:33 +02:00
32c14e0f37
Merge pull request #2922
...
a1d44f27472a93c8
2017-12-25 21:18:29 +02:00
2b00899bb2
Merge pull request #2920
...
bd5cce07e0a6129924f584d9b1634aa38e60b81c213e326cb51dc566f0568ca6b49ddc762305bf26a4240d9f45a1c4c056fa6ce1b4524892c2ed8618187a6ab2061789b5ba2fefb938c8f4e0d753d716fe568db846d6fa3525584f86490a5d41
2017-12-25 21:17:52 +02:00
170f598ac9
Merge pull request #2918
...
f5bc7f18
2017-12-25 21:17:32 +02:00
8b40bc27a2
Merge pull request #2916
...
a9217641
2017-12-25 21:17:16 +02:00
d06f3ea9ad
Merge pull request #2902
...
1741fb5f
2017-12-25 21:16:01 +02:00
b3dddb22fe
Merge pull request #2899
...
b60f48f0
2017-12-25 21:15:08 +02:00
2ef299f2a9
Merge pull request #2891
...
3f24e901
2017-12-25 21:14:20 +02:00
2f09828ea8
Merge pull request #2890
...
83b0f9e6493f7d09
2017-12-25 21:13:59 +02:00
2d1965f31b
Merge pull request #2888
...
ca18ff646afcd8e3
2017-12-25 21:13:33 +02:00
369884a669
mnemonics: typo fix (4 bytes == 3 words, not 8 bytes)
2017-12-25 19:57:38 +09:00
a2c845c7e3
cryptonote_protocol: internal error consistency size check
2017-12-24 13:04:40 +00:00
9996d5e96c
wallet2: guard against the dameon sending blocks before last checkpoint
2017-12-24 12:12:40 +00:00
eadaa6aaa3
wallet_rpc_server: fix wallet leak on error exit
...
Makes it easier to debug leaks
2017-12-24 12:12:37 +00:00
7c4f01a792
blockchain_import: more informative verification switch
2017-12-23 18:47:05 +00:00
2018cf74a6
Fix Windows build
...
Fix no new line
2017-12-23 15:27:30 +01:00
c70e8daa91
threadpool: fix deadlock in recursive waiter usage
...
If a queued job uses a waiter, then we want to run that waiter's
jobs in the current thread if all threads are busy, even if the
queue is empty, since there is no guarantee that any thread will
free up to take care of that new job, since all the threads might
be running a job which spawns such a recursive job and will block
till that recursive job is done, which it will never be since it
relies on the queue being polled by one of those blocked threads.
2017-12-23 09:00:43 +00:00
2d17feb060
factor STL container serialization
2017-12-22 19:47:12 +00:00
8a4610c315
blake256: fix wrong hash when computed in parts
...
This does not happen when used by the monero code
2017-12-22 12:08:02 +00:00
66eeeaa1a2
wallet2: fix failure to create tx if inputs are not enough for fee
2017-12-21 22:11:16 +00:00
c765f9512c
simplewallet: disable donations on testnet
2017-12-20 17:12:22 +00:00
277a5aefaa
wallet2: fix m_key_image_{partial,known} in_light_wallet code
2017-12-20 14:54:14 +00:00
586ee64209
simplewallet: lock idle scope in {im,ex}port_{key_images,outputs}
...
This ensures we can't get races
2017-12-20 14:21:50 +00:00
ae8602303a
Fix exceptions not finding txpool txes when relaying
2017-12-20 13:02:53 +00:00
5cbcf0aa25
wallet: support for multisig seeds
...
They are hex rather than words, because they are a lot longer
than "normal" seeds, as they have to embed a lot more information
2017-12-20 10:22:29 +00:00
55556fabf9
wallet_rpc_server: factor transfer info return and add missing info
...
Additional tx keys, amounts and fees were missing in some cases
2017-12-20 08:56:31 +00:00
14c2981469
wallet2: fix use of uninitialized data
2017-12-19 12:33:01 +00:00
4f45f9da40
simplewallet: factor out tx exceptions
2017-12-18 15:56:36 +00:00
24f584d90d
cryptonote_core: remove unused functions with off by one bugs
2017-12-18 15:16:06 +00:00
b1634aa3e8
blockchain: don't leave dangling pointers in this
2017-12-18 15:16:03 +00:00
8e60b81c48
cryptonote_core: fix db leak on error
2017-12-18 15:16:00 +00:00
b51dc56687
use const refs in for loops for non tiny types
2017-12-18 15:15:54 +00:00
b49ddc766d
check accessing an element past the end of a container
2017-12-18 15:15:49 +00:00
2305bf260d
check return value for generate_key_derivation and derive_public_key
2017-12-18 15:15:46 +00:00
a4240d9ffc
catch const exceptions
2017-12-18 15:15:43 +00:00
45a1c4c088
add empty container sanity checks when using front() and back()
2017-12-18 15:15:40 +00:00
b4524892fb
rpc: guard against json parsing a non object
2017-12-18 15:15:32 +00:00
061789b5dd
checkpoints: trap failure to load JSON checkpoints
2017-12-18 15:15:23 +00:00
ba2fefb9a4
checkpoints: pass std::string by const ref, not const value
2017-12-18 15:15:19 +00:00
d753d716a6
fix a few leaks by throwing objects, not newed pointers to objects
2017-12-18 15:15:13 +00:00
fe568db83d
p2p: use size_t for arbitrary counters instead of uint8_t
2017-12-18 15:15:10 +00:00
46d6fa35c9
cryptonote_protocol: sanity check chain hashes from peer
2017-12-18 15:15:07 +00:00
25584f8639
cryptonote_protocol: print peer versions when unexpected
...
also avoid integer underflow on zero height
2017-12-18 15:15:05 +00:00
490a5d41ca
rpc: do not try to use an invalid txid in relay_tx
2017-12-18 15:15:01 +00:00
a921764162
wallet-rpc: added receiving address to res of get(_bulk)_payments; selective addresses for getaddress
2017-12-18 10:22:34 +09:00
6b5bd129b4
Account tagging
2017-12-18 10:21:47 +09:00
1cc7451130
Merge pull request #2134
...
ceabc4f955c2845d98db7ee431a97e762fa707d1e36f5b60a36c261dfa569712dffa0dce7f4c220b2652903866e34e85f4eda44ccd64c799fff871a495a21a79b84b35654c3133246d219a92
2017-12-17 21:05:16 +02:00
d9b137f161
cryptonote_core: fix blockchain init call after prototype change
2017-12-17 18:47:46 +00:00
e20e489a64
Better definite article use
2017-12-17 12:33:43 -05:00
ceabc4f92b
change the N-1/N multisig second message signer for auth
2017-12-17 16:12:50 +00:00
98db7ee467
wallet: factor multisig info parsing
2017-12-17 16:12:44 +00:00
31a97e761e
wallet: use raw encrypted data in multisig import/export RPC
2017-12-17 16:12:41 +00:00
2fa707d1a5
wallet: add multisig sign/submit RPC
2017-12-17 16:12:35 +00:00
e36f5b6021
Match surae's recommendation to derive multisig keys
2017-12-17 16:12:32 +00:00
a36c261d7a
wallet2: fix slow multisig unit tests with subaddress patch
...
While there, move the wallet2 ctor to the cpp file as it's a huge
amount of init list now, and remove an unused one.
2017-12-17 16:12:30 +00:00
fa5697127f
make multisig work with subaddresses
...
Thanks to kenshi84 for help getting this work
2017-12-17 16:12:27 +00:00
dffa0dceaf
simplewallet: add export_raw_multisig command
...
It exports raw transactions, so they may be used by other tools,
for instance to be relayed to the network externally.
2017-12-17 16:12:24 +00:00
7f4c220b70
simplewallet: add multisig to wallet type in wallet_info output
2017-12-17 16:12:21 +00:00
265290388b
wallet: guard against partly initialized multisig wallet
2017-12-17 16:12:18 +00:00
66e34e85b1
add multisig core test and factor multisig building blocks
2017-12-17 16:12:15 +00:00
f4eda44ce3
N-1/N multisig
2017-12-17 16:12:12 +00:00
cd64c7990c
multisig address generation RPC
2017-12-17 16:12:09 +00:00
fff871a455
gen_multisig: generates multisig wallets if participants trust each other
2017-12-17 16:12:06 +00:00
95a21a793d
wallet2: allow empty wallet filename to avoid saving data
...
Useful to speed tests up and avoid unnecessary leftover files
2017-12-17 16:12:03 +00:00
4c313324b1
Add N/N multisig tx generation and signing
...
Scheme by luigi1111:
Multisig for RingCT on Monero
2 of 2
User A (coordinator):
Spendkey b,B
Viewkey a,A (shared)
User B:
Spendkey c,C
Viewkey a,A (shared)
Public Address: C+B, A
Both have their own watch only wallet via C+B, a
A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants)
A and B watch for incoming outputs
B creates "half" key images for discovered output D:
I2_D = (Hs(aR)+c) * Hp(D)
B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D),
and sending the pubkeys with I2_D.
A also creates "half" key images:
I1_D = (Hs(aR)+b) * Hp(D)
Then I_D = I1_D + I2_D
Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction).
A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D
to his own generated ones where they are needed (secret row L, R).
At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r,
which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo).
B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well).
B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D
to his cache, allowing him to verify spent status as well.
NOTE:
A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively.
Otherwise, trickery like the following becomes possible:
A creates viewkey a,A, spendkey b,B, and sends a,A,B to B.
B creates a fake key C = zG - B. B sends C back to A.
The combined spendkey C+B then equals zG, allowing B to spend funds at any time!
The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature).
2 of 3
User A (coordinator)
Shared viewkey a,A
"spendkey" j,J
User B
"spendkey" k,K
User C
"spendkey" m,M
A collects K and M from B and C
B collects J and M from A and C
C collects J and K from A and B
A computes N = nG, n = Hs(jK)
A computes O = oG, o = Hs(jM)
B anc C compute P = pG, p = Hs(kM) || Hs(mK)
B and C can also compute N and O respectively if they wish to be able to coordinate
Address: N+O+P, A
The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other
needed part of the signature/key images from either of the other two.
Alternatively, if secure communication exists between parties:
A gives j to B
B gives k to C
C gives m to A
Address: J+K+M, A
3 of 3
Identical to 2 of 2, except the coordinator must collect the key images from both of the others.
The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it
or send it back to A.
N-1 of N
Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around
(using either the secure or insecure method).
For example (ignoring viewkey so letters line up):
[4 of 5]
User: spendkey
A: a
B: b
C: c
D: d
E: e
a -> B, b -> C, c -> D, d -> E, e -> A
Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with
the transaction so the signers know if they should use 1 or both keys.
Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each.
Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning:
1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image)
2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator
must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use.
You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might
also be straightforward enough to support with minimal changes from N-1 format.
You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc.
The process is somewhat cumbersome:
To create a N/N multisig wallet:
- each participant creates a normal wallet
- each participant runs "prepare_multisig", and sends the resulting string to every other participant
- each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N)
As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent:
- each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant
- each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants
Then, a transaction may be initiated:
- one of the participants runs "transfer ADDRESS AMOUNT"
- this partly signed transaction will be written to the "multisig_monero_tx" file
- the initiator sends this file to another participant
- that other participant runs "sign_multisig multisig_monero_tx"
- the resulting transaction is written to the "multisig_monero_tx" file again
- if the threshold was not reached, the file must be sent to another participant, until enough have signed
- the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network
2017-12-17 16:11:57 +00:00
6d219a9250
wallet: add multisig key generation
...
Scheme by luigi1111
2017-12-17 16:11:53 +00:00
1a686bf8cc
daemon: print num txes in print_bc
2017-12-17 12:55:40 +00:00
a3a8343051
Merge pull request #2857
...
7193b89f
2017-12-17 13:00:11 +02:00
066fd7aced
Merge pull request #2877
...
43f5269fbb89ae8b4abf25f3
2017-12-17 12:59:44 +02:00
9e07ccf1f5
daemon: remove some superfluous includes
2017-12-17 10:28:39 +00:00
43f5269f84
Wallets now do not depend on the daemon rpc lib
...
The shared RPC code is now moved off into a separate lib
2017-12-16 23:28:59 +00:00
bb89ae8b20
move connection_basic and network_throttle from src/p2p to epee
...
These even had the epee namespace.
This fixes some ugly circular dependencies.
2017-12-16 23:28:43 +00:00
4abf25f3c9
cryptonote_core does not depend on p2p anymore
...
As a followon side effect, this makes a lot of inline code
included only in particular cpp files (and instanciated
when necessary.
2017-12-16 23:28:38 +00:00
09ce03d612
move includes around to lessen overall load
2017-12-16 22:46:38 +00:00
7193b89fe5
Scrub keys from memory just before scope end.
...
Partially implements #74 .
Securely erases keys from memory after they are no longer needed. Might have a
performance impact, which I haven't measured (perf measurements aren't
generally reliable on laptops).
Thanks to @stoffu for the suggestion to specialize the pod_to_hex/hex_to_pod
functions. Using overloads + SFINAE instead generalizes it so other types can
be marked as scrubbed without adding more boilerplate.
2017-12-16 15:40:33 -07:00
8da24c2a57
Merge pull request #2878
...
abebe3927696e849
2017-12-16 23:27:00 +02:00
b88f0879b5
Merge pull request #2873
...
1c8385523f18c642
2017-12-16 23:25:43 +02:00
7998ffc26b
Merge pull request #2871
...
2b0a32f8
2017-12-16 23:25:02 +02:00
9b511d3e93
Merge pull request #2866
...
cf5f6236
2017-12-16 23:24:41 +02:00
87158dca68
Merge pull request #2885
...
a1e3670b
2017-12-16 23:24:16 +02:00
6c0953b15a
Merge pull request #2860
...
3dffe71b7a2a574154950829000666ff
2017-12-16 23:19:27 +02:00
ce951ef560
Merge pull request #2856
...
009eed17
2017-12-16 23:15:43 +02:00
9045ff56fc
Merge pull request #2551
...
3af19c80
2017-12-16 23:12:44 +02:00
d0d38dc8e6
wallet2: print tx size in bytes and kB
...
Helpful now that tx sizes are smaller
2017-12-16 18:40:21 +00:00
aaae94f00b
wallet2: reinstate the single preferred output selection
...
Removing it nullified the min-outputs-{count,value} system,
and will not increase the number of attempted transactions
in the general case.
2017-12-16 12:31:03 +00:00
db2bc96512
Embed the translation files in the binary
...
If a translation file exists in a "translations" directory located in
the same directory as the binary, it is used in priority (this can be
useful when working on translations as you don't have to recompile the
whole program all the time), and if no such file is found the embedded
translation file is used (if it exists).
2017-12-15 18:44:01 +01:00
043494924b
wallet2: error out in get_seed if the language is invalid
2017-12-15 11:01:14 +00:00
ae55bacd8c
resumption support for updates using range requests
2017-12-15 10:46:23 +00:00
d28c388f88
p2p: stop net server before closing starting connections
...
This fixes a hang on exit due to race where a connection adds
itself to the server after the starting connections are closed,
but before the net server marks itself as stopped.
2017-12-15 10:31:12 +00:00
a1d44f2746
updates: use https for updates
2017-12-14 13:33:06 +00:00
472a93c83a
download: SSL suport
2017-12-14 09:12:58 +00:00
f5bc7f1855
simplewallet: fix default unspent_outputs output with subaddresses
...
If no subaddress index is given, consider all of them
2017-12-13 10:09:42 +00:00
319163d276
Merge pull request #2913
...
b927f0b1
2017-12-12 17:48:29 +02:00
46eaaae79b
ringct: always use outPk.mask to decode amounts
2017-12-09 18:02:55 +00:00
2b5abb8269
Merge pull request #2903
...
8d4469a0
2017-12-09 19:05:56 +02:00
8d4469a0ac
ringct: do not include bulletproof commitments in signed message
...
Those are not serialized, but are restored from the outPk masks,
so depending on what tries to validate the tx, those commitments
may or may not be filled with valid data at the time. The outPk
masks are already hashed as part of the rctSigBase field.
2017-12-09 15:30:15 +00:00
1741fb5f2b
node_rpc_proxy: remove unused local and time call
2017-12-09 11:28:18 +00:00
ead48f7d92
core: fix input ordering from v7
2017-12-09 11:24:38 +00:00
b60f48f0e3
return subaddress in get_bulk_payments
2017-12-08 18:45:53 +03:00
c83d0b3ee2
add bulletproofs from v7 on testnet
2017-12-08 13:50:45 +00:00
8620ef0a0d
bulletproofs: switch H/G in Pedersen commitments to match rct
...
Changes from sarang
2017-12-08 13:48:18 +00:00
d58835b2f6
integrate bulletproofs into monero
2017-12-08 13:48:15 +00:00
90b8d9f271
add bulletproofs to the build, with basic unit tests
...
Based on Java code from Sarang Noether
2017-12-08 13:41:13 +00:00
fe1202646c
perf_timer: add non scoped start/stop timer defines
2017-12-07 19:23:14 +00:00
ada4291469
add a version of ge_double_scalarmult_precomp_vartime with A precomp
2017-12-07 19:23:10 +00:00
d43eef6def
ringct: add a version of addKeys which returns the result
2017-12-07 19:23:08 +00:00
7ff07928ad
sc_mul and sc_muladd
2017-12-07 19:23:05 +00:00
3f24e90149
wallet2: don't write a .new file when not needed
2017-12-07 12:07:18 +00:00
83b0f9e6c5
version: add -master to master version
...
This makes master versions play better with automated update checks
2017-12-07 10:33:12 +00:00
493f7d0974
util: allow non numeric version parts
2017-12-07 10:32:48 +00:00
3af19c8011
set_node command, allows setting node without restart
2017-12-06 18:16:50 +01:00
ca18ff644b
wallet2: detect spends in txes without a valid public tx key
2017-12-06 15:55:06 +00:00
6afcd8e37d
cn_deserialize: print tx extra fields in partly decoded tx extra
2017-12-06 15:54:17 +00:00
a1e3670b33
catch wallet decrypt false positive
2017-12-04 11:07:32 +02:00
b927f0b17e
cryptonote_protocol: fix corner case looping asking for same block hashes
2017-12-03 13:05:10 +00:00
3052dab81d
Merge pull request #2836
...
23b6f685
2017-12-02 09:26:15 +02:00
81fb832082
Merge pull request #2833
...
b0426d4cFixes #759 Add sanity check on restore height (Cifrado)
2017-12-02 09:25:53 +02:00
63f0031965
Merge pull request #2853
...
c0ae52c0
2017-12-02 09:24:53 +02:00
301279709d
Merge pull request #2850
...
d875a9ff
2017-12-02 09:24:25 +02:00
57ac2c2642
Merge pull request #2840
...
f9fad186
2017-12-02 09:23:36 +02:00
ed8fc8ac1c
Merge pull request #2838
...
310b790a
2017-12-02 09:23:22 +02:00
1fec38e736
Merge pull request #2832
...
287dde63
2017-12-02 09:22:43 +02:00
0bf4d6deea
Merge pull request #2828
...
6cbe7bcd
2017-12-02 09:21:55 +02:00
abebe392c7
rpc: add offline state in info rpc
2017-11-30 15:44:01 +00:00
7696e84952
core: make --offline also disable DNS lookups
2017-11-30 15:35:52 +00:00
cf5f623616
Corrections in rate limiting / trottle code, especially in 'out' direction
...
Deleted 3 out of 4 calls to method connection_basic::sleep_before_packet
that were erroneous / superfluous, which enabled the elimination of a
"fudge" factor of 2.1 in connection_basic::set_rate_up_limit;
also ended the multiplying of limit values and numbers of bytes
transferred by 1024 before handing them over to the global throttle
objects
2017-11-28 21:18:01 +01:00
1c838552ed
Simplewallet.cpp: Fewer pleases in seed NOTE
...
Monero.ts: Fewer pleases in seed NOTE
Monero_it.ts: Fewer pleases in seed NOTE
Monero_fr.ts: Fewer pleases in seed NOTE
2017-11-28 11:41:26 -05:00
3f18c642fc
Fix password capitalization mismatch
2017-11-28 11:15:50 -05:00
3dffe71b72
new wipeable_string class to replace std::string passphrases
2017-11-27 22:25:57 +00:00
7a2a574118
utils: initialize easylogging++ in on_startup
...
It will be reinitialized later once we know about log file
and other command line configuration
2017-11-27 22:15:40 +00:00
549508296d
use memwipe in a few relevant places
2017-11-27 22:15:37 +00:00
000666ff78
add a memwipe function
...
It's meant to avoid being optimized out
memory_cleanse lifted from bitcoin
2017-11-27 22:15:34 +00:00
2b0a32f8af
Small cleanup of daemon synchronization output
...
Add period to second sentence
2017-11-27 16:37:20 -05:00
51e7645836
Merge pull request #2839
...
0b08bf39
2017-11-27 22:43:01 +02:00
287dde63d8
Added command descriptions
2017-11-26 10:37:37 +01:00
8a8c918dc3
Merge pull request #2827
...
fdf0acbf
2017-11-25 19:54:14 +02:00
ac261d0d87
Merge pull request #2825
...
ac5cd865
2017-11-25 19:53:58 +02:00
2e54e7ff0b
Merge pull request #2824
...
51895fd7
2017-11-25 19:53:35 +02:00
4c90d638bc
Merge pull request #2823
...
0d149f70
2017-11-25 19:53:12 +02:00
a7211b5a07
Merge pull request #2822
...
93c33985
2017-11-25 19:52:52 +02:00
fbfdaae06f
Merge pull request #2807
...
61712384
2017-11-25 19:51:52 +02:00
82375f7de7
Merge pull request #2806
...
da706b61
2017-11-25 19:51:28 +02:00
df032aac69
Merge pull request #2800
...
0b726be79d505d26
2017-11-25 19:50:58 +02:00
1de386111f
Merge pull request #2797
...
7e387fb1
2017-11-25 19:50:21 +02:00
eefd6a7878
Merge pull request #2796
...
b42ee213
2017-11-25 19:49:48 +02:00
7dc58410e5
Merge pull request #2784
...
54a4c1cb
2017-11-25 19:49:22 +02:00
539f511eb1
Merge pull request #2368
...
b0b7e0f0
2017-11-25 19:48:56 +02:00
ed2fc4a1ff
Merge pull request #2794
...
43f27c7d
2017-11-25 19:48:33 +02:00
29b0bb8952
Merge pull request #2792
...
47c0948afdb5bd16
2017-11-25 19:47:49 +02:00
d80a3e5c38
Merge pull request #2788
...
9739da1e01dc829783fa9047
2017-11-25 19:47:05 +02:00
5eb825b876
Merge pull request #2785
...
2d1ccc1b
2017-11-25 19:46:52 +02:00
9739da1e84
wallet_rpc_server: new relay_tx command
...
It takes a full tx+metadata hex string as input
2017-11-24 14:03:55 +00:00
01dc829784
wallet: transfer RPC can now return tx metadata (pending_tx)
2017-11-24 14:03:52 +00:00
83fa9047d8
serialization: add std::set and std::unordered_set serialization
2017-11-24 13:45:48 +00:00
009eed17f1
rpc: increase the max number of outs one can request
...
It's getting hit too easily
2017-11-23 19:15:45 +00:00
c0ae52c081
simplewallet: prevent (wrong) integrated adresses on accounts > 0
2017-11-22 16:20:11 +00:00
54a4c1cbf7
cryptonote: do not overwrite const data
2017-11-22 11:17:22 +00:00
d875a9ff90
wallet2: detect multiple outputs from a tx to different subaddresses
2017-11-21 23:22:15 +00:00
b0b7e0f09a
Spend proof without txkey
2017-11-21 16:49:16 +09:00
be1c01298a
fix for tx proof: use exception instead of error_str when signature gen failed
2017-11-21 16:48:22 +09:00
49ce59462a
Merge pull request #2783
...
416a7933
2017-11-20 12:09:02 +09:00
8d9e4920fc
Merge pull request #2768
...
ef941855
2017-11-20 12:08:31 +09:00
0b08bf3968
fixed common/util.cpp to link against libressl
2017-11-18 19:02:09 +01:00
998777ecd7
Tx proof (revised):
...
- refactoring: proof generation/checking code was moved from simplewallet.cpp to wallet2.cpp
- allow an arbitrary message to be signed together with txid
- introduce two types (outbound & inbound) of tx proofs; with the same syntax, inbound is selected when <address> belongs to this wallet, outbound otherwise. see GitHub thread for more discussion
- wallet RPC: added get_tx_key, check_tx_key, get_tx_proof, check_tx_proof
- wallet API: moved WalletManagerImpl::checkPayment to Wallet::checkTxKey, added Wallet::getTxProof/checkTxProof
- get_tx_key/check_tx_key: handle additional tx keys by concatenating them into a single string
2017-11-18 20:44:27 +09:00
310b790a64
make connection_id a string in RPC
...
It's sent as JSON, so raw binary is not appropriate
2017-11-18 00:13:07 +00:00
23b6f685de
RPC: allow binding of restricted port in addition to core port
2017-11-17 16:23:41 -05:00
b0426d4cf2
Fixes #759 Add sanity check on restore height
2017-11-17 08:35:59 +01:00
51895fd7df
split wallet and wallet_api
...
This speeds up building a lot when wallet2.h (or something it
includes) changes, since all the API includes wallet2.h
2017-11-16 12:10:29 +00:00
6cbe7bcdd2
wallet2: check generate_key_derivation return value
2017-11-16 10:31:47 +00:00
6171238416
daemon & simplewallet: don't set max-concurrency when unspecified
2017-11-16 08:03:25 +09:00
fdf0acbf97
Tools, daemonizer: fix building on Windows
2017-11-15 23:12:02 +01:00
ef941855ae
Wallet RPC: Add prompt-for-password flag
2017-11-15 13:21:55 -05:00
0b726be703
wallet2: minimize the number of construct_tx calls
2017-11-15 18:01:35 +00:00
9d505d26b8
wallet2: cleanup some debug logs
2017-11-15 18:01:32 +00:00
ac5cd865b2
simplewallet: fix typo in incoming monero message
2017-11-15 17:52:37 +00:00
0d149f708f
Add out-of-bound exceptions and handle them in RPC
2017-11-15 16:35:14 +01:00
93c3398503
simplewallet: translate ring size 0 to mixin 0 (default values)
...
Avoids turning it to a huge number
2017-11-15 15:07:10 +00:00
c4587e83f8
simplewallet: wrong ns for input_line in sweep_single ( fix #2634 )
2017-11-15 20:45:58 +09:00
f9fad18608
blockchain_db: sanity check on tx/hash vector sizes
...
It could trip on a corrupt/crafted file if the user has disabled
input verification.
2017-11-15 10:02:23 +00:00
cd070874bf
Merge pull request #2778
...
c957795b
2017-11-15 11:40:38 +02:00
3abd6f1fd0
Merge pull request #2773
...
ffe5b857
2017-11-15 11:24:08 +02:00
c9a410e394
Merge pull request #2772
...
5d92c7cc
2017-11-15 11:23:22 +02:00
5c2dfe157b
Merge pull request #2771
...
e3e838d04877aca2
2017-11-15 11:22:56 +02:00
0d4d628805
Merge pull request #2634
...
b738f4b5
2017-11-15 11:17:01 +02:00
39bc39b86e
Merge pull request #2628
...
7cb303a4
2017-11-15 11:14:58 +02:00
b738f4b59d
wallet: add sweep_single command
2017-11-15 17:51:54 +09:00
a17b8233da
wallet2 bugfix: loading old m_unconfirmed_payments
2017-11-15 17:30:49 +09:00
987eb662bf
More missed readline dependencies thru scoped_message_writer
2017-11-14 22:43:52 +00:00
29cee4ec4f
Fix 383ff4f689
...
Missed a crypto::null_pkey in PR#2629
2017-11-14 20:36:21 +00:00
b85e82bf6a
Fix e89994e98f
...
Missed an input_line() change
2017-11-14 20:34:32 +00:00
95e784ad00
Fix 437421ce42
...
Missing an error argument for an exception
2017-11-14 20:29:05 +00:00
86a35eeed2
Merge pull request #2789
...
b0416f07
2017-11-14 22:17:07 +02:00
0c4df51bbb
Merge pull request #2765
...
fc85d7a9
2017-11-14 22:16:37 +02:00
a3ea62f209
CMake: include RPC when building GUI deps
2017-11-14 19:45:58 +00:00
10a237783a
Merge pull request #2692
...
0f2c2d4c
2017-11-14 21:32:33 +02:00
815e158bdf
Merge pull request #2739
...
99f398a2
2017-11-14 21:32:13 +02:00
edebe4e3b6
Merge pull request #2736
...
0d9c0db9178014c9a9e14a19437421cee89994e9ec5135e5082db75f
2017-11-14 21:31:51 +02:00
922aaf4e2a
Merge pull request #2644
...
a17efcb0
2017-11-14 21:31:09 +02:00
41a8bf4f4c
Merge pull request #2636
...
ad03f778
2017-11-14 21:30:25 +02:00
5de492be40
Merge pull request #2629
...
383ff4f6
2017-11-14 21:29:49 +02:00
0f2c2d4c34
rpc: remove obsolete busy core checks
2017-11-14 17:15:19 +00:00
99f398a25e
wallet2: avoid growing the short history when refreshing in a loop
2017-11-14 17:09:11 +00:00
0d9c0db996
Do not build against epee_readline if it was not built
2017-11-14 17:06:37 +00:00
178014c995
split off readline code into epee_readline
2017-11-14 17:06:35 +00:00
a9e14a19dc
link against readline only for monerod and wallet-wallet-{rpc,cli}
2017-11-14 17:06:32 +00:00
437421ce42
wallet: move some scoped_message_writer calls from the libs
2017-11-14 17:06:29 +00:00
e89994e98f
wallet: rejig to avoid prompting in wallet2
...
wallet2 is a library, and should not prompt for stdin. Instead,
pass a function so simplewallet can prompt on stdin, and a GUI
might display a window, etc.
2017-11-14 17:06:26 +00:00
ec5135e5b7
move input_line from command_line to simplewallet
...
It was only used there, and this removes one part of the common
dependency on libreadline
2017-11-14 17:06:23 +00:00
082db75f28
move cryptonote command line options to cryptonote_core
...
Those have no reason to be in a generic module
2017-11-14 17:06:19 +00:00
a17efcb039
make this build on SunOS/Solaris
2017-11-14 17:03:48 +00:00
ad03f77856
simplewallet: factor transfer related exception handling
...
This ensures they don't go out of sync when adding/changing them,
and makes the code easier to deal with.
2017-11-14 17:00:39 +00:00
383ff4f689
remove "using namespace std" from headers
...
It's nasty, and actually breaks on Solaris, where if.h fails to
build due to:
struct map *if_memmap;
2017-11-14 16:56:10 +00:00
fc85d7a998
simplewallet: fix in show_transfer passing wrong arg to wallet2::get_payments etc
2017-11-15 00:25:17 +09:00
f48aeab5c4
Merge pull request #2756
...
0bf09154
2017-11-14 16:02:28 +02:00
910218b14e
Merge pull request #2755
...
d70515fc
2017-11-14 15:57:25 +02:00
a2241e8151
Merge pull request #2753
...
fa514082
2017-11-14 15:54:33 +02:00
68d5952f6a
Merge pull request #2752
...
68c01782
2017-11-14 15:49:53 +02:00
95c34e17cd
Merge pull request #2750
...
424852a6
2017-11-14 15:49:15 +02:00
a2b427b1bf
Merge pull request #2749
...
f732e723
2017-11-14 15:35:47 +02:00
1e874186b3
Merge pull request #2747
...
37e1fd94
2017-11-14 15:32:29 +02:00
55603627c9
Merge pull request #2745
...
6cf33446
2017-11-14 15:31:40 +02:00
moneromooo-monero
redfish
Jaquee
Michał Sałaban
Jethro Grassie
stoffu
Riccardo Spagni
Maxithi
Nick Johnson
AJIekceu4
Howard Chu
rbrunner7
dEBRUYNE-1
Matt Smith
xmr-eric
Guillaume LE VAILLANT
Dmitriy Plekhanov
luigi1111
Tobias Hoffmann
xmr-eric
Cifrado
ston1th
Tim L
iDunk5400
flozilla
anonimal
Pavel Maryanov