702a41034d
Merge pull request #4088
...
8c4db68
2018-07-19 14:15:16 -05:00
be81a27fa4
Merge pull request #4071
...
d6d78f1
2018-07-19 14:06:54 -05:00
69502c4040
Merge pull request #4062
...
13851b2
2018-07-19 14:04:42 -05:00
2e4653c077
Merge pull request #4023
...
6cb9707
2018-07-19 13:51:44 -05:00
2951436704
wallet: warn when payment IDs are used
...
Subaddresses are better for privacy
2018-07-12 19:37:29 +01:00
20eb192162
simplewallet: reword "seed encryption" to "seed offset"
...
avoids people thinking it's somehow a generic AE system
2018-07-07 11:35:41 +01:00
82c39355ac
Merge pull request #4042
...
9d7f6e60
2018-07-03 15:21:27 +02:00
d6d78f157b
Allow fractional outputs to be ignored
2018-07-03 18:04:31 +09:00
8c4db68ff7
node_rpc_proxy: factor a few RPC calls using get_info
...
Takes advantage of caching
2018-07-02 17:59:44 +01:00
2329d2f4c8
Merge pull request #3907
...
dcbc17e
2018-06-27 16:32:33 -05:00
8a27caeb22
Merge pull request #3998
...
8db23df
2018-06-27 16:30:38 -05:00
5eb2e01216
Merge pull request #3991
...
798dfcf
2018-06-27 16:25:03 -05:00
3ad4ecd4ff
Merge pull request #3982
...
08b85a80cf80ba
2018-06-27 15:38:23 -05:00
dcbc17e97e
wallet: include a suggested number of confirmations based on amount
...
This is based on how much an attacking miner stands to lose in block
rewardy by mining a private chain which double spends a payment.
This is not foolproof, since mining is based on luck, and breaks
down as the attacking miner nears 50% of the network hash rate,
and the estimation is based on a constant block reward.
2018-06-27 21:38:21 +01:00
2d92fa5d69
Merge pull request #3979
...
362f5e6
2018-06-27 15:36:54 -05:00
13851b28c7
simplewallet.sweep_all: show usage when parsing fails
2018-06-27 22:54:10 +09:00
b1be364f08
Merge pull request #3966
...
948c482
2018-06-25 15:16:38 -05:00
473d984d88
Merge pull request #3921
...
8fc0cdb248310d46e90b7
2018-06-25 14:49:30 -05:00
1eddabf0a4
Merge pull request #3677
...
d45cd37
2018-06-25 14:41:48 -05:00
ff7dc087ae
Merge pull request #3407
...
7bf99a2
2018-06-25 14:39:01 -05:00
9d7f6e6089
simplewallet: init trusted daemon flag to false when autodetecting
2018-06-23 09:53:50 +01:00
d45cd37c53
fix typos in language files and rpc_args.cpp
2018-06-21 19:14:14 +02:00
248310de06
Move parse_subaddress_lookahead() from simplewallet.cpp to util.cpp
2018-06-21 12:36:17 +09:00
ffab67004c
Merge pull request #3784
...
261ee56
2018-06-20 15:15:19 -05:00
7bf99a2376
fix string handling for donation message
2018-06-20 15:57:23 -04:00
3721298cf6
Merge pull request #3932
...
8962f00941a6082b3357e
2018-06-20 14:44:54 -05:00
034b0c7adb
Merge pull request #3896
...
6b8568e
2018-06-20 14:13:59 -05:00
5a2864c1fb
simplewallet: fix delay when setting auto-refresh off
2018-06-18 21:05:42 +01:00
6cb97076ce
simplewallet: remove leftover global debug trace
2018-06-18 21:05:13 +01:00
9226acca4b
Merge pull request #3804
...
89e51ec
2018-06-16 14:15:52 -05:00
fceb774344
Merge pull request #3798
...
f357210
2018-06-16 14:14:19 -05:00
4e7897e57c
Merge pull request #3780
...
9c2a7b4
2018-06-16 14:12:57 -05:00
aada0670ba
Merge pull request #3538
...
f4e3295
2018-06-16 13:51:57 -05:00
8db23df581
wallet: on first refresh, start off with a quantized height
...
for privacy reasons, so an untrusted node can't easily track
wallets from IP address to IP address, etc. The granularity
is 1024 blocks, which is about a day and a half.
2018-06-13 22:44:27 +01:00
798dfcfe79
wallet: allow unspendable unmixable outputs to be discarded
2018-06-13 11:56:40 +09:00
41d04a87b2
Merge pull request #3648
...
6f36cf0
2018-06-12 12:18:17 -05:00
ed139efc5d
Merge pull request #3643
...
e2b7558
2018-06-12 12:13:07 -05:00
08b85a8e00
cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X
2018-06-11 20:17:02 +09:00
362f5e6eb8
simplewallet: don't confirm missing payment ID when sending to only subaddresses
2018-06-10 20:00:59 +09:00
f4e329583e
simplewallet: set_ring can now take a file with rings
2018-06-09 00:28:31 +01:00
948c48271a
simplewallet: grammar fix in warning message
2018-06-08 21:28:11 +01:00
8962f0032f
simplewallet: add optional trusted/untrusted argument to set_daemon
...
Otherwise the previous daemon's trustedness would carry over.
If not specified, the local address check is performed again.
2018-06-05 16:55:20 +01:00
9c2a7b4638
wallet-rpc: watch-only and cold wallet features added
...
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs
Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx
- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
2018-06-03 13:21:00 +02:00
6b8568e9a1
simplewallet.sign_transfer: rename export to export_raw, add help message
2018-06-01 09:38:14 +09:00
503d2693fd
Merge pull request #3640
...
f36132a
2018-05-31 14:44:54 -05:00
f03bf36c85
Merge pull request #3491
...
c8cb5fc
2018-05-30 15:55:37 -05:00
c4907d24cb
Merge pull request #3477
...
3f5fb6f
2018-05-29 13:01:50 -05:00
8e1b322a15
Merge pull request #3470
...
ad19f86
2018-05-29 12:59:58 -05:00
18761b372f
simplewallet: use correct unit for fee command
2018-05-20 23:16:31 +09:00
89e51ecd38
simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet
2018-05-15 15:28:42 +10:00
f357210c00
Fix Typo
2018-05-12 20:18:21 +02:00
261ee5628b
don't limit miner threads in wallet
2018-05-08 19:09:14 -04:00
f36132a837
wallet cli/rpc: terminate execution with code 0 when --help or --version is given
2018-04-22 11:48:44 +09:00
a429f06b18
Merge pull request #3579
...
0b88fff3
2018-04-21 21:58:52 +02:00
6f36cf02e7
Improve 'show_transfers' date formatting
...
Change the wallet's 'show_transfers' command to always output the transaction date with timestamp (24 hour UTC).
2018-04-15 19:23:15 -07:00
e2b75586fb
handle improper log levels
2018-04-15 11:33:22 -04:00
51b511be4c
simplewallet: add version command
2018-04-13 18:47:33 +01:00
5d8439e310
Merge pull request #3534
...
eecfb57d
2018-04-12 13:47:20 +02:00
f6094bb225
Merge pull request #3532
...
aa5c2e01
2018-04-12 13:46:50 +02:00
96b2fee721
Merge pull request #3536
...
c77d2bfa100b7bc1641dfc99
2018-04-12 11:12:33 +02:00
0b88fff3a5
simplewallet: fix help message of sign_transfer
2018-04-07 22:51:03 +09:00
641dfc991f
Automatic height setup when creating/restoring hw device.
...
When creating/restoring wallet, if --restore-height option is not used the current estimate
height is used for starting the scan. In other words it is assume we are creating a new account.
2018-03-31 18:00:33 +02:00
eecfb57df9
wallet: warn if not using the default ring size
2018-03-31 15:47:02 +01:00
aa5c2e01e7
simplewallet: warn about key reuse on startup
2018-03-31 10:52:10 +01:00
c8cb5fca5e
exit if specified wallet file doesn't exist
2018-03-24 11:13:21 -04:00
3f5fb6fe6d
simplewallet: add --untrusted-daemon option
2018-03-22 14:20:55 +00:00
ad19f8679e
don't show error twice when starting simplewallet
2018-03-21 22:56:04 -04:00
5730049178
wallet: catch exceptions dealing with ringdb and warn
2018-03-21 14:29:49 +00:00
df91d7bcbd
Merge pull request #3426
...
8ea3c4d5
2018-03-18 15:58:12 +02:00
8ea3c4d544
simplewallet: new --use-english-language-names flag
...
On some Windows systems, displaying language names in their own
languages freezes the display.
2018-03-17 22:46:41 +00:00
1e393f4bb7
wallet: make the segregation height settable
...
via user setting first, then DNS TXT record, hardcoded fallback
2018-03-17 14:56:31 +00:00
b86f1e5dad
Add command line option allowing to restrict the default sub-address lookahead in order to avoid
...
so looooong time of set-up when creating a HW based wallet.
2018-03-16 18:00:28 +01:00
a14eabc043
Merge pull request #3416
...
6f54c910#3175 (stoffu)
2018-03-16 18:10:20 +02:00
2a9839cc3e
Merge pull request #3376
...
833f9fcf
2018-03-16 18:08:52 +02:00
0f27fc57ac
Merge pull request #3336
...
57c0b1ed
2018-03-16 18:08:07 +02:00
eac3a11ed3
wallet: more user friendly print_ring
...
It can now take a txid (to display rings for all its inputs),
and will print rings in a format that set_ring understands
2018-03-16 12:07:45 +00:00
b09e5181cc
wallet: add a set_ring command
...
This is so one can set rings for spent key images in case the
attackers don't merge the ring matching patch set.
2018-03-16 10:32:51 +00:00
db10dd6d83
wallet: make ringdb an object with database state
2018-03-16 10:32:42 +00:00
d29ea0455a
wallet: add an output blackball list to avoid using those in rings
2018-03-16 10:32:37 +00:00
18eaf19489
wallet: key reuse mitigation options
...
If a pre-fork output is spent on both Monero and attack chain,
any post-fork output can be deduced to be a fake output, thereby
decreasing the effective ring size.
The segregate-per-fork-outputs option, on by default, allows
selecting only pre-fork outputs in this case, so that the same
ring can be used when spending it on the other side, which does
not decrease the effective ring size.
This is intended to be SET when intending to spend Monero on the
attack fork, and to be UNSET if not intending to spend Monero
on the attack fork (since it leaks the fact that the output being
spent is pre-fork).
If the user is not certain yet whether they will spend pre-fork
outputs on a key reusing fork, the key-reuse-mitigation2 option
should be SET instead.
If you use this option and intend to spend Monero on both forks,
then spend real Monero first.
2018-03-16 10:32:34 +00:00
5f146873c5
wallet: add shared ring database
...
This maps key images to rings, so that different forks can reuse
the rings by key image. This avoids revealing the real inputs like
would happen if two forks spent the same outputs with different
rings. This database is meant to be shared with all Monero forks
which don't bother making a new chain, putting users' privacy at
risk in the process. It is placed in a shared data directory by
default ($HOME/.shared-ringdb on UNIX like systems). You may
use --shared-ringdb-dir to override this location, and should
then do so for all Monero forks for them to share the database.
2018-03-16 10:32:29 +00:00
833f9fcfe9
show '<Not set>' for empty wallet description
2018-03-15 23:22:45 -04:00
6f54c910f7
simplewallet: fix restore height prompt that got disabled by #3175
2018-03-16 11:55:31 +09:00
57c0b1ed9f
Fix typos in various files
2018-03-15 18:25:38 +02:00
51bb7fafac
Merge pull request #3410
...
c5024c5b
2018-03-15 17:10:01 +02:00
c5024c5b73
simplewallet: add a warning when getting a daemon error in transfer
...
A malicious daemon (or MITM) could attempt to add spurious errors
so the wallet tries again, sending another set of fake outs.
2018-03-15 13:33:19 +00:00
a7266d6d7b
wallet2+cli+rpc: eliminate redundant m_http_client from cli/rpc and delegate calls to wallet2
2018-03-15 22:01:51 +09:00
534369eece
Merge pull request #3384
...
b63ea060
2018-03-14 16:08:14 +02:00
27a196b126
device: untangle cyclic depenency
...
When #3303 was merged, a cyclic dependency chain was generated:
libdevice <- libcncrypto <- libringct <- libdevice
This was because libdevice needs access to a set of basic crypto operations
implemented in libringct such as scalarmultBase(), while libringct also needs
access to abstracted crypto operations implemented in libdevice such as
ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct
into libringct_basic and libringct, where the basic crypto ops previously in
libringct are moved into libringct_basic. The cyclic dependency is now resolved
thanks to this separation:
libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct
This eliminates the need for crypto_device.cpp and rctOps_device.cpp.
Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and
get_subaddress_secret_key() were previously implemented in libcryptonote_basic
(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,
which is odd because libdevice is supposed to be independent of libcryptonote_basic.
Therefore, those functions were moved to device_default.cpp.
2018-03-14 21:00:15 +09:00
3bc2537f5a
Merge pull request #3369
...
1979d53d
2018-03-14 13:37:14 +02:00
3fed788603
Merge pull request #3315
...
649a1b7a
2018-03-14 13:35:11 +02:00
b63ea060de
simplewallet: do not call a RPC when displaying the prompt
...
Speeds up refresh when you have a lot of in/out transactions
2018-03-11 10:23:45 +00:00
649a1b7ae6
wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets
...
Previously, a file containing the unencrypted Monero address was
created by default in the wallet's directory. This file might pose
as a privacy risk. The creation of this file is now opt-in and can
be enabled by providing
--create-address-file
2018-03-10 16:28:23 +01:00
1979d53d78
wallet: fixes and tweaks to the save_watch_only command
...
- save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly
- catch any exception (eg, I/O errors) and error out
- print the new keys filename in simplewallet
2018-03-07 14:24:14 +00:00
38657fd0e9
Bump min ring size from 5 to 7 from v7
2018-03-07 13:19:04 +00:00
a21c927d7d
Merge pull request #3298
...
f2bb8085Fix #3297 use the password_prompter helper (Howard Chu)
2018-03-05 19:17:51 +02:00
0c2b25204e
Merge pull request #3312
...
399120dd
2018-03-05 19:16:52 +02:00
237f0179b7
Merge pull request #3313
...
43026822
2018-03-05 19:15:54 +02:00
61ac5b0471
Merge pull request #3332
...
6b40ea93
2018-03-05 19:12:59 +02:00
4f93f74528
Merge pull request #3277
...
0e7ad2e2af773211cc9a0bee55f8d917450306a0#3318 (stoffu)
9f9e095a#3261 (Jean Pierre Dudey)
2018-03-05 19:11:20 +02:00
luigi1111
moneromooo-monero
Riccardo Spagni
stoffu
ordtrogen
cryptochangements34
Dusan Klinec
jcktm
Rafficer
cryptochangements34
Ryan Ronnander
cslashm
Dimitris Apostolou
Leon Klingele