Commit Graph

6895 Commits

Author SHA1 Message Date
Alexander Blair d8f9472356
Merge pull request #6910
b7dd8349f Allow setting start block on export (Howard Chu)
2020-12-01 14:18:44 -08:00
Alexander Blair 438442ace0
Merge pull request #6890
ec14e4b8c wallet2: skip reorgs exceeding max-reorg-depth wallet setting (xiphon)
2020-12-01 14:18:22 -08:00
moneromooo 6c9980a55b
p2p: give all hosts the same chance of being picked for connecting
even if some run more than one node
2020-11-29 15:55:58 +00:00
selsta 7a5e11645f
net_node: add tor / i2p seed nodes
Co-authored-by: Lee Clagett <code@leeclagett.com>
2020-11-29 13:49:03 +01:00
luigi1111 850edfe419
Merge pull request #7021
d73cb95 Fix timeout checks for forwarded and Dandelion++ stem txes (Lee Clagett)
2020-11-29 01:59:35 -06:00
luigi1111 cf816e51ad
Merge pull request #7020
2c66894 wallet_api: TransactionHistory - fill unconfirmed out payments dests (xiphon)
2020-11-29 01:58:56 -06:00
luigi1111 36d31ba0be
Merge pull request #7018
a9cd5d9 cryptonote_core: dandelion - use local height or median height if syncing (xiphon)
2020-11-29 01:58:13 -06:00
luigi1111 ad843541d5
Merge pull request #7008
3247f11 Silence stupid warnings (Howard Chu)
2020-11-29 01:57:24 -06:00
luigi1111 c041550ffa
Merge pull request #6973
be84f67 Switch to Dandelion++ fluff mode if no out connections for stem mode (Lee Clagett)
2020-11-29 01:54:43 -06:00
luigi1111 a92b968e35
Merge pull request #6971
f9527e6 protocol: reject empty incoming block messages (moneromooo-monero)
2020-11-29 01:54:08 -06:00
luigi1111 9945ca7a62
Merge pull request #6960
5569a8e rpc: on_send_raw_tx (bootstrap) - send to bootstrap daemon and P2P (xiphon)
2020-11-29 01:53:12 -06:00
luigi1111 bb56248acd
Merge pull request #6949
aad780b Fix CLI and unrestricted RPC relay_tx with stempool (Lee Clagett)
2020-11-29 01:52:23 -06:00
luigi1111 9a4d813136
Merge pull request #6943
cb069d0 p2p: remove banned peers from the white list (moneromooo-monero)
2020-11-29 01:51:41 -06:00
luigi1111 7a0334742a
Merge pull request #6937
8a282f6 Add RELINK_TARGETS, monero_add_target_no_relink and use monero_add_executable/monero_add_library where possible (mj-xmr) Add monero_add_minimal_executable and use in tests (mj-xmr)
2020-11-29 01:49:39 -06:00
luigi1111 2be7a4c04f
Merge pull request #6933
1f04a31 p2p: use /16 filtering on IPv4-within-IPv6 addresses (moneromooo-monero)
2020-11-29 01:46:46 -06:00
luigi1111 4d298d4f11
Merge pull request #6924
874487f blockchain: remove some dead code (moneromooo-monero)
2020-11-29 01:44:26 -06:00
luigi1111 999e797cea
Merge pull request #6922
a25bc71 Make Blockchain::get_fee_quantization_mask() compile time (SChernykh)
2020-11-29 01:40:59 -06:00
luigi1111 bab4495cfb
Merge pull request #6921
f1836ac cryptonote_core: Fix missing override warnings (Nathan Dorfman)
2020-11-29 01:39:17 -06:00
luigi1111 c5b3fd1fec
Merge pull request #6920
aad2f87 net_node: add --ban-list option (selsta)
2020-11-29 01:38:27 -06:00
luigi1111 84cdb5d914
Merge pull request #6915
c67fa32 bump default number of connections from 8 to 12 (moneromooo-monero)
2020-11-29 01:34:02 -06:00
luigi1111 4c2e77854d
Merge pull request #6913
fc2f971 wallet2: wait for propagation timeout before marking tx as failed (xiphon)
2020-11-29 01:32:01 -06:00
luigi1111 eebd86dc3e
Merge pull request #6898
593ae2e device: Ledger - update status codes (xiphon)
2020-11-29 00:44:27 -06:00
luigi1111 52006df9bb
Merge pull request #6897
2abdbf6 Add support for i2p and tor seed nodes (vtnerd)
2020-11-29 00:42:27 -06:00
luigi1111 7539d4ac74
Merge pull request #6895
b49f489 fix next_seed_height regression in getblocktemplate rpc (xnbya)
2020-11-29 00:41:42 -06:00
luigi1111 678237835f
Merge pull request #6892
ad7ea2c core_rpc_server: on_send_raw_tx - fix bootstrap daemon mode check (xiphon)
2020-11-29 00:40:03 -06:00
luigi1111 d45a4ba106
Merge pull request #6849
f4b2382 rpc_private_headers declaration fix (malbit)
2020-11-28 22:31:25 -06:00
luigi1111 7778384071
Merge pull request #6830
64e9526 Extend TransactionInfo with coinbase and description attributes in wallet/api (dsc)
2020-11-28 21:55:16 -06:00
dsc d157196416 Allow tx note edits via TransactionHistory object in wallet/api 2020-11-28 21:48:57 -06:00
luigi1111 b37d6fe368
Merge pull request #6826
83da867 Update error messages in daemon (tmoravec)
2020-11-28 21:35:34 -06:00
xiphon a9cd5d914e cryptonote_core: dandelion - use local height or median height if syncing 2020-11-25 01:27:42 +00:00
Crypto City 17c5370398
wallet2: check imported multisig curve points are in main subgroup 2020-11-24 16:25:35 +00:00
xiphon 0363476ee3 rpc: get_info - add 'synchronized' field 2020-11-19 12:51:31 +00:00
Lee Clagett b10878f108 Change Dandelion++ fluff probability to 20%, and embargo timeout to 39s
A 20% fluff probability increases the precision of a spy connected to
every node by 10% on average, compared to a network using 0% fluff
probability. The current value (10% fluff) should increase precision by
~5% compared to baseline.

This decreases the expected stem length from 10 to 5. The embargo
timeout was therefore lowered to 39s; the fifth node in a stem is
expected to have a 90% chance of being the first to timeout, which is
the same probability we currently have with an expected stem length of
10 nodes.
2020-11-17 21:45:37 -05:00
xiphon aaf837cf5f rpc: skip non-synced bootstrap daemons in --no-sync mode too 2020-11-17 23:15:36 +00:00
Howard Chu 91fd634768
Better log message for unusable anon networks 2020-11-16 12:36:37 +00:00
Lee Clagett d73cb95dfa Fix timeout checks for forwarded and Dandelion++ stem txes 2020-11-15 00:08:10 -05:00
xiphon 5569a8e426 rpc: on_send_raw_tx (bootstrap) - send to bootstrap daemon and P2P 2020-11-15 03:13:07 +00:00
xiphon 2c668940cd wallet_api: TransactionHistory - fill unconfirmed out payments dests 2020-11-14 14:09:07 +00:00
Howard Chu 3247f11638
Silence stupid warnings 2020-11-11 02:34:14 +00:00
Lee Clagett be84f678b9 Switch to Dandelion++ fluff mode if no out connections for stem mode 2020-11-03 13:58:14 -05:00
moneromooo-monero f9527e608e
protocol: reject empty incoming block messages 2020-11-03 12:59:36 +00:00
moneromooo-monero 1f04a3186b
p2p: use /16 filtering on IPv4-within-IPv6 addresses
IPv6 addresses include a range that can map IPv4 addresses,
which allowed those mapped addresses to bypass filtering.

This filter should be replaced by AS filtering at some point.
2020-11-03 00:46:07 +00:00
Lee Clagett aad780bcfa Fix CLI and unrestricted RPC relay_tx with stempool 2020-10-29 00:17:55 -04:00
Howard Chu 65903d2cfc
Add rpc-restricted-bind-ip option
Fixes #6369
2020-10-29 00:22:18 +00:00
mj-xmr 8a282f64c9 Add RELINK_TARGETS, monero_add_target_no_relink and use monero_add_executable/monero_add_library where possible (mj-xmr)
Add monero_add_minimal_executable and use in tests

This is done in order not to have to relink targets, when just an .so changed, but not its interface.
2020-10-28 20:08:26 +01:00
moneromooo cb069d0a42
p2p: remove banned peers from the white list 2020-10-27 22:35:14 +00:00
luigi1111 8b3b106ad1
Merge pull request #6902
70eb0d1 wallet2_api: implement stop() to interrupt refresh() loop once (xiphon)
2020-10-21 22:57:42 -05:00
selsta aad2f87a53
net_node: add --ban-list option 2020-10-20 19:39:44 +02:00
moneromooo-monero 874487fed8
blockchain: remove some dead code
This is already done
2020-10-20 16:50:36 +00:00
moneromooo-monero cc034fe0c3
util: fix escaping more than one ?* in glob_to_regex 2020-10-20 16:46:53 +00:00
SChernykh a25bc71f3f Make Blockchain::get_fee_quantization_mask() compile time
This also removes potential thread safety bug in that function.
2020-10-20 14:16:09 +02:00
Nathan Dorfman f1836ac28a cryptonote_core: Fix missing override warnings 2020-10-19 18:23:07 -06:00
Lee Clagett 2abdbf63cf Add support for i2p and tor seed nodes 2020-10-19 13:13:07 +00:00
Alexander Blair faedcded39
Merge pull request #6891
4cf3545a3 core_rpc_server: on_get_blocks - forward bootstrap daemon error (xiphon)
2020-10-18 23:26:17 -07:00
Alexander Blair 8e3f46dd0a
Merge pull request #6881
11b20229c tx_pool: silence spammy harmless warning till we fix the bug (moneromooo-monero)
2020-10-18 23:25:54 -07:00
Alexander Blair 142489bd60
Merge pull request #6882
fcbfb0a00 wallet2: fix missing m_state field in wallet serialization (moneromooo-monero)
2020-10-18 23:25:32 -07:00
Alexander Blair 543d600042
Merge pull request #6875
a12a8174e Dandelion++: skip desynced peers in stem phase (xiphon)
2020-10-18 23:25:08 -07:00
xiphon fc2f97177b wallet2: wait for propagation timeout before marking tx as failed 2020-10-18 14:00:56 +00:00
moneromooo-monero c67fa32496
bump default number of connections from 8 to 12 2020-10-18 13:25:05 +00:00
Howard Chu b7dd8349f4
Allow setting start block on export
And make import honor the starting block# recorded in a bootstrap file
2020-10-18 14:01:44 +01:00
Alexander Blair 519740a1d3
Merge pull request #6905
88fde0309 blockchain: fix sync at v14 boundary (moneromooo-monero)
2020-10-18 05:51:43 -07:00
moneromooo-monero 88fde0309a
blockchain: fix sync at v14 boundary
Miners with MLSAG txes which they'd already verified included
a couple in that block, but the consensus rules had changed
in the meantime, so that block is technically invalid and any
node which did not already have those two txes in their txpool
could not sync. Grandfather them in, since it has no effect in
practice.
2020-10-18 11:52:33 +00:00
xiphon 70eb0d1844 wallet2_api: implement stop() to interrupt refresh() loop once 2020-10-17 02:56:15 +00:00
Lee Clagett 13350f79df Do not use peer_id tracking method over i2p/tor 2020-10-15 16:47:59 +00:00
xiphon 593ae2e9f9 device: Ledger - update status codes 2020-10-13 22:53:19 +00:00
luigi1111 e503688a6b
Merge pull request #6828
1b3f220 Allow AddressBook description edits via wallet/api interface (xmrdsc)
2020-10-13 10:39:05 -05:00
xiphon ec14e4b8cd wallet2: skip reorgs exceeding max-reorg-depth wallet setting 2020-10-13 15:23:35 +00:00
Alexis Enston b49f48962b fix next_seed_height regression in getblocktemplate rpc 2020-10-13 11:07:59 +01:00
xiphon 4cf3545a31 core_rpc_server: on_get_blocks - forward bootstrap daemon error 2020-10-13 00:44:59 +00:00
xiphon ad7ea2c60c core_rpc_server: on_send_raw_tx - fix bootstrap daemon mode check 2020-10-12 23:49:37 +00:00
moneromooo-monero fcbfb0a00a
wallet2: fix missing m_state field in wallet serialization 2020-10-12 15:35:52 +00:00
moneromooo-monero 11b20229c9
tx_pool: silence spammy harmless warning till we fix the bug 2020-10-12 14:07:40 +00:00
xiphon a12a8174e0 Dandelion++: skip desynced peers in stem phase 2020-10-12 13:44:06 +00:00
Lee Clagett 7414e2bac1 Change epee binary output from std::stringstream to byte_stream 2020-10-10 15:28:40 +00:00
Lee Clagett dff1d8067c Fix tx flush callback queueing 2020-10-06 16:07:49 +00:00
Alexander Blair 3cbb44a2fd
Merge pull request #6841
b6c4f8cd5 fix a couple bugs found by OSS-fuzz (moneromooo-monero)
2020-09-27 16:17:17 -07:00
Michal m@lbit Malicki f4b2382713
rpc_private_headers declaration fix 2020-09-27 13:41:44 +01:00
moneromooo-monero b6c4f8cd54
fix a couple bugs found by OSS-fuzz
- index out of bounds when importing outputs
- accessing invalid CLSAG data
2020-09-24 15:30:38 +00:00
xiphon 4846743fdc daemon: Windows - fix FAT32 warning, trailing backslash is required 2020-09-20 13:57:44 +00:00
dsc 64e9526509 Extend TransactionInfo with coinbase and description attributes in wallet/api 2020-09-19 22:54:23 +02:00
dsc 1b3f220251 Allow AddressBook description edits via wallet/api interface 2020-09-19 18:29:46 +02:00
Tadeas Moravec 83da867474
Update error messages in daemon
When given a wrong argument, some daemon commands failed with "unknown
command" error, instead of a meaningful error message. This patch
brings consistency into the error messages.

In several places, this patch removes relatively useful messages,
and replaces them with more generic ones. E.g.,

-    std::cout << "use: print_pl [white] [gray] [<limit>] [pruned]
[publicrpc]" << std::endl;
+    std::cout << "Invalid syntax: Too many parameters. For more
details, use the help command." << std::endl;

There are two reasons for this:

1. Consistency.
2. Removing duplicates.

The detailed information about the parameters is present in
the help messages already. Having it in two places increases
the risk that the messages would get out of date.
2020-09-18 14:04:19 +02:00
luigi1111 d27d4526fe
Merge pull request #6819
c3f354e simplewallet fix wrong persistent-rpc-client-id name in help (moneromooo-monero)
2020-09-15 19:59:36 -05:00
luigi1111 5b3614e6a9
Merge pull request #6816
929ea98 Remove unused macros from cryptonote_config.h (TheCharlatan)
2020-09-15 19:58:39 -05:00
luigi1111 2b1488ef6f
Merge pull request #6793
de9a9fb update error message 'No unlocked balance in the specified account' (woodser)
2020-09-15 19:56:49 -05:00
TheCharlatan 80e535c95a
wallet2: adapt to deterministic unlock time 2020-09-15 11:40:31 +00:00
moneromooo-monero 4971219c2c
blockchain: deterministic UNIX time unlock checks
Based on a patch by TheCharlatan <seb.kung@gmail.com>
2020-09-15 11:40:28 +00:00
moneromooo-monero c3f354e6c1
simplewallet fix wrong persistent-rpc-client-id name in help 2020-09-14 20:50:35 +00:00
luigi1111 9bba1a24ea Merge pull request #6815
ef4325f wallet2: fix tx sanity check triggering on pre-rct outputs (monermooo-monero)
2020-09-14 11:47:06 -05:00
luigi1111 2993d2004a
Merge pull request #6813
a3844e2 Fix typo in command line argument description (reinaldoacosta)
2020-09-14 11:45:55 -05:00
selsta f240b1dd88
build: prepare v0.17 2020-09-14 16:52:42 +02:00
TheCharlatan 929ea98662 Remove unused macros from cryptonote_config.h 2020-09-14 00:20:58 +02:00
moneromooo-monero ef4325fd41
wallet2: fix tx sanity check triggering on pre-rct outputs 2020-09-12 17:51:41 +00:00
Reinaldulin a3844e257e
Fix typo in command line argument description 2020-09-09 10:18:32 -04:00
luigi1111 836067b68b
Merge pull request #6805
fc2cb22 blockchain: fix pow skipping for old blocks without precalc hash (moneromooo-monero)
2020-09-07 15:31:20 -05:00
luigi1111 9c9c689db4
Merge pull request #6804
5498142 rpc: assume randomx from v13 onwards (moneromooo-monero)
2020-09-07 14:34:46 -05:00
luigi1111 3a761e10d2
Merge pull request #6800
036da6d Let stagenet hardfork happen before mainnet. (normoes)
2020-09-07 14:32:28 -05:00
luigi1111 fd657c7706
Merge pull request #6798
4e44306 enable CLSAG support for Trezor client (ph4r05)
2020-09-07 14:30:41 -05:00
moneromooo-monero fc2cb224a9
blockchain: fix pow skipping for old blocks without precalc hash 2020-09-07 01:57:19 +00:00
moneromooo-monero 5498142e8f
rpc: assume randomx from v13 onwards 2020-09-07 01:13:06 +00:00