63c7ca07fb
Merge pull request #7136
...
23aae55
2021-04-16 12:45:30 -05:00
2218e23e84
Merge pull request #7002
...
673c6d2
2021-04-16 12:43:42 -05:00
673c6d2d11
Reduce compilation time of epee/portable_storage_template_helper.h
2021-03-28 15:41:48 +02:00
254a1338ad
core: speed up print_coinbase_tx_sum
...
It only needs to parse the tx headers, not the full tx data
2021-03-18 11:16:08 +00:00
f9b5b521e8
fix serialization being different on mac
...
On Mac, size_t is a distinct type from uint64_t, and some
types (in wallet cache as well as cold/hot wallet transfer
data) use pairs/containers with size_t as fields. Mac would
save those as full size, while other platforms would save
them as varints. Might apply to other platforms where the
types are distinct.
There's a nasty hack for backward compatibility, which can
go after a couple forks.
2021-03-05 23:42:33 +00:00
6556c33f13
Merge pull request #7355
...
bd129841572df9
2021-02-18 14:06:47 -05:00
85db1734e7
Remove unused variables in monero codebase
...
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.
In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
2021-02-09 08:05:05 +01:00
bd129849f0
Remove copies from foreach loops (thanks to Clang)
2021-01-28 23:42:40 -05:00
679d05567d
Remove payload copy in all outgoing p2p messages
2021-01-19 02:22:32 +00:00
e45619e61e
Revert "Merge pull request #7136"
...
This reverts commit 63c7ca07fb2218e23e84
2021-04-16 13:52:44 -05:00
23aae5571b
Remove payload copy in all outgoing p2p messages
2021-01-16 22:53:28 +00:00
1e27f7101e
blockchain: lock access to m_blocks_hash_of_hashes
...
it is accessed both when adding and when prevalidating a set
of new hashes from a peer
2021-01-02 22:19:54 +00:00
0aa541b361
protocol: more sanity checks in new chain block hashes
2020-12-31 23:33:18 +00:00
1eb14af1a3
rpc: limit the number of txes for get_blocks.bin
2020-12-29 04:31:58 +00:00
4f401f6fca
Merge pull request #7025
...
b10878f10
2020-12-01 14:23:49 -08:00
850edfe419
Merge pull request #7021
...
d73cb95
2020-11-29 01:59:35 -06:00
36d31ba0be
Merge pull request #7018
...
a9cd5d9
2020-11-29 01:58:13 -06:00
4d298d4f11
Merge pull request #6924
...
874487f
2020-11-29 01:44:26 -06:00
999e797cea
Merge pull request #6922
...
a25bc71
2020-11-29 01:40:59 -06:00
a9cd5d914e
cryptonote_core: dandelion - use local height or median height if syncing
2020-11-25 01:27:42 +00:00
b10878f108
Change Dandelion++ fluff probability to 20%, and embargo timeout to 39s
...
A 20% fluff probability increases the precision of a spy connected to
every node by 10% on average, compared to a network using 0% fluff
probability. The current value (10% fluff) should increase precision by
~5% compared to baseline.
This decreases the expected stem length from 10 to 5. The embargo
timeout was therefore lowered to 39s; the fifth node in a stem is
expected to have a 90% chance of being the first to timeout, which is
the same probability we currently have with an expected stem length of
10 nodes.
2020-11-17 21:45:37 -05:00
d73cb95dfa
Fix timeout checks for forwarded and Dandelion++ stem txes
2020-11-15 00:08:10 -05:00
874487fed8
blockchain: remove some dead code
...
This is already done
2020-10-20 16:50:36 +00:00
a25bc71f3f
Make Blockchain::get_fee_quantization_mask() compile time
...
This also removes potential thread safety bug in that function.
2020-10-20 14:16:09 +02:00
f1836ac28a
cryptonote_core: Fix missing override warnings
2020-10-19 18:23:07 -06:00
8e3f46dd0a
Merge pull request #6881
...
11b20229c
2020-10-18 23:25:54 -07:00
543d600042
Merge pull request #6875
...
a12a8174e
2020-10-18 23:25:08 -07:00
88fde0309a
blockchain: fix sync at v14 boundary
...
Miners with MLSAG txes which they'd already verified included
a couple in that block, but the consensus rules had changed
in the meantime, so that block is technically invalid and any
node which did not already have those two txes in their txpool
could not sync. Grandfather them in, since it has no effect in
practice.
2020-10-18 11:52:33 +00:00
11b20229c9
tx_pool: silence spammy harmless warning till we fix the bug
2020-10-12 14:07:40 +00:00
a12a8174e0
Dandelion++: skip desynced peers in stem phase
2020-10-12 13:44:06 +00:00
4971219c2c
blockchain: deterministic UNIX time unlock checks
...
Based on a patch by TheCharlatan <seb.kung@gmail.com>
2020-09-15 11:40:28 +00:00
f240b1dd88
build: prepare v0.17
2020-09-14 16:52:42 +02:00
fc2cb224a9
blockchain: fix pow skipping for old blocks without precalc hash
2020-09-07 01:57:19 +00:00
aefa7740c3
Merge pull request #6111
...
d20ff4f646a0b3b1f89d42649d5
2020-09-06 15:49:37 +02:00
ee0b02d0db
Merge pull request #6757
...
6a37da8
2020-09-03 12:25:59 -05:00
6a37da837e
threadpool: guard against exceptions in jobs, and armour plating
...
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
2020-09-01 14:33:33 +00:00
d20ff4f648
functional_tests: add a large (many randomx epochs) p2p reorg test
2020-08-27 15:13:04 +00:00
9d42649d58
core: fix mining from a block that's not the current top
2020-08-27 15:13:00 +00:00
82ee01699c
Integrate CLSAGs into monero
...
They are allowed from v12, and MLSAGs are rejected from v13.
2020-08-27 12:44:04 +00:00
0c101f1236
Merge pull request #6767
...
07442a605
2020-08-27 03:07:32 -07:00
b04da25e4d
Merge pull request #6760
...
844fb4e94
2020-08-27 03:01:28 -07:00
844fb4e940
enforce claiming maximum coinbase amount
...
Claiming a slightly lesser amount does not yield the size gains
that were seen pre rct, so this closes a fingerprinting vector
2020-08-21 12:36:53 +00:00
55363c5941
Avoid some temporary strings when reading off the database
2020-08-17 14:02:27 +00:00
d73b1b6560
Merge pull request #6727
...
13eee1d6a92e6b7df26dd95d53090016ad74
2020-08-16 12:55:25 -07:00
bc48494731
Merge pull request #6661
...
267ce5b71
2020-08-16 12:45:37 -07:00
c6c4ead44e
Merge pull request #6614
...
fb31167b1
2020-08-16 12:44:03 -07:00
07442a6059
Fix build with Boost 1.74
...
Thanks iDunk for testing
2020-08-16 16:23:26 +00:00
c108c5e2f0
Merge pull request #6354
...
67ade8005
2020-08-09 06:42:49 -07:00
90016ad744
blockchain: guard against exceptions in add_new_block/children
...
Reporter requested credit to be given to Decred
2020-07-30 22:52:11 +00:00
fb31167b12
Wallet, daemon: From 'help_advanced' back to 'help', and new 'apropos' command
2020-07-24 07:12:11 +02:00
36d50d93f2
Merge pull request #6534
...
7bd66b01b
2020-07-19 03:36:39 -07:00
814e617117
Merge pull request #6526
...
5d882f4f1
2020-07-19 03:34:52 -07:00
a0d179e528
Merge pull request #6512
...
5ef0607da
2020-07-19 03:32:59 -07:00
332d60719a
tx_pool: mine stem txes in fake chain mode
...
This fixes the functional tests, since txes would not be mined
after being sent to the daemon (they'd be waiting for the
dandelion timeout first)
2020-07-09 14:52:13 +00:00
0fd6ccef21
blockchain: fix timestamp/difficulty cache getting out of sync
...
The cache is discarded when a block is popped, but then gets
rebuilt when the difficulty for next block is requested.
While this is all properly locked, it does not take into account
the delay caused by a database transaction being only committed
(and thus its effects made visible to other threads) later on,
which means another thread could request difficulty between
the pop and the commit, which would end up using stale database
view to build the cache, but that cache would not be invalidated
again when the transaction gets committed, which would cause the
cache to not match the new database data.
To fix this, we now keep track of when the cache is invalidated
so we can invalidate it again upon database transaction commit
to ensure it gets calculated again with fresh data next time it
is nedeed.
2020-07-08 22:31:51 +00:00
99b14ccd6a
Merge pull request #6647
...
4d8d121
2020-07-08 17:25:01 -05:00
18bb011afe
Merge pull request #6629
...
795e186
2020-07-08 17:23:28 -05:00
634262f3f5
Merge pull request #6568
...
f037121
2020-07-08 17:10:39 -05:00
ed903578d7
Merge pull request #6544
...
5741b4d
2020-07-08 17:04:41 -05:00
267ce5b718
avoid a couple needless copies
2020-06-14 18:05:35 +00:00
4d8d121462
Fix D++ block template check
2020-06-12 22:05:52 -04:00
7bd66b01bf
daemon: guard against rare 'difficulty drift' bug with checkpoints and recalculation
...
On startup, it checks against the difficulty checkpoints, and if any mismatch is found, recalculates all the blocks with wrong difficulties. Additionally, once a week it recalculates difficulties of blocks after the last difficulty checkpoint.
2020-06-09 10:40:51 +09:00
795e18632c
blockchain: fix total_height in getblocks.bin response
2020-06-05 15:27:07 +00:00
f0371210e9
cryptonote_core: remove "We are most likely forked" message
...
It's time based and we don't have forks every 6 months anymore
2020-05-19 16:27:24 +00:00
5741b4d74d
blockchain: detect and log bad difficulty calculations
2020-05-17 12:44:45 +00:00
67ade80055
Add randomized delay when forwarding txes from i2p/tor -> ipv4/6
2020-05-15 07:57:35 +00:00
4baee200a7
build: prepare v0.16.0.0 release
2020-05-13 16:15:03 +02:00
5d882f4f14
blockchain: fix theoretical race getting bulk timestamps
2020-05-13 13:42:41 +00:00
77a008f714
Merge pull request #6510
...
70609d7
2020-05-07 10:44:34 -05:00
5ef0607da6
Update copyright year to 2020
...
Update copyright year to 2020
2020-05-06 22:36:54 -04:00
70609d7681
cryptonote_core: take out the time based upgrade warning
...
It doesn't really work anymore since we don't have a fork soon
2020-05-06 18:27:23 +00:00
0f233c6ad8
Merge pull request #6478
...
ee58362
2020-05-06 00:27:13 -05:00
483e5cab5c
Merge pull request #6472
...
2efbd5f
2020-05-06 00:25:18 -05:00
1f505a5eac
Merge pull request #6468
...
a813c46
2020-05-06 00:22:20 -05:00
e5214a2ca2
Adding ZMQ/Pub support for txpool_add and chain_main events
2020-05-04 02:06:35 +00:00
443f5c6bda
Merge pull request #6436
...
688a3e8
2020-05-01 15:20:05 -05:00
dd807b8410
txpool.cpp: rename var to fix for old g++ version (xenial default)
2020-04-29 10:03:51 +00:00
ee58362b1f
Used legacy category to match insert_key_images behavior
2020-04-24 20:19:37 -04:00
2efbd5f0cc
cryptonote: fix reuse of non default tx data when relaying
...
An automatic tx variable is initialized properly on the first
run through the loop, but not the second. Moving the variable
inside the loop ensures the ctor is called again to init it.
2020-04-22 16:50:20 +00:00
a813c46a1b
cryptonote_core: skip dns checkpoints on startup if not enforced
2020-04-20 18:56:22 +00:00
688a3e87e7
Add timelock verification on device
2020-04-08 11:12:32 +02:00
44547006bf
Merge pull request #6347
...
fcb06f7
2020-04-04 12:52:46 -05:00
c4f75fe898
Merge pull request #6339
...
c61abf8
2020-04-04 12:47:31 -05:00
0bb7191fd6
Merge pull request #6328
...
9bde70e
2020-04-04 12:40:18 -05:00
6c7d928f19
Merge pull request #6336
...
760ecf209c8111e377977
2020-03-31 15:14:12 -05:00
096e2135dd
Merge pull request #6214
...
054b4c7
2020-03-31 13:32:55 -05:00
571546067f
Always reject duplicate key-images from second txid
2020-03-30 17:52:42 +00:00
babf25d2ec
Allow unrestricted rpc calls to get full txpool info
2020-03-30 17:52:42 +00:00
8cb005b39c
Merge pull request #6289
...
ffe7165e
2020-03-27 12:28:29 -07:00
aa982a51da
Merge pull request #6284
...
02224e71
2020-03-27 12:21:26 -07:00
a22cf5de1b
Merge pull request #6275
...
aa93e388
2020-03-27 12:16:30 -07:00
02d887c2e5
Adding Dandelion++ support to public networks:
...
- New flag in NOTIFY_NEW_TRANSACTION to indicate stem mode
- Stem loops detected in tx_pool.cpp
- Embargo timeout for a blackhole attack during stem phase
2020-03-26 15:01:30 +00:00
228af683a7
Merge pull request #6403
...
5de2295
2020-04-10 16:10:33 -05:00
7954f8cb18
Merge pull request #6358
...
8958b4e
2020-04-10 16:01:37 -05:00
054b4c7f41
protocol: request txpool contents when synced
...
A newly synced Alice sends a (typically quite small) list of
txids in the local tpxool to a random peer Bob, who then uses
the existing tx relay system to send Alice any tx in his txpool
which is not in the list Alice sent
2020-03-22 16:03:31 +00:00
aa93e38862
p2p: remove old debug commands
2020-03-20 22:09:44 -07:00
5de2295f3c
Correct key image check in tx_pool
2020-03-14 19:17:15 +00:00
f8d76f395b
core: move the LockedTXN class out of txpool so it may be reused
...
for example, in the RPC server
2020-03-12 11:30:05 +00:00
4371ac4265
Merge pull request #6225
...
987c3139
2020-02-28 19:48:11 -08:00
4da37daf67
Merge pull request #6211
...
5985c5af
2020-02-28 19:36:16 -08:00
8958b4e7aa
blockchain_db: faster fetching of consecutive txes
...
Useful for wallet refresh or node sync
2020-02-27 15:05:34 +00:00
fcb06f7a82
cryptonote_core: skip block notify on blockchain switching rollback
2020-02-19 16:19:29 +00:00
c61abf87c0
remove empty statements
...
Cleaning up a little around the code base.
2020-02-17 11:55:15 -05:00
e3779775d7
tx_pool: catch theoretical error in get_block_reward
...
Coverity 196626
2020-02-12 21:05:28 +00:00
9bde70e567
core: mention time being off in hash rate changes message
2020-02-10 16:56:10 +00:00
e552ba14b2
Merge pull request #6127
...
67b4a19e
2020-02-06 00:33:31 -08:00
2532567091
Merge pull request #6078
...
b9fc2066
2020-02-06 00:30:15 -08:00
9a08ac98c0
Merge pull request #6050
...
65301c40
2020-02-06 00:28:18 -08:00
d7aeb5a9f8
Merge pull request #6233
...
8a27645
2020-02-04 14:38:35 -05:00
8eedc8a390
Merge pull request #6140
...
08635a08
2020-01-25 16:55:18 -08:00
d1b08c00cf
Merge pull request #6146
...
70c9cd3c
2020-01-24 20:06:34 -08:00
c4abfbfbe7
Merge pull request #6124
...
21d4c216
2020-01-16 17:31:35 -08:00
ffe7165ebf
wallet: reroll fake outs selection on local tx_sanity_check failure
2020-01-14 22:56:23 +00:00
02224e714d
Fix check_fee() discrepancy.
...
M100 = max{300kb, min{100block_median, m_long_term_effective_median_block_weight}}
not
M100 = max{300kb, m_long_term_effective_median_block_weight}
Fix base reward in get_dynamic_base_fee_estimate().
get_dynamic_base_fee_estimate() should match check_fee()
Fee is calculated based on block reward, and the reward penalty takes into account 0.5*max_block_weight (both before and after HF_VERSION_EFFECTIVE_SHORT_TERM_MEDIAN_IN_PENALTY).
Moved median calculation according to best practice of 'keep definitions close to where they are used'.
2020-01-09 09:11:09 -06:00
8a276451b2
blockchain: fix flushing txes from the txpool
2019-12-14 02:13:39 +00:00
e5cc6d39a9
Merge pull request #6055
...
886ed25
2019-12-12 13:47:04 -06:00
fb64463c4c
Merge pull request #6052
...
c96b7ee
2019-12-12 13:44:50 -06:00
987c3139dc
print_coinbase_tx_sum now supports 128 bits sums
...
The tail emission will bring the total above 64 bits
2019-12-12 01:56:59 +00:00
5985c5afe8
rpc: add bad-blocks to flush_cache RPC
...
Flushes m_invalid_blocks in Blockchain.
2019-12-02 18:53:30 +00:00
08635a0875
blockchain: speedup fetching pruned contiguous tx blobs
...
About twice as fast, very roughly
2019-11-15 13:23:30 +00:00
67b4a19edf
simplewallet: noob-friendly help menu
2019-11-13 10:24:10 +03:00
21d4c21619
blockchain: error out if the builtin hashes data size is wrong
2019-11-12 12:43:08 +00:00
70c9cd3c9c
Change to Tx diffusion (Dandelion++ fluff) instead of flooding
2019-11-04 09:23:20 +00:00
5d7ae2d279
Adding support for hidden (anonymity) txpool
2019-11-02 20:36:03 +00:00
eaadbbdab0
Merge pull request #6079
...
e4d1674e8
2019-11-02 17:31:22 +02:00
e4d1674e8c
0.15.0.0 release engineering
2019-11-02 17:21:52 +02:00
b9fc206660
Add a --keep-fakechain option to keep fakechain databases
...
This is handy when doing tests that generate a lot of transactions, since that
takes time it's preferable to re-use the database for future runs.
2019-11-01 23:56:08 +01:00
ebc6ce44f4
cryptonote: untangle dependency from miner to blockchain
...
It causes link errors at least on mac
2019-10-31 01:06:42 +00:00
886ed25055
blockchain: fix comment wrongly refering to SHA-3 rather than Keccak
2019-10-29 11:37:08 +00:00
c96b7ee619
tx_pool: fix error message assuming incorrectly
2019-10-29 10:43:59 +00:00
65301c406e
core: point out when we hit the block rate visibility limit
2019-10-28 16:06:15 +00:00
eb16755083
blockchain: fix unwanted error when probing the pool for a tx
2019-10-27 19:23:25 +00:00
07c6789148
Merge pull request #5958
...
d25acd734f28a7235b94e#5835 (export view key) (clashm)
32febd2
2019-10-25 16:03:24 -05:00
86d085e988
Merge pull request #6028
...
174a6ac
2019-10-25 14:29:15 -05:00
a4dc575ccb
rpc: add a flush_cache RPC
...
This allows flushing internal caches (for now, the bad tx cache,
which will allow debugging a stuck monerod after it has failed to
verify a transaction in a block, since it would otherwise not try
again, making subsequent log changes pointless)
2019-10-25 18:41:54 +00:00
174a6ac9c5
tx_pool: fix divide by 0 in log
...
Coverity 205394
2019-10-25 16:56:55 +00:00
4233d88341
Merge pull request #5973
...
abd3763
2019-10-22 10:54:46 -05:00
426d2ac8ee
Merge pull request #5981
...
88c9d90fe443bb1ba9baf
2019-10-22 10:18:28 -05:00
cf2d4d9a16
Merge pull request #5974
...
7fcd0b5
2019-10-22 10:13:34 -05:00
8bb3c6a8e6
Merge pull request #5970
...
ab96181
2019-10-22 10:09:56 -05:00
84ce43a239
Merge pull request #5966
...
be82c40
2019-10-22 10:08:32 -05:00
6f202844b5
Merge pull request #5919
...
01f660f
2019-10-22 10:06:10 -05:00
be82c40703
Support median block size > 4 GB
...
add a 128/64 division routine so we can use a > 32 bit median block
size in calculations
2019-10-21 10:41:07 +00:00
461a25e1b5
Merge pull request #5962
...
ec14abd
2019-10-16 13:51:34 -05:00
7fcd0b55ea
blockchain: initialize pow to ff..ff
...
as a safety to reject if it somehow does not get initialised
2019-10-16 09:00:30 +00:00
37a72fd6ae
Merge pull request #5941
...
d37d30f
2019-10-14 18:11:13 -05:00
dc48cdc998
Merge pull request #5933
...
3455efa
2019-10-14 18:07:54 -05:00
ab96181e91
blockchain: use effective median block weight for penalty from v12
...
It was using the raw block weight median, which was not what was
intended in ArticMine's design
2019-10-11 14:16:09 +00:00
1ba9bafd33
tx_pool: do not divide by 0
...
In case of a 0 tx weight, we use a placeholder value to insert in the
fee-per-byte set. This is used for pruning and mining, and those txes
are pruned, so will not be too large, nor added to the block template
if mining, so this is safe.
CID 204465
2019-10-11 14:09:31 +00:00
fe443bbdec
cryptonote: don't leave block_weight uninitialized
...
CID 204467
2019-10-11 14:09:31 +00:00
luigi1111
mj-xmr
moneromooo-monero
Kevin Barbour
Lee Clagett
Alexander Blair
xiphon
SChernykh
Nathan Dorfman
selsta
Riccardo Spagni
rbrunner7
stoffu
SomaticFanatic
Sumo Gr
cslashm
Aaron Hook
Interchained
UkoeHB
wowario
JamesWrigley