From 495a7e5b97b3795ac598e699a659f50ec0d9a313 Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Mon, 27 May 2019 14:14:11 +0000 Subject: [PATCH] rpc: don't include an address in mining_status when not mining Best case is an address mined previously and it'll get returned, worst case it was never initialized in the first place --- src/rpc/core_rpc_server.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/rpc/core_rpc_server.cpp b/src/rpc/core_rpc_server.cpp index 1fc4b816f..ce359aae6 100644 --- a/src/rpc/core_rpc_server.cpp +++ b/src/rpc/core_rpc_server.cpp @@ -1004,7 +1004,8 @@ namespace cryptonote res.block_reward = lMiner.get_block_reward(); } const account_public_address& lMiningAdr = lMiner.get_mining_address(); - res.address = get_account_address_as_str(nettype(), false, lMiningAdr); + if (lMiner.is_mining() || lMiner.get_is_background_mining_enabled()) + res.address = get_account_address_as_str(nettype(), false, lMiningAdr); const uint8_t major_version = m_core.get_blockchain_storage().get_current_hard_fork_version(); const unsigned variant = major_version >= 7 ? major_version - 6 : 0; switch (variant)