From 4be870c50b884a4e6017605d7efde8be22bd896e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Sa=C5=82aban?= Date: Thu, 11 Jan 2018 03:12:08 +0100 Subject: [PATCH] Fix method signature mismatch in subclass --- monero/address.py | 2 +- tests/address.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/monero/address.py b/monero/address.py index df78b2c..33cd96b 100644 --- a/monero/address.py +++ b/monero/address.py @@ -63,7 +63,7 @@ class Address(object): class SubAddress(Address): _valid_netbytes = (42, 63) - def with_payment_id(self): + def with_payment_id(self, _): raise TypeError("SubAddress cannot be integrated with payment ID") diff --git a/tests/address.py b/tests/address.py index 4604b30..793b69a 100644 --- a/tests/address.py +++ b/tests/address.py @@ -78,6 +78,8 @@ class Tests(object): a = Address(self.addr) self.assertRaises(TypeError, a.with_payment_id, 2**64+1) self.assertRaises(TypeError, a.with_payment_id, "%x" % (2**64+1)) + s = SubAddress(self.subaddr) + self.assertRaises(TypeError, s.with_payment_id, 0) def test_type_mismatch(self): self.assertRaises(ValueError, Address, self.iaddr)