c8f644ec44
The Gallium pipe video "frame_num" variable is internally used as a counter of elapsed reference frames since the last IDR. The incoming frame_num field from VA picture parameters is not equivalent; the VA value may wrap to zero prematurely, as it is a 16-bit struct field with a documented max value of 2^(log2_max_frame_num_minus4 + 4)-1. This change improves "infinite GOP" single-client live streaming, where it is reasonable for the server to desire an endless series of P-frames without IDR. Without this change, it is difficult/impossible for an application to encode a P- or B-frame after the VA frame_num field wraps around to zero, depending on the backend encoder implementation. This change has no effect on existing applications that always signal an IDR frame and reset the VA frame_num to zero before it wraps around. For example, the FFmpeg vaapi encoder ignores the VA documentation and sends an un-wrapped VA frame_num, which results in identical computation of the internal frame_num (as long as each GOP is less than 65536 frames). Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5768 Reviewed-by: Thong Thai <thong.thai@amd.com> patch revision 3: correctly avoid incrementing frame_num when the encoded frame is not a reference, per h264 spec and ffmpeg behavior Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14332> |
||
|---|---|---|
| .. | ||
| clover | ||
| d3d10umd | ||
| dri | ||
| glx/xlib | ||
| hgl | ||
| lavapipe | ||
| nine | ||
| omx | ||
| osmesa | ||
| va | ||
| vdpau | ||
| wgl | ||
| xa | ||
| xvmc | ||