KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

radv: simplify re-using cache entries in radv_pipeline_cache_insert_shaders() 

If entry->shaders[i] is NULL, shaders[i] should be also NULL, so the
else condition is a no-op.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13823>
This commit is contained in:
Samuel Pitoiset 2021-11-16 19:07:55 +01:00
parent 836a4b5836
commit ffbad81305
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/amd/vulkan/radv_pipeline_cache.c
View File

@ -402,14 +402,13 @@ radv_pipeline_cache_insert_shaders(struct radv_device *device, struct radv_pipel
struct cache_entry *entry = radv_pipeline_cache_search_unlocked(cache, sha1);
if (entry) {
for (int i = 0; i < MESA_VULKAN_SHADER_STAGES; ++i) {
if (entry->shaders[i]) {
radv_shader_destroy(cache->device, shaders[i]);
shaders[i] = entry->shaders[i];
} else {
entry->shaders[i] = shaders[i];
}
if (shaders[i])
p_atomic_inc(&shaders[i]->ref_count);
if (!entry->shaders[i])
continue;
radv_shader_destroy(cache->device, shaders[i]);
shaders[i] = entry->shaders[i];
p_atomic_inc(&shaders[i]->ref_count);
}
radv_pipeline_cache_unlock(cache);
return;