From fc9f0db8e3ab04ee9a529ccd36fd8b2f6cbb47dd Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Wed, 1 Feb 2017 14:34:27 -0800 Subject: [PATCH] intel/isl: Assert that we don't use CCS for storage images MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I enabled CCS for storage images in the Vulkan driver and ran it through the CTS. It didn't result in any hangs but it demonstrated that the data port cannot handle CCS. Reviewed-by: Samuel Iglesias Gonsálvez Reviewed-by: Chad Versace Reviewed-by: Anuj Phogat --- src/intel/isl/isl_surface_state.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index c7b220b73fb..29ec289a5d9 100644 --- a/src/intel/isl/isl_surface_state.c +++ b/src/intel/isl/isl_surface_state.c @@ -537,6 +537,12 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state, #if GEN_GEN >= 7 if (info->aux_surf && info->aux_usage != ISL_AUX_USAGE_NONE) { + /* The docs don't appear to say anything whatsoever about compression + * and the data port. Testing seems to indicate that the data port + * completely ignores the AuxiliarySurfaceMode field. + */ + assert(!(info->view->usage & ISL_SURF_USAGE_STORAGE_BIT)); + struct isl_tile_info tile_info; isl_surf_get_tile_info(dev, info->aux_surf, &tile_info); uint32_t pitch_in_tiles =