KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i965: Don't emit saturates for instructions without destinations. 

We were special casing OPCODE_END but no other instructions that have no
destination, like OPCODE_KIL, leading us to emitting MOVs with null
destinations.

total instructions in shared programs: 5705243 -> 5701539 (-0.06%)
instructions in affected programs:     124104 -> 120400 (-2.98%)
helped:                                904

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
This commit is contained in:
Matt Turner 2015-02-09 22:21:21 -08:00
parent 7f8dd91d16
commit f8b435ae6a
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mesa/drivers/dri/i965/brw_fs_fp.cpp
View File

@ -522,7 +522,7 @@ fs_visitor::emit_fragment_program_code()
/* To handle saturates, we emit a MOV with a saturate bit, which
* optimization should fold into the preceding instructions when safe.
*/
if (fpi->Opcode != OPCODE_END) {
if (_mesa_num_inst_dst_regs(fpi->Opcode) != 0) {
fs_reg real_dst = get_fp_dst_reg(&fpi->DstReg);
for (int i = 0; i < 4; i++) {

2
src/mesa/drivers/dri/i965/brw_vec4_vp.cpp
View File

@ -386,7 +386,7 @@ vec4_vs_visitor::emit_program_code()
}
/* Copy the temporary back into the actual destination register. */
if (vpi->Opcode != OPCODE_END) {
if (_mesa_num_inst_dst_regs(vpi->Opcode) != 0) {
emit(MOV(get_vp_dst_reg(vpi->DstReg), src_reg(dst)));
}
}