diff --git a/README.rst b/README.rst index 4ccd72eca38..9e44d78f7d2 100644 --- a/README.rst +++ b/README.rst @@ -56,5 +56,4 @@ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.html `_). -Note that Mesa uses email mailing-lists for patches submission, review and -discussions. +Note that Mesa uses gitlab for patches submission, review and discussions. diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 9058b065d95..403f4295e78 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -42,9 +42,7 @@ components. git bisect.)
  • Patches should be properly formatted.
  • Patches should be sufficiently tested before submitting. -
  • Patches should be submitted -to mesa-dev or with -a merge request +
  • Patches should be submitted via a merge request for review. @@ -161,67 +159,13 @@ replacing "meson test" with whatever other test you want to run.

    -

    Submitting Patches

    -Patches may be submitted to the Mesa project by -email or with a -GitLab merge request. To prevent -duplicate code review, only use one method to submit your changes. +Patches are submitted to the Mesa project via a +GitLab Merge Request.

    -

    Mailing Patches

    - -

    -Patches may be sent to the mesa-dev mailing list for review: - -mesa-dev@lists.freedesktop.org. -When submitting a patch make sure to use -git send-email -rather than attaching patches to emails. Sending patches as -attachments prevents people from being able to provide in-line review -comments. -

    - -

    -When submitting follow-up patches you can use --in-reply-to to make v2, v3, -etc patches show up as replies to the originals. This usually works well -when you're sending out updates to individual patches (as opposed to -re-sending the whole series). Using --in-reply-to makes -it harder for reviewers to accidentally review old patches. -

    - -

    -When submitting follow-up patches you should also login to -patchwork and change the -state of your old patches to Superseded. -

    - -

    -Some companies' mail server automatically append a legal disclaimer, -usually containing something along the lines of "The information in this -email is confidential" and "distribution is strictly prohibited". -

    -

    -These legal notices prevent us from being able to accept your patch, -rendering the whole process pointless. Please make sure these are -disabled before sending your patches. (Note that you may need to contact -your email administrator for this.) -

    - -

    GitLab Merge Requests

    - -

    - GitLab Merge - Requests (MR) can also be used to submit patches for Mesa. -

    - -

    - If the MR may have interest for most of the Mesa community, you can - send an email to the mesa-dev email list including a link to the MR. - Don't send the patch to mesa-dev, just the MR link. -

    Add labels to your MR to help reviewers find it. For example:

    @@ -270,16 +214,15 @@ your email administrator for this.)

    Reviewing Patches

    - To participate in code review, you should monitor the - - mesa-dev email list and the GitLab - Mesa Merge - Requests page. + To participate in code review, you can monitor the GitLab Mesa + Merge + Requests page, and/or register for notifications in your gitlab + settings.

    -When you've reviewed a patch on the mailing list, please be unambiguous -about your review. That is, state either +When you've reviewed a patch, please be unambiguous about your review. + That is, state either 

         Reviewed-by: Joe Hacker <jhacker@foo.com>