KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gallivm: Prevent disassembly debug output from being truncated. 

By using os_log_message directly, as _debug_vprintf truncates messages
to 4K.

Also cleanup the disassemble interface.

Spotted by Roland.

Trivial.
This commit is contained in:
Jose Fonseca 2016-04-01 21:17:18 +01:00
parent 972054f5bf
commit f72de6f386
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
View File

@ -128,7 +128,7 @@ lp_debug_dump_value(LLVMValueRef value)
* - http://blog.llvm.org/2010/04/intro-to-llvm-mc-project.html * - http://blog.llvm.org/2010/04/intro-to-llvm-mc-project.html
*/ */
static size_t static size_t
disassemble(const void* func, std::stringstream &buffer) disassemble(const void* func, std::ostream &buffer)
{ {
const uint8_t *bytes = (const uint8_t *)func; const uint8_t *bytes = (const uint8_t *)func;
@ -235,15 +235,16 @@ disassemble(const void* func, std::stringstream &buffer)
extern "C" void extern "C" void
lp_disassemble(LLVMValueRef func, const void *code) { lp_disassemble(LLVMValueRef func, const void *code)
std::stringstream buffer; {
std::ostringstream buffer;
std::string s; std::string s;
buffer << LLVMGetValueName(func) << ":\n"; buffer << LLVMGetValueName(func) << ":\n";
disassemble(code, buffer); disassemble(code, buffer);
s = buffer.str(); s = buffer.str();
_debug_printf("%s", s.c_str()); os_log_message(s.c_str());
_debug_printf("\n"); os_log_message("\n");
} }
@ -259,7 +260,6 @@ extern "C" void
lp_profile(LLVMValueRef func, const void *code) lp_profile(LLVMValueRef func, const void *code)
{ {
#if defined(__linux__) && defined(PROFILE) #if defined(__linux__) && defined(PROFILE)
std::stringstream buffer;
static std::ofstream perf_asm_file; static std::ofstream perf_asm_file;
static boolean first_time = TRUE; static boolean first_time = TRUE;
static FILE *perf_map_file = NULL; static FILE *perf_map_file = NULL;
@ -283,9 +283,9 @@ lp_profile(LLVMValueRef func, const void *code)
if (perf_map_file) { if (perf_map_file) {
const char *symbol = LLVMGetValueName(func); const char *symbol = LLVMGetValueName(func);
unsigned long addr = (uintptr_t)code; unsigned long addr = (uintptr_t)code;
buffer << symbol << ":\n"; perf_asm_file << symbol << ":\n";
unsigned long size = disassemble(code, buffer); unsigned long size = disassemble(code, perf_asm_file);
perf_asm_file << buffer.rdbuf() << std::flush; perf_asm_file.flush();
fprintf(perf_map_file, "%lx %lx %s\n", addr, size, symbol); fprintf(perf_map_file, "%lx %lx %s\n", addr, size, symbol);
fflush(perf_map_file); fflush(perf_map_file);
} }