KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nir: assert that variables in optimize_atomic are initialized 

If you gonna view context of function parse_atomic_op,
then you gonna know that index for array (data_src)
can be unitialized. Imho this approach is cleaner
than doing stuff inside parse_atomic_op.

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12995>
This commit is contained in:
Filip Gawin 2021-09-16 00:19:22 +02:00 committed by Marge Bot
parent fbd61d2b02
commit f32dcb6fe1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/compiler/nir/nir_opt_uniform_atomics.c
View File

@ -194,7 +194,8 @@ reduce_data(nir_builder *b, nir_op op, nir_ssa_def *data,
static nir_ssa_def *
optimize_atomic(nir_builder *b, nir_intrinsic_instr *intrin, bool return_prev)
{
unsigned offset_src, data_src;
unsigned offset_src = 0;
unsigned data_src = 0;
nir_op op = parse_atomic_op(intrin->intrinsic, &offset_src, &data_src);
nir_ssa_def *data = intrin->src[data_src].ssa;