KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lavapipe: Fix crashes with transform feedback when using VK_WHOLE_SIZE 

llvmpipe expects valid size parameter, and when just VK_WHOLE_SIZE is
passed very bad things can happen.
This was handled specially before, but got dropped when lavapipe was
converted to use the generated command queue.

Fixes: eb7eccc76f ("lavapipe: Use generated command queue code")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13036>
This commit is contained in:
Roland Scheidegger 2021-09-24 17:57:05 +02:00 committed by Marge Bot
parent e24ef5d914
commit f2d76a576d
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/gallium/frontends/lavapipe/lvp_execute.c
View File

@ -3350,13 +3350,19 @@ static void handle_bind_transform_feedback_buffers(struct vk_cmd_queue_entry *cm
for (unsigned i = 0; i < btfb->binding_count; i++) {
int idx = i + btfb->first_binding;
uint32_t size;
if (btfb->sizes && btfb->sizes[i] != VK_WHOLE_SIZE)
size = btfb->sizes[i];
else
size = lvp_buffer_from_handle(btfb->buffers[i])->size - btfb->offsets[i];
if (state->so_targets[idx])
state->pctx->stream_output_target_destroy(state->pctx, state->so_targets[idx]);
state->so_targets[idx] = state->pctx->create_stream_output_target(state->pctx,
lvp_buffer_from_handle(btfb->buffers[i])->bo,
btfb->offsets[i],
btfb->sizes[i]);
size);
}
state->num_so_targets = btfb->first_binding + btfb->binding_count;
}