KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

panfrost: Remove vertex buffer offset from its size 

The offset is added to the base address, so we need to subtract it from
the size to maintain the same end address and thus prevent a buffer
overflow:

   end_address = start_address + size

   start_address' = start_address + offset
   size' = size - offset

   end_address' = start_address' + size'
                = (start_address + offset) + (size - offset)
                = (start_address + size) + (offset - offset)
                = start_address + size
                = end_address

   QED.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
This commit is contained in:
Alyssa Rosenzweig 2019-08-22 08:02:52 -07:00
parent f4678f3c62
commit eeebf5c2df
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/gallium/drivers/panfrost/pan_instancing.c
View File

@ -292,7 +292,7 @@ panfrost_emit_vertex_data(struct panfrost_job *batch)
* will be adjusted back when we fixup the src_offset in
* mali_attr_meta */
mali_ptr raw_addr = panfrost_vertex_buffer_address(ctx, vbi);
mali_ptr raw_addr = rsrc->bo->gpu + buf->buffer_offset;
mali_ptr addr = raw_addr & ~63;
unsigned chopped_addr = raw_addr - addr;
@ -302,7 +302,10 @@ panfrost_emit_vertex_data(struct panfrost_job *batch)
/* Set common fields */
attrs[k].elements = addr;
attrs[k].stride = buf->stride;
attrs[k].size = rsrc->base.width0;
/* Since we advanced the base pointer, we shrink the buffer
* size */
attrs[k].size = rsrc->base.width0 - buf->buffer_offset;
/* We need to add the extra size we masked off (for
* correctness) so the data doesn't get clamped away */