KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ir3: prohibit folding of half->full conversion into mul.s24/u24 

mul.s24/u24 always return 32b result regardless of its sources size,
hence we cannot guarantee the high 16b of dst being zero or sign extended.

Fixes cts tests on a650:
 dEQP-VK.spirv_assembly.type.scalar.i16.mul_test_high_part_zero_*

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12471>
This commit is contained in:
Danylo Piliaiev 2021-08-19 14:53:23 +03:00 committed by Marge Bot
parent 10bf0c51d4
commit ee9f0e78c1
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/freedreno/ir3/ir3_cf.c
View File

@ -38,6 +38,13 @@ is_safe_conv(struct ir3_instruction *instr, type_t src_type, opc_t *src_opc)
full_type(instr->cat1.src_type) != full_type(instr->cat1.dst_type))
return false;
/* mul.s24/u24 always return 32b result regardless of its sources size,
* hence we cannot guarantee the high 16b of dst being zero or sign extended.
*/
if ((*src_opc == OPC_MUL_S24 || *src_opc == OPC_MUL_U24) &&
type_size(instr->cat1.src_type) == 16)
return false;
struct ir3_register *dst = instr->dsts[0];
struct ir3_register *src = instr->srcs[0];