KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel/fs,vec4: remove unused assignments 

Reported by Coverity.

Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6126>
This commit is contained in:
Marcin Ślusarz 2020-07-30 16:32:16 +02:00 committed by Marge Bot
parent 8e8356e3dc
commit ed9ac3d60c
2 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/intel/compiler/brw_fs_nir.cpp
View File

@ -1030,10 +1030,10 @@ fs_visitor::nir_emit_alu(const fs_builder &bld, nir_alu_instr *instr,
continue; continue;
if (instr->op == nir_op_mov) { if (instr->op == nir_op_mov) {
inst = bld.MOV(offset(temp, bld, i), bld.MOV(offset(temp, bld, i),
offset(op[0], bld, instr->src[0].swizzle[i])); offset(op[0], bld, instr->src[0].swizzle[i]));
} else { } else {
inst = bld.MOV(offset(temp, bld, i), bld.MOV(offset(temp, bld, i),
offset(op[i], bld, instr->src[i].swizzle[0])); offset(op[i], bld, instr->src[i].swizzle[0]));
} }
} }

13
src/intel/compiler/brw_vec4_nir.cpp
View File

@ -2203,32 +2203,29 @@ vec4_visitor::shuffle_64bit_data(dst_reg dst, src_reg src, bool for_write,
vec4_builder(this).at(block, ref->next); vec4_builder(this).at(block, ref->next);
/* Resolve swizzle in src */ /* Resolve swizzle in src */
vec4_instruction *inst;
if (src.swizzle != BRW_SWIZZLE_XYZW) { if (src.swizzle != BRW_SWIZZLE_XYZW) {
dst_reg data = dst_reg(this, glsl_type::dvec4_type); dst_reg data = dst_reg(this, glsl_type::dvec4_type);
inst = bld.MOV(data, src); bld.MOV(data, src);
src = src_reg(data); src = src_reg(data);
} }
/* dst+0.XY = src+0.XY */ /* dst+0.XY = src+0.XY */
inst = bld.group(4, 0).MOV(writemask(dst, WRITEMASK_XY), src); bld.group(4, 0).MOV(writemask(dst, WRITEMASK_XY), src);
/* dst+0.ZW = src+1.XY */ /* dst+0.ZW = src+1.XY */
inst = bld.group(4, for_write ? 1 : 0) bld.group(4, for_write ? 1 : 0)
.MOV(writemask(dst, WRITEMASK_ZW), .MOV(writemask(dst, WRITEMASK_ZW),
swizzle(byte_offset(src, REG_SIZE), BRW_SWIZZLE_XYXY)); swizzle(byte_offset(src, REG_SIZE), BRW_SWIZZLE_XYXY));
/* dst+1.XY = src+0.ZW */ /* dst+1.XY = src+0.ZW */
inst = bld.group(4, for_write ? 0 : 1) bld.group(4, for_write ? 0 : 1)
.MOV(writemask(byte_offset(dst, REG_SIZE), WRITEMASK_XY), .MOV(writemask(byte_offset(dst, REG_SIZE), WRITEMASK_XY),
swizzle(src, BRW_SWIZZLE_ZWZW)); swizzle(src, BRW_SWIZZLE_ZWZW));
/* dst+1.ZW = src+1.ZW */ /* dst+1.ZW = src+1.ZW */
inst = bld.group(4, 1) return bld.group(4, 1)
.MOV(writemask(byte_offset(dst, REG_SIZE), WRITEMASK_ZW), .MOV(writemask(byte_offset(dst, REG_SIZE), WRITEMASK_ZW),
byte_offset(src, REG_SIZE)); byte_offset(src, REG_SIZE));
return inst;
} }
} }