From e812cbe84738e64838e70f337b6b8e69178c0959 Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Mon, 18 Jul 2022 10:12:11 +0200 Subject: [PATCH] v3dv: remove unnecesary FIXME comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We only want to cleant BCL barrier flags if we consume a BCL barrier. For example, if the client records a barrier for an index buffer it should apply to the next draw call that uses an index buffer which may not be the current draw call but one coming after it. Reviewed-by: Alejandro Piñeiro Part-of: --- src/broadcom/vulkan/v3dv_cmd_buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/broadcom/vulkan/v3dv_cmd_buffer.c b/src/broadcom/vulkan/v3dv_cmd_buffer.c index 8dc819006b6..4daef8e3c06 100644 --- a/src/broadcom/vulkan/v3dv_cmd_buffer.c +++ b/src/broadcom/vulkan/v3dv_cmd_buffer.c @@ -2553,7 +2553,6 @@ v3dv_cmd_buffer_emit_pre_draw(struct v3dv_cmd_buffer *cmd_buffer, indexed, indirect)) { consume_bcl_sync(cmd_buffer, job); } - /* FIXME: clear bc flags whether consumed bcl barrier or not? */ } /* GL shader state binds shaders, uniform and vertex attribute state. The