KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nir: Fix flat new_var assignment in create_new_io_vars() 

If the type is not an array, glsl_get_length() returns 0 and we don't
update the new_vars[]/flat_vars[] entries.

Fixes: bcd14756ee ("nir/lower_io_to_vector: add flat mode")
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16960>
This commit is contained in:
Boris Brezillon 2022-02-16 16:55:36 +01:00 committed by Marge Bot
parent b12417a2c7
commit d9ec7df2f4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/compiler/nir/nir_lower_io_to_vector.c
View File

@ -304,7 +304,8 @@ create_new_io_vars(nir_shader *shader, nir_variable_mode mode,
var->type = flat_type;
nir_shader_add_variable(shader, var);
for (unsigned i = 0; i < glsl_get_length(flat_type); i++) {
unsigned num_slots = MAX2(glsl_get_length(flat_type), 1);
for (unsigned i = 0; i < num_slots; i++) {
for (unsigned j = 0; j < 4; j++)
new_vars[loc + i][j] = var;
flat_vars[loc + i] = true;