KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pan/bi: Remove liveness metadata tracking 

We don't use it for anything, and with no pass infrastructure it's just an
accident waiting to happen.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16585>
This commit is contained in:
Alyssa Rosenzweig 2022-05-11 17:12:13 -04:00 committed by Marge Bot
parent 3df5446cbd
commit d81b872465
5 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/panfrost/bifrost/bi_liveness.c
View File

@ -91,9 +91,6 @@ liveness_block_update(bi_block *blk, unsigned temp_count)
void
bi_compute_liveness(bi_context *ctx)
{
if (ctx->has_liveness)
return;
unsigned temp_count = bi_max_temp(ctx);
u_worklist worklist;
@ -126,14 +123,4 @@ bi_compute_liveness(bi_context *ctx)
}
u_worklist_fini(&worklist);
ctx->has_liveness = true;
}
/* Once liveness data is no longer valid, call this */
void
bi_invalidate_liveness(bi_context *ctx)
{
ctx->has_liveness = false;
}

1
src/panfrost/bifrost/bi_opt_dce.c
View File

@ -32,7 +32,6 @@ bi_opt_dead_code_eliminate(bi_context *ctx)
{
unsigned temp_count = bi_max_temp(ctx);
bi_invalidate_liveness(ctx);
bi_compute_liveness(ctx);
bi_foreach_block_rev(ctx, block) {

2
src/panfrost/bifrost/bi_ra.c
View File

@ -780,7 +780,6 @@ bi_register_allocate(bi_context *ctx)
/* Try with reduced register pressure to improve thread count */
if (ctx->arch >= 7) {
bi_invalidate_liveness(ctx);
l = bi_allocate_registers(ctx, &success, false);
if (success) {
@ -793,7 +792,6 @@ bi_register_allocate(bi_context *ctx)
/* Otherwise, use the register file and spill until we succeed */
while (!success && ((iter_count--) > 0)) {
bi_invalidate_liveness(ctx);
l = bi_allocate_registers(ctx, &success, true);
if (success) {

1
src/panfrost/bifrost/bi_validate.c
View File

@ -40,7 +40,6 @@ bi_validate_initialization(bi_context *ctx)
/* Calculate the live set */
bi_block *entry = bi_entry_block(ctx);
unsigned temp_count = bi_max_temp(ctx);
bi_invalidate_liveness(ctx);
bi_compute_liveness(ctx);
/* Validate that the live set is indeed empty */

4
src/panfrost/bifrost/compiler.h
View File

@ -763,9 +763,6 @@ typedef struct {
unsigned ssa_alloc;
unsigned reg_alloc;
/* Analysis results */
bool has_liveness;
/* Mask of UBOs that need to be uploaded */
uint32_t ubo_mask;
@ -1087,7 +1084,6 @@ bool bi_opt_constant_fold(bi_context *ctx);
void bi_compute_liveness(bi_context *ctx);
void bi_liveness_ins_update(uint8_t *live, bi_instr *ins, unsigned max);
void bi_invalidate_liveness(bi_context *ctx);
void bi_postra_liveness(bi_context *ctx);
uint64_t bi_postra_liveness_ins(uint64_t live, bi_instr *ins);