From d1c6185b5a1055bde0a5ac51b20e4af7863dc64d Mon Sep 17 00:00:00 2001 From: Guilherme Gallo Date: Fri, 21 Jan 2022 02:43:03 -0300 Subject: [PATCH] ci: skqp: Add Vulkan support for a630_skqp job This commit adds support for Vulkan backend on a630_skqp job. = Needed changes - Needed to install libvulkan-dev package on system - Refactored the way the available skqp reports are printed tested in development builds with skia tools Piglit expectations had to be updated in various drivers due to !14750 not having bumped the tags when it tried to uprev. Signed-off-by: Guilherme Gallo Reviewed-by: Emma Anholt Part-of: --- .gitlab-ci/container/create-rootfs.sh | 1 + .gitlab-ci/image-tags.yml | 2 +- .gitlab-ci/skqp-runner.sh | 70 ++- src/broadcom/ci/broadcom-rpi4-fails.txt | 2 + src/freedreno/ci/freedreno-a307-fails.txt | 1 + src/freedreno/ci/freedreno-a530-fails.txt | 18 + src/freedreno/ci/freedreno-a530-flakes.txt | 6 + src/freedreno/ci/freedreno-a630-fails.txt | 4 + .../ci/freedreno-a630-skqp_unittests.txt | 409 +++--------------- src/freedreno/ci/gitlab-ci.yml | 4 +- .../drivers/i915/ci/i915-g33-fails.txt | 6 - .../drivers/i915/ci/i915-g33-flakes.txt | 1 + .../drivers/iris/ci/iris-kbl-fails.txt | 4 + .../radeonsi/ci/radeonsi-stoney-fails.txt | 26 ++ 14 files changed, 175 insertions(+), 379 deletions(-) create mode 100644 src/gallium/drivers/i915/ci/i915-g33-flakes.txt diff --git a/.gitlab-ci/container/create-rootfs.sh b/.gitlab-ci/container/create-rootfs.sh index 3065f233215..f3468fef634 100644 --- a/.gitlab-ci/container/create-rootfs.sh +++ b/.gitlab-ci/container/create-rootfs.sh @@ -7,6 +7,7 @@ if [ $DEBIAN_ARCH = arm64 ]; then libfontconfig1 libgl1 libglu1-mesa + libvulkan-dev " elif [ $DEBIAN_ARCH = amd64 ]; then ARCH_PACKAGES="firmware-amd-graphics diff --git a/.gitlab-ci/image-tags.yml b/.gitlab-ci/image-tags.yml index 96d02846620..68ed17b9483 100644 --- a/.gitlab-ci/image-tags.yml +++ b/.gitlab-ci/image-tags.yml @@ -12,7 +12,7 @@ variables: DEBIAN_X86_TEST_VK_TAG: "2022-02-21-libdrm" FEDORA_X86_BUILD_TAG: "2022-02-21-libdrm" - KERNEL_ROOTFS_TAG: "2022-02-21-libdrm" + KERNEL_ROOTFS_TAG: "2022-02-23-skqp" WINDOWS_X64_BUILD_PATH: "windows/x64_build" WINDOWS_X64_BUILD_TAG: "2022-20-02-base_split" diff --git a/.gitlab-ci/skqp-runner.sh b/.gitlab-ci/skqp-runner.sh index cde0af4cf91..68aca2d3377 100755 --- a/.gitlab-ci/skqp-runner.sh +++ b/.gitlab-ci/skqp-runner.sh @@ -22,13 +22,19 @@ # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE # SOFTWARE. + copy_tests_files() ( + # Copy either unit test or render test files from a specific driver given by + # GPU VERSION variable. + # If there is no test file at the expected location, this function will + # return error_code 1 SKQP_BACKEND="${1}" SKQP_FILE_PREFIX="${INSTALL}/${GPU_VERSION}-skqp" - if echo "${SKQP_BACKEND}" | grep -qE 'gl(es)?' + if echo "${SKQP_BACKEND}" | grep -qE 'vk|gl(es)?' then SKQP_RENDER_TESTS_FILE="${SKQP_FILE_PREFIX}-${SKQP_BACKEND}_rendertests.txt" + [ -f "${SKQP_RENDER_TESTS_FILE}" ] || return 1 cp "${SKQP_RENDER_TESTS_FILE}" "${SKQP_ASSETS_DIR}"/skqp/rendertests.txt return 0 fi @@ -37,37 +43,75 @@ copy_tests_files() ( # that is why it needs to be a special case. if echo "${SKQP_BACKEND}" | grep -qE "unitTest" then - cp "${SKQP_FILE_PREFIX}_unittests.txt" "${SKQP_ASSETS_DIR}"/skqp/unittests.txt + SKQP_UNIT_TESTS_FILE="${SKQP_FILE_PREFIX}_unittests.txt" + [ -f "${SKQP_UNIT_TESTS_FILE}" ] || return 1 + cp "${SKQP_UNIT_TESTS_FILE}" "${SKQP_ASSETS_DIR}"/skqp/unittests.txt fi ) +test_vk_backend() { + if echo "${SKQP_BACKENDS}" | grep -qE 'vk' + then + if [ -n "$VK_DRIVER" ]; then + return 0 + fi + + echo "VK_DRIVER environment variable is missing." + VK_DRIVERS=$(ls "$INSTALL"/share/vulkan/icd.d/ | cut -f 1 -d '_') + if [ -n "${VK_DRIVERS}" ] + then + echo "Please set VK_DRIVER to the correct driver from the list:" + echo "${VK_DRIVERS}" + fi + echo "No Vulkan tests will be executed, but it was requested in SKQP_BACKENDS variable. Exiting." + exit 2 + fi + + # Vulkan environment is not configured, but it was not requested by the job + return 1 +} + +setup_backends() { + if test_vk_backend + then + export VK_ICD_FILENAMES="$INSTALL"/share/vulkan/icd.d/"$VK_DRIVER"_icd."${VK_CPU:-$(uname -m)}".json + fi +} + set -ex # Needed so configuration files can contain paths to files in /install ln -sf "$CI_PROJECT_DIR"/install /install - INSTALL=${PWD}/install if [ -z "$GPU_VERSION" ]; then - echo 'GPU_VERSION must be set to something like "llvmpipe" or "freedreno-a630" (the name used in .gitlab-ci/gpu-version-*.txt)' + echo 'GPU_VERSION must be set to something like "llvmpipe" or +"freedreno-a630" (it will serve as a component to find the path for files +residing in src/**/ci/*.txt)' exit 1 fi -SKQP_ASSETS_DIR=/skqp/assets -SKQP_RESULTS_DIR="${SKQP_RESULTS_DIR:-results}" +LD_LIBRARY_PATH=$INSTALL:$LD_LIBRARY_PATH +setup_backends -mkdir "${SKQP_ASSETS_DIR}"/skqp +SKQP_ASSETS_DIR=/skqp/assets +SKQP_RESULTS_DIR="${SKQP_RESULTS_DIR:-$PWD/results}" + +mkdir -p "${SKQP_ASSETS_DIR}"/skqp SKQP_EXITCODE=0 for SKQP_BACKEND in ${SKQP_BACKENDS} do set -e - copy_tests_files "${SKQP_BACKEND}" + if ! copy_tests_files "${SKQP_BACKEND}" + then + echo "No override test file found for ${SKQP_BACKEND}. Using the default one." + fi set +e SKQP_BACKEND_RESULTS_DIR="${SKQP_RESULTS_DIR}"/"${SKQP_BACKEND}" mkdir -p "${SKQP_BACKEND_RESULTS_DIR}" - /skqp/skqp "${SKQP_ASSETS_DIR}" '' "${SKQP_BACKEND_RESULTS_DIR}" "${SKQP_BACKEND}_" + /skqp/skqp "${SKQP_ASSETS_DIR}" "${SKQP_BACKEND_RESULTS_DIR}" "${SKQP_BACKEND}_" BACKEND_EXITCODE=$? if [ ! $BACKEND_EXITCODE -eq 0 ] @@ -91,15 +135,17 @@ then echo "https://$CI_PROJECT_ROOT_NAMESPACE.pages.freedesktop.org/-/$CI_PROJECT_NAME/-/jobs/$CI_JOB_ID/artifacts/${SKQP_RESULTS_DIR}/unitTest/unit_tests.txt" fi -for REPORT in "${SKQP_RESULTS_DIR}"/**/report.html +REPORT_FILES=$(mktemp) +find "${SKQP_RESULTS_DIR}"/**/report.html -type f > "${REPORT_FILES}" +while read -r REPORT do BACKEND_NAME=$(echo "${REPORT}" | sed 's@.*/\([^/]*\)/report.html@\1@') echo "See skqp ${BACKEND_NAME} render tests report at:" echo "https://$CI_PROJECT_ROOT_NAMESPACE.pages.freedesktop.org/-/$CI_PROJECT_NAME/-/jobs/$CI_JOB_ID/artifacts/${REPORT}" -done +done < "${REPORT_FILES}" # If there is no report available, tell the user that something is wrong. -if [ ! -f "${REPORT}" ] +if [ ! -s "${REPORT_FILES}" ] then echo "No skqp report available. Probably some fatal error has occured during the skqp execution." fi diff --git a/src/broadcom/ci/broadcom-rpi4-fails.txt b/src/broadcom/ci/broadcom-rpi4-fails.txt index 93dbedbac9b..3b821904074 100644 --- a/src/broadcom/ci/broadcom-rpi4-fails.txt +++ b/src/broadcom/ci/broadcom-rpi4-fails.txt @@ -28,6 +28,7 @@ spec@!opengl 1.0@gl-1.0-no-op-paths,Fail spec@!opengl 1.0@gl-1.0-spot-light,Fail spec@!opengl 1.0@gl-1.0-user-clip-all-planes,Fail spec@!opengl 1.1@depthstencil-default_fb-drawpixels-24_8 samples=2,Fail +spec@!opengl 1.1@depthstencil-default_fb-drawpixels-24_8 samples=4,Fail spec@!opengl 1.1@depthstencil-default_fb-drawpixels-32f_24_8_rev samples=2,Fail spec@!opengl 1.1@depthstencil-default_fb-drawpixels-32f_24_8_rev samples=4,Fail spec@!opengl 1.1@depthstencil-default_fb-drawpixels-float-and-ushort samples=2,Fail @@ -272,6 +273,7 @@ spec@glsl-1.20@compiler@invalid-vec4-array-to-vec3-array-conversion.vert,Fail spec@glsl-1.20@execution@clipping@vs-clip-vertex-primitives,Fail spec@glsl-1.20@execution@fs-underflow-mul-compare-zero,Fail spec@intel_performance_query@intel_performance_query-issue_2235,Fail +spec@khr_texture_compression_astc@basic-gles,Fail spec@khr_texture_compression_astc@miptree-gles srgb-fp,Fail spec@khr_texture_compression_astc@miptree-gles srgb-fp@sRGB decode full precision,Fail spec@khr_texture_compression_astc@sliced-3d-miptree-gles srgb-fp,Fail diff --git a/src/freedreno/ci/freedreno-a307-fails.txt b/src/freedreno/ci/freedreno-a307-fails.txt index 3cf290279f7..400800f0d7c 100644 --- a/src/freedreno/ci/freedreno-a307-fails.txt +++ b/src/freedreno/ci/freedreno-a307-fails.txt @@ -550,6 +550,7 @@ spec@glsl-1.40@execution@texturesize@vs-texturesize-usamplerbuffer,Fail spec@glsl-1.40@execution@tf-no-position,Fail spec@glsl-es-3.00@execution@varying-struct-centroid_gles3,Fail spec@intel_performance_query@intel_performance_query-issue_2235,Fail +spec@khr_texture_compression_astc@basic-gles,Fail spec@khr_texture_compression_astc@miptree-gl srgb-fp,Fail spec@khr_texture_compression_astc@miptree-gl srgb-fp@sRGB decode full precision,Fail spec@khr_texture_compression_astc@miptree-gles srgb-fp,Fail diff --git a/src/freedreno/ci/freedreno-a530-fails.txt b/src/freedreno/ci/freedreno-a530-fails.txt index 4688512cde1..08bb7267088 100644 --- a/src/freedreno/ci/freedreno-a530-fails.txt +++ b/src/freedreno/ci/freedreno-a530-fails.txt @@ -309,6 +309,18 @@ spec@ext_render_snorm@render@format 0x8f94 read fail,Fail spec@ext_render_snorm@render@format 0x8f95 read fail,Fail spec@ext_render_snorm@render@format 0x8f97 read fail,Fail spec@ext_transform_feedback2@draw-auto,Fail + +# Probably regressed with !14643 +spec@ext_transform_feedback@builtin-varyings gl_clipdistance,Fail +spec@ext_transform_feedback@builtin-varyings gl_clipdistance[1]-no-subscript,Fail +spec@ext_transform_feedback@builtin-varyings gl_clipdistance[2]-no-subscript,Fail +spec@ext_transform_feedback@builtin-varyings gl_clipdistance[3]-no-subscript,Fail +spec@ext_transform_feedback@builtin-varyings gl_clipdistance[4]-no-subscript,Fail +spec@ext_transform_feedback@builtin-varyings gl_clipdistance[5]-no-subscript,Fail +spec@ext_transform_feedback@builtin-varyings gl_clipdistance[6]-no-subscript,Fail +spec@ext_transform_feedback@builtin-varyings gl_clipdistance[7]-no-subscript,Fail +spec@ext_transform_feedback@builtin-varyings gl_clipdistance[8]-no-subscript,Fail + spec@ext_transform_feedback@generatemipmap prims_generated,Fail spec@ext_transform_feedback@immediate-reuse,Fail spec@ext_transform_feedback@immediate-reuse-index-buffer,Fail @@ -364,6 +376,11 @@ spec@ext_transform_feedback@tessellation triangles wireframe,Fail spec@glsl-1.10@execution@temp-array-indexing@glsl-fs-giant-temp-array,Fail spec@glsl-1.10@execution@temp-array-indexing@glsl-vs-giant-temp-array,Fail +# Probably regressed with !14643 +spec@glsl-1.20@execution@clipping@fixed-clip-enables,Fail +spec@glsl-1.20@execution@clipping@vs-clip-vertex-enables,Fail +spec@glsl-1.30@execution@clipping@vs-clip-distance-enables,Fail + spec@glsl-1.30@execution@texelfetch fs sampler3d 1x129x9-98x129x9,Fail spec@glsl-1.30@execution@texelfetch fs sampler3d 98x129x1-98x129x9,Fail spec@glsl-1.30@execution@texelfetch fs sampler3d 98x1x9-98x129x9,Fail @@ -374,6 +391,7 @@ spec@khr_texture_compression_astc@array-gl@5x5 Block Dim,Fail spec@khr_texture_compression_astc@array-gles,Fail spec@khr_texture_compression_astc@array-gles@12x12 Block Dim,Fail spec@khr_texture_compression_astc@array-gles@5x5 Block Dim,Fail +spec@khr_texture_compression_astc@basic-gles,Fail spec@khr_texture_compression_astc@miptree-gl hdr,Fail spec@khr_texture_compression_astc@miptree-gl hdr@HDR Profile,Fail spec@khr_texture_compression_astc@miptree-gl ldr,Fail diff --git a/src/freedreno/ci/freedreno-a530-flakes.txt b/src/freedreno/ci/freedreno-a530-flakes.txt index 552855c03f1..4dd3bf95fc7 100644 --- a/src/freedreno/ci/freedreno-a530-flakes.txt +++ b/src/freedreno/ci/freedreno-a530-flakes.txt @@ -107,3 +107,9 @@ spec@ext_image_dma_buf_import@ext_image_dma_buf_import-sample_yvu420 spec@ext_transform_feedback@api-errors.* spec@!opengl 2.0@gl-2.0-two-sided-stencil + +# appeared with a piglit uprev, probably from reshuffling. +spec@!opengl 1.1@depthstencil-default_fb-copypixels +spec@arb_direct_state_access@gettextureimage-formats +spec@ext_polygon_offset_clamp@ext_polygon_offset_clamp-draw_gles2 +spec@ext_polygon_offset_clamp@ext_polygon_offset_clamp-draw_gles2@negative clamp diff --git a/src/freedreno/ci/freedreno-a630-fails.txt b/src/freedreno/ci/freedreno-a630-fails.txt index 2d279f4c424..370451fe929 100644 --- a/src/freedreno/ci/freedreno-a630-fails.txt +++ b/src/freedreno/ci/freedreno-a630-fails.txt @@ -70,6 +70,9 @@ glx@glx-visuals-stencil -pixmap,Crash shaders@glsl-fs-fogscale,Fail shaders@glsl-fs-fogscale@gs-out and fs,Fail +# "../src/freedreno/ir3/ir3_shader.h:968:ir3_link_add: Assertion `i < ARRAY_SIZE(l->var)' failed." +shaders@glsl-max-varyings >max_varying_components,Crash + # "MESA: error: unknown vertex shader output name: VARYING_SLOT_EDGE # gl-2.0-edgeflag: ../src/freedreno/ir3/ir3_context.c:411: ir3_context_error: Assertion `!""' failed." shaders@point-vertex-id divisor,Crash @@ -453,6 +456,7 @@ spec@khr_texture_compression_astc@array-gles@12x12 Block Dim,Fail spec@khr_texture_compression_astc@array-gles@5x5 Block Dim,Fail spec@khr_texture_compression_astc@array-gles,Fail spec@khr_texture_compression_astc@array-gl,Fail +spec@khr_texture_compression_astc@basic-gles,Fail spec@khr_texture_compression_astc@miptree-gles hdr,Fail spec@khr_texture_compression_astc@miptree-gles hdr@HDR Profile,Fail spec@khr_texture_compression_astc@miptree-gles ldr,Fail diff --git a/src/freedreno/ci/freedreno-a630-skqp_unittests.txt b/src/freedreno/ci/freedreno-a630-skqp_unittests.txt index 6c451689490..1491a47cc4d 100644 --- a/src/freedreno/ci/freedreno-a630-skqp_unittests.txt +++ b/src/freedreno/ci/freedreno-a630-skqp_unittests.txt @@ -1,126 +1,55 @@ AbandonedContextImage AdvancedBlendTest ApplyGamma -AsyncReadPixelsContextShutdown BasicDrawOpAtlas BlurMaskBiggerThanDest -BulkFillRectTest -BulkTextureRectTest -CharacterizationFBO0nessTest -CharacterizationVkSCBnessTest +CCPR_busyPath +CCPR_cache_animationAtlasReuse +CCPR_cache_deferredCleanup +CCPR_cache_hashTable +CCPR_cache_mostlyVisible +CCPR_cache_multiFlush +CCPR_cache_multiTileCache +CCPR_cache_partialInvalidate +CCPR_cache_recycleEntries +CCPR_cleanup +CCPR_cleanupWithTexAllocFail +CCPR_parseEmptyPath +CCPR_unrefPerOpListPathsBeforeOps +CCPR_unregisterCulledOps ClearOp -ClipStack_SWMask -ColorTypeBackendAllocationTest +ClipMaskCache ComposedImageFilterBounds_Gpu ComposedImageFilterOffset_Gpu -CompressedBackendAllocationTest CopySurface DDLCompatibilityTest -DDLCreateCharacterizationFailures +DDLFlushWhileRecording DDLInvalidRecorder DDLMakeRenderTargetTest DDLMultipleDDLs DDLNonTextureabilityTest DDLOperatorEqTest -DDLSkSurfaceFlush DDLSurfaceCharacterizationTest DDLTextureFlagsTest DDLWrapBackendTest -DMSAA_aa_dst_read_after_dmsaa -DMSAA_dst_read -DMSAA_dst_read_with_existing_barrier -DMSAA_dual_source_blend_disable -DMSAA_preserve_contents -DSLBitwiseAnd -DSLBitwiseNot -DSLBitwiseOr -DSLBitwiseXor -DSLBlock -DSLBool -DSLBreak -DSLBuiltins -DSLCall -DSLComma -DSLContinue -DSLDeclare -DSLDeclareGlobal -DSLDecrement -DSLDiscard -DSLDivide -DSLDo -DSLES3Types -DSLEqual -DSLErrorLineNumbers -DSLExtension -DSLFlags -DSLFloat -DSLFor -DSLFunction -DSLGreaterThan -DSLGreaterThanOrEqual -DSLHalf -DSLIf -DSLImportOnly -DSLIncrement -DSLIndex -DSLInlining -DSLInt -DSLInterfaceBlock -DSLLayout -DSLLessThan -DSLLessThanOrEqual -DSLLogicalAnd -DSLLogicalNot -DSLLogicalOr -DSLLogicalXor -DSLMatrices -DSLMinus -DSLMod -DSLModifiers -DSLModifiersDeclaration -DSLMultiply -DSLNotEqual -DSLPlus -DSLPrototypes -DSLRTAdjust -DSLReleaseUnused -DSLReturn -DSLRuntimeEffectSimple_GPU -DSLSampleShader -DSLSelect -DSLShl -DSLShort -DSLShr -DSLStartup -DSLStruct -DSLSwitch -DSLSwizzle -DSLType -DSLUInt -DSLUShort -DSLVarSwap -DSLWhile -DSLWrapper -DefaultPathRendererTest DeferredProxyTest DefferredProxyConversionTest +DetermineDomainModeTest EGLImageTest ES2BlendWithNoTexture EmptySurfaceSemaphoreTest -ExtendedSkColorTypeTests_gpu -FlushFinishedProcTest -FlushSubmittedProcTest +FloatingPointTextureTest +FloatingPointTextureTest_RG FullScreenClearWithLayers -GLBackendAllocationTest -GLReadPixelsUnbindPBO -GLTextureParameters GPUMemorySize GpuDrawPath GpuRectanizer Gr1x1TextureMipMappedTest GrAtlasTextOpPreparation GrBackendTextureImageMipMappedTest -GrContextDump +GrClipBounds +GrContextFactory_NVPRContextOptionHasPathRenderingSupport +GrContextFactory_NoPathRenderingIfNVPRDisabled GrContextFactory_abandon GrContextFactory_executorAndTaskGroup GrContextFactory_sharedContexts @@ -128,63 +57,24 @@ GrContext_abandonContext GrContext_colorTypeSupportedAsImage GrContext_colorTypeSupportedAsSurface GrContext_maxSurfaceSamplesForColorType -GrContext_oomed -GrDDLImage_MakeSubset -GrDrawCollapsedPath +GrDefaultPathRendererTest GrDrawOpAtlasConfig_Basic GrImageSnapshotMipMappedTest -GrManyDependentsMipMappedTest GrMeshTest +GrOpListFlushCount +GrPathKeys GrPipelineDynamicStateTest GrPorterDuff -GrSkSLFP_Specialized -GrSkSLFP_UniformArray -GrSlug_empty GrSurface GrSurfaceRenderability -GrTextBlobMoveAround -GrTextBlobScaleAnimation +GrTRecorder +GrTestingBackendTextureUploadTest GrTextureMipMapInvalidationTest -GrThreadSafeCache10View -GrThreadSafeCache11Verts -GrThreadSafeCache11View -GrThreadSafeCache12Verts -GrThreadSafeCache12View -GrThreadSafeCache13Verts -GrThreadSafeCache13View -GrThreadSafeCache14 -GrThreadSafeCache15Verts -GrThreadSafeCache15View -GrThreadSafeCache16Verts -GrThreadSafeCache1Verts -GrThreadSafeCache1View -GrThreadSafeCache2Verts -GrThreadSafeCache2View -GrThreadSafeCache3Verts -GrThreadSafeCache3View -GrThreadSafeCache4Verts -GrThreadSafeCache4View -GrThreadSafeCache4_5Verts -GrThreadSafeCache4_5View -GrThreadSafeCache4_75Verts -GrThreadSafeCache4_75View -GrThreadSafeCache5Verts -GrThreadSafeCache5View -GrThreadSafeCache6Verts -GrThreadSafeCache6View -GrThreadSafeCache7Verts -GrThreadSafeCache7View -GrThreadSafeCache8Verts -GrThreadSafeCache8View -GrThreadSafeCache9Verts -GrThreadSafeCache9View +GrUploadPixelsTests GrWrappedMipMappedTest HalfFloatAlphaTextureTest HalfFloatRGBATextureTest -ImageAsyncReadPixels -ImageBackendAccessAbandoned_Gpu ImageEncode_Gpu -ImageFilterBlurLargeImage_Gpu ImageFilterCache_GPUBacked ImageFilterCache_ImageBackedGPU ImageFilterClippedPictureImageFilter_Gpu @@ -195,8 +85,8 @@ ImageFilterMakeWithFilter_Gpu ImageFilterMatrixConvolutionBigKernel_Gpu ImageFilterMergeResultSize_Gpu ImageFilterNegativeBlurSigma_Gpu +ImageFilterPartialCropRect_Gpu ImageFilterZeroBlurSigma_Gpu -ImageFlush ImageIsOpaqueTest_Gpu ImageLegacyBitmap_Gpu ImageNewShader_GPU @@ -204,46 +94,43 @@ ImagePeek_Gpu ImageReadPixels_Gpu ImageScalePixels_Gpu InitialTextureClear +LazyDeinstantiation +LazyProxyDeinstantiateTest LazyProxyFailedInstantiationTest LazyProxyReleaseTest LazyProxyTest -MatrixColorFilter_TransparentBlack -MorphologyFilterRadiusWithMirrorCTM_Gpu +OnFlushCallbackTest OpChainTest -OpsTaskFlushCount -OverbudgetFlush OverdrawSurface_Gpu -PathTest_CrBug1232834 PinnedImageTest PorterDuffNoDualSourceBlending PreinstantiatedProxyConversionTest PremulAlphaRoundTrip_Gpu -ProcessorCloneTest ProcessorRefTest -Programs -PromiseImageNullFulfill -PromiseImageTest +PromiseImageTestDelayedRelease +PromiseImageTestNoDelayedRelease PromiseImageTextureFullCache +PromiseImageTextureReuse +PromiseImageTextureReuseDifferentConfig PromiseImageTextureShutdown ProxyRefTest -PurgeToMakeHeadroom +RGB565TextureTest +RGBA4444TextureTest ReadOnlyTexture -ReadPixels_InvalidRowBytes_Gpu +ReadPixels_Gpu +ReadPixels_Texture +ReadWriteAlpha RectangleTexture ReimportImageTextureWithMipLevels -RepeatedClippedBlurTest -ReplaceSurfaceBackendTexture -ResourceAllocatorMemoryBudgetTest ResourceAllocatorStressTest ResourceAllocatorTest ResourceCacheCache ResourceCacheMisc ResourceCacheStencilBuffers ResourceCacheWrappedResources -ResourceMessagesAfterAbandon -SRGBReadWritePixels SkImage_CrossContextGrayAlphaConfigs SkImage_Gpu2Cpu +SkImage_MakeCrossContextFromEncodedRelease SkImage_MakeCrossContextFromPixmapRelease SkImage_NewFromTextureRelease SkImage_makeNonTextureImage @@ -255,254 +142,60 @@ SkRemoteGlyphCache_DrawTextAsPath SkRemoteGlyphCache_DrawTextXY SkRemoteGlyphCache_ReleaseTypeFace SkRemoteGlyphCache_StrikeSerialization -SkRemoteGlyphCache_TypefaceWithNoPaths -SkRuntimeBlender_GPU -SkRuntimeEffectSimple_GPU -SkRuntimeEffect_Blender_GPU -SkRuntimeShaderImageFilter_GPU -SkRuntimeStructNameReuse_GPU -SkSLArrayCast_GPU -SkSLArrayComparison_GPU -SkSLArrayConstructors_GPU -SkSLArrayFollowedByScalar_GPU -SkSLArrayNarrowingConversions_GPU -SkSLArraySizeFolding_GPU -SkSLArrayTypes_GPU -SkSLAssignmentOps_GPU -SkSLAssignment_GPU -SkSLBoolFolding_GPU -SkSLCastFolding_GPU -SkSLCastsRoundTowardZero_GPU -SkSLCommaMixedTypes_GPU -SkSLConstArray_GPU -SkSLConstVariableComparison_GPU -SkSLConstantIf_GPU -SkSLCross -SkSLDeadIfStatement_GPU -SkSLDeadLoopVariable_GPU -SkSLDeadReturn_GPU -SkSLDeadStripFunctions_GPU -SkSLDependentInitializers_GPU -SkSLDoWhileBodyMustBeInlinedIntoAScope_GPU -SkSLDoWhileControlFlow_GPU -SkSLDoWhileTestCannotBeInlined_GPU -SkSLEmptyBlocksES2_GPU -SkSLEmptyBlocksES3_GPU -SkSLFloatFolding_GPU -SkSLForBodyMustBeInlinedIntoAScope_GPU -SkSLForInitializerExpressionsCanBeInlined_GPU -SkSLForLoopControlFlow_GPU -SkSLForWithReturnInsideCannotBeInlined_GPU -SkSLForWithoutReturnInsideCanBeInlined_GPU -SkSLFunctionArgTypeMatch_GPU -SkSLFunctionPrototype_GPU -SkSLFunctionReturnTypeMatch_GPU -SkSLFunctions_GPU -SkSLGeometricIntrinsics_GPU -SkSLHelloWorld_GPU -SkSLHexUnsigned_GPU -SkSLHex_GPU -SkSLIfBodyMustBeInlinedIntoAScope_GPU -SkSLIfElseBodyMustBeInlinedIntoAScope_GPU -SkSLIfElseChainWithReturnsCanBeInlined_GPU -SkSLIfTestCanBeInlined_GPU -SkSLIfWithReturnsCanBeInlined_GPU -SkSLInlineKeywordOverridesThreshold_GPU -SkSLInlineThreshold_GPU -SkSLInlineWithModifiedArgument_GPU -SkSLInlineWithNestedBigCalls_GPU -SkSLInlineWithUnmodifiedArgument_GPU -SkSLInlineWithUnnecessaryBlocks_GPU -SkSLInlinerAvoidsVariableNameOverlap_GPU -SkSLInlinerElidesTempVarForReturnsInsideBlock_GPU -SkSLInlinerUsesTempVarForMultipleReturns_GPU -SkSLInlinerUsesTempVarForReturnsInsideBlockWithVar_GPU -SkSLIntFoldingES2_GPU -SkSLIntFoldingES3_GPU -SkSLIntrinsicAbsFloat_GPU -SkSLIntrinsicCeil_GPU -SkSLIntrinsicClampInt_GPU -SkSLIntrinsicClampUInt_GPU -SkSLIntrinsicDFdx_GPU -SkSLIntrinsicDFdy_GPU -SkSLIntrinsicDeterminant_GPU -SkSLIntrinsicFloatBitsToInt_GPU -SkSLIntrinsicFloatBitsToUint_GPU -SkSLIntrinsicFwidth_GPU -SkSLIntrinsicIntBitsToFloat_GPU -SkSLIntrinsicIsInf_GPU -SkSLIntrinsicMatrixCompMultES2_GPU -SkSLIntrinsicMatrixCompMultES3_GPU -SkSLIntrinsicMaxFloat_GPU -SkSLIntrinsicMinFloat_GPU -SkSLIntrinsicModf_GPU -SkSLIntrinsicOuterProduct_GPU -SkSLIntrinsicRoundEven_GPU -SkSLIntrinsicRound_GPU -SkSLIntrinsicSignFloat_GPU -SkSLIntrinsicStep_GPU -SkSLIntrinsicTranspose_GPU -SkSLIntrinsicTrunc_GPU -SkSLIntrinsicUintBitsToFloat_GPU -SkSLLoopFloat_GPU -SkSLLoopInt_GPU -SkSLMatricesNonsquare_GPU -SkSLMatrices_GPU -SkSLMatrixEquality_GPU -SkSLMatrixFoldingES3_GPU -SkSLMatrixScalarSplat_GPU -SkSLMatrixToVectorCast_GPU -SkSLMultipleAssignments_GPU -SkSLNegation_GPU -SkSLNoInline_GPU -SkSLNumberCasts_GPU -SkSLOperatorsES2_GPU -SkSLOperatorsES3_GPU -SkSLOssfuzz36852_GPU -SkSLPrecisionQualifiers_GPU -SkSLQualifierOrder_GPU -SkSLResizeMatrixNonsquare_GPU -SkSLResizeMatrix_GPU -SkSLReturnsValueOnEveryPathES2_GPU -SkSLReturnsValueOnEveryPathES3_GPU -SkSLScalarConversionConstructorsES2_GPU -SkSLScalarConversionConstructorsES3_GPU -SkSLScopedSymbol_GPU -SkSLSelfAssignment_GPU -SkSLShortCircuitBoolFolding_GPU -SkSLShortCircuitEvaluationsCannotInlineRightHandSide_GPU -SkSLStackingVectorCasts_GPU -SkSLStaticIf_GPU -SkSLStaticSwitchInline_GPU -SkSLStaticSwitch_GPU -SkSLStructArrayFollowedByScalar_GPU -SkSLStructsCanBeInlinedSafely_GPU -SkSLStructsInFunctions_GPU -SkSLSwitchDefaultOnly_GPU -SkSLSwitchWithFallthrough_GPU -SkSLSwitchWithLoops_GPU -SkSLSwitch_GPU -SkSLSwizzleBoolConstants_GPU -SkSLSwizzleByConstantIndex_GPU -SkSLSwizzleByIndex_GPU -SkSLSwizzleCanBeInlinedDirectly_GPU -SkSLSwizzleConstants_GPU -SkSLSwizzleFolding_GPU -SkSLSwizzleLTRB_GPU -SkSLSwizzleOpt_GPU -SkSLSwizzleScalarBool_GPU -SkSLSwizzleScalarInt_GPU -SkSLSwizzleScalar_GPU -SkSLTernaryAsLValueEntirelyFoldable_GPU -SkSLTernaryAsLValueFoldableTest_GPU -SkSLTernaryExpression_GPU -SkSLTernaryResultsCannotBeInlined_GPU -SkSLTernaryTestCanBeInlined_GPU -SkSLTrivialArgumentsInlineDirectly_GPU -SkSLUnaryPositiveNegative_GPU -SkSLUniformArray_GPU -SkSLUnusedVariables_GPU -SkSLVectorConstructors_GPU -SkSLVectorScalarFolding_GPU -SkSLVectorToMatrixCast_GPU -SkSLVectorVectorFolding_GPU -SkSLWhileBodyMustBeInlinedIntoAScope_GPU -SkSLWhileLoopControlFlow_GPU -SkSLWhileTestCannotBeInlined_GPU -SkSL_ES2Conformance_Pass_GPU SkTraceMemoryDump_ownedGLBuffer SkTraceMemoryDump_ownedGLRenderTarget SkTraceMemoryDump_ownedGLTexture -SkTraceMemoryDump_ownedGLTextureRenderTarget SkTraceMemoryDump_unownedGLRenderTarget SkTraceMemoryDump_unownedGLTexture -SkipCopyTaskTest -SkipOpsTaskTest SmallBoxBlurBug SoftwarePathRendererCacheTest SpecialImage_GPUDevice SpecialImage_Gpu +SpecialImage_MakeTexture +SpecialImage_ReadbackAndCachingSubsets_Gpu SpecialSurface_Gpu1 -SrcSrcOverBatchTest -SurfaceAbandonPostFlush_Gpu -SurfaceAsyncReadPixels SurfaceAttachStencil_Gpu -SurfaceBackendAccessAbandoned_Gpu SurfaceBackendHandleAccessIDs_Gpu SurfaceBackendSurfaceAccessCopyOnWrite_Gpu SurfaceBudget SurfaceCRBug263329_Gpu SurfaceCanvasPeek_Gpu SurfaceClear_Gpu -SurfaceContextReadPixels -SurfaceContextWritePixels -SurfaceContextWritePixelsMipped SurfaceCopyOnWrite_Gpu -SurfaceDrawContextTest SurfaceEmpty_Gpu SurfaceNoCanvas_Gpu SurfacePartialDraw_Gpu SurfaceSemaphores SurfaceSnapshotAlphaType_Gpu -SurfaceWrappedWithRelease_Gpu SurfaceWriteableAfterSnapshotRelease_Gpu SurfacepeekTexture_Gpu +TessellatingPathRendererCacheTest +TessellatingPathRendererTests TestGpuAllContexts TestGpuFactory +TestGpuNullContext TestGpuRenderingContexts -TestMockContext TextBlobAbnormal TextBlobCache -TextBlobJaggedGlyph -TextBlobSmoothScroll TextBlobStressAbnormal TextBlobStressCache -TextureBindingsResetTest -TextureOpTest +TextureIdleProcTest TextureProxyTest TextureStripAtlasManagerColorFilterTest TextureStripAtlasManagerGradientTest -TransferPixelsFromTextureTest -TransferPixelsToTextureTest -TriangulatingPathRendererCacheTest -TriangulatingPathRendererTests +TransferPixelsTest UnpremulTextureImage VertexAttributeCount -VkBackendAllocationTest -VkBackendSurfaceMutableStateTest -VkDRMModifierTest -VkDrawableImportTest -VkDrawableTest -VkImageLayoutTest -VkProtectedContext_AsyncReadFromProtectedSurface -VkProtectedContext_CreateNonprotectedTextureInProtectedContext -VkProtectedContext_CreateProtectedContext -VkProtectedContext_CreateProtectedSkSurface -VkProtectedContext_CreateProtectedTextureInNonprotectedContext -VkProtectedContext_DDLMakeRenderTargetTest -VkProtectedContext_DDLSurfaceCharacterizationTest -VkProtectedContext_DrawProtectedImageOnProtectedSurface -VkProtectedContext_DrawRectangle -VkProtectedContext_DrawRectangleWithAntiAlias -VkProtectedContext_DrawRectangleWithBlendMode -VkProtectedContext_DrawRectangleWithFilter -VkProtectedContext_DrawThinPath -VkProtectedContext_ReadFromProtectedSurface -VkProtectedContext_SaveLayer -VkWrapTests -VulkanPriorityExtension WrappedProxyTest -WrappedSurfaceCopyOnWrite WritePixelsMSAA_Gpu WritePixelsNonTextureMSAA_Gpu WritePixelsNonTexture_Gpu WritePixelsPendingIO WritePixels_Gpu -WritePixels_InvalidRowBytes_Gpu XfermodeImageFilterCroppedInput_Gpu ZeroSizedProxyTest -crbug_1271431 +canvas_private_clipRgn makeBackendTexture -skbug12214 skbug5221_GPU skbug6653 +skbug6653_noExplicitResourceAllocation diff --git a/src/freedreno/ci/gitlab-ci.yml b/src/freedreno/ci/gitlab-ci.yml index 0524c6fc182..8aa5f976552 100644 --- a/src/freedreno/ci/gitlab-ci.yml +++ b/src/freedreno/ci/gitlab-ci.yml @@ -214,8 +214,8 @@ a630_skqp: - .a630-test variables: # Possible skqp backends: gl, gles, unitTest and vk - # Note: vk backend is not working yet. - SKQP_BACKENDS: gl gles unitTest # space separated values + SKQP_BACKENDS: gl gles vk unitTest # space separated values + VK_DRIVER: freedreno a630_vk: extends: diff --git a/src/gallium/drivers/i915/ci/i915-g33-fails.txt b/src/gallium/drivers/i915/ci/i915-g33-fails.txt index 3f2179a7c95..6bb2571f7c5 100644 --- a/src/gallium/drivers/i915/ci/i915-g33-fails.txt +++ b/src/gallium/drivers/i915/ci/i915-g33-fails.txt @@ -896,10 +896,8 @@ spec@glsl-1.10@execution@temp-array-indexing@glsl-fs-vec4-indexing-temp-src-in-n spec@glsl-1.10@execution@variable-indexing@fs-input-array-vec2-index-rd,Fail spec@glsl-1.10@execution@variable-indexing@fs-input-array-vec3-index-rd,Fail spec@glsl-1.10@execution@variable-indexing@fs-input-array-vec4-index-rd,Fail -spec@glsl-1.10@execution@variable-indexing@fs-temp-array-mat2-index-col-row-wr,Fail spec@glsl-1.10@execution@variable-indexing@fs-temp-array-mat3-index-col-row-wr,Fail spec@glsl-1.10@execution@variable-indexing@fs-temp-array-mat3-index-col-wr,Fail -spec@glsl-1.10@execution@variable-indexing@fs-temp-array-mat3-index-row-wr,Fail spec@glsl-1.10@execution@variable-indexing@fs-temp-array-mat4-index-col-row-wr,Fail spec@glsl-1.10@execution@variable-indexing@fs-temp-array-mat4-index-col-wr,Fail spec@glsl-1.10@execution@variable-indexing@fs-temp-array-mat4-index-row-wr,Fail @@ -1069,8 +1067,6 @@ spec@glsl-1.20@execution@fs-const-array-of-struct-of-array,Fail spec@glsl-1.20@execution@fs-function-inout-array-of-structs,Fail spec@glsl-1.20@execution@fs-nan-builtin-max,Fail spec@glsl-1.20@execution@fs-nan-builtin-min,Fail -spec@glsl-1.20@execution@fs-vec4-const-array-indirect-access-032-elements,Fail -spec@glsl-1.20@execution@fs-vec4-const-array-indirect-access-048-elements,Fail spec@glsl-1.20@execution@fs-vec4-const-array-indirect-access-064-elements,Fail spec@glsl-1.20@execution@fs-vec4-const-array-indirect-access-128-elements,Fail spec@glsl-1.20@execution@fs-vec4-const-array-indirect-access-256-elements,Fail @@ -1115,10 +1111,8 @@ spec@glsl-1.20@execution@uniform-initializer@fs-mat4,Fail spec@glsl-1.20@execution@uniform-initializer@fs-mat4-array,Fail spec@glsl-1.20@execution@uniform-initializer@fs-mat4-from-const,Fail spec@glsl-1.20@execution@uniform-initializer@fs-mat4-set-by-other-stage,Fail -spec@glsl-1.20@execution@variable-indexing@fs-temp-array-mat2-index-col-row-wr,Fail spec@glsl-1.20@execution@variable-indexing@fs-temp-array-mat3-index-col-row-wr,Fail spec@glsl-1.20@execution@variable-indexing@fs-temp-array-mat3-index-col-wr,Fail -spec@glsl-1.20@execution@variable-indexing@fs-temp-array-mat3-index-row-wr,Fail spec@glsl-1.20@execution@variable-indexing@fs-temp-array-mat4-index-col-row-wr,Fail spec@glsl-1.20@execution@variable-indexing@fs-temp-array-mat4-index-col-wr,Fail spec@glsl-1.20@execution@variable-indexing@fs-temp-array-mat4-index-row-wr,Fail diff --git a/src/gallium/drivers/i915/ci/i915-g33-flakes.txt b/src/gallium/drivers/i915/ci/i915-g33-flakes.txt new file mode 100644 index 00000000000..3262d05c89d --- /dev/null +++ b/src/gallium/drivers/i915/ci/i915-g33-flakes.txt @@ -0,0 +1 @@ +spec@glsl-1.10@execution@fs-frontfacing-ternary-vec4-neg-1.0-1.0 diff --git a/src/gallium/drivers/iris/ci/iris-kbl-fails.txt b/src/gallium/drivers/iris/ci/iris-kbl-fails.txt index 7bece1e46bd..106f0ef0d1e 100644 --- a/src/gallium/drivers/iris/ci/iris-kbl-fails.txt +++ b/src/gallium/drivers/iris/ci/iris-kbl-fails.txt @@ -99,6 +99,9 @@ spec@!opengl 1.1@linestipple@Line strip,Fail # Fail: nothing rendered. spec@!opengl 2.0@vs-point_size-zero,Fail +spec@amd_performance_monitor@measure,Fail +spec@amd_performance_monitor@measure@counters in range,Fail + # The textures will be initialized by rendering to them using glDrawPixels. # gettextureimage-formats failure: format: GL_RGB10_A2, level 1 at pixel(369, 103) # Expected (0.597386, 0.597386, 0.433987, 0.111111) @@ -235,6 +238,7 @@ spec@glsl-1.50@execution@geometry@primitive-types gl_line_loop,Fail # piglit: error: Miplevel 0 # piglit: error: Mode ldrs Block 4x4. +spec@khr_texture_compression_astc@basic-gles,Fail spec@khr_texture_compression_astc@miptree-gl srgb-fp,Fail spec@khr_texture_compression_astc@miptree-gl srgb-fp@sRGB decode full precision,Fail spec@khr_texture_compression_astc@miptree-gles srgb-fp,Fail diff --git a/src/gallium/drivers/radeonsi/ci/radeonsi-stoney-fails.txt b/src/gallium/drivers/radeonsi/ci/radeonsi-stoney-fails.txt index 7ce135bded2..0d5d40a87a9 100644 --- a/src/gallium/drivers/radeonsi/ci/radeonsi-stoney-fails.txt +++ b/src/gallium/drivers/radeonsi/ci/radeonsi-stoney-fails.txt @@ -1,10 +1,22 @@ glx@glx_arb_create_context_no_error@no error,Fail glx@glx_arb_create_context_robustness@invalid reset notification strategy,Fail + +glx@glx_ext_import_context@free context,Fail glx@glx_ext_import_context@get context id,Fail glx@glx_ext_import_context@import context- single process,Fail +glx@glx_ext_import_context@query context info,Fail + glx@glx-visuals-stencil -pixmap,Crash + +spec@!opengl 1.0@rasterpos,Fail +spec@!opengl 1.0@rasterpos@glsl_vs_gs_linked,Fail +spec@!opengl 1.0@rasterpos@glsl_vs_tes_linked,Fail + spec@arb_direct_state_access@gettextureimage-formats,Crash + spec@arb_es2_compatibility@texwrap formats bordercolor-swizzled,Fail +spec@arb_es2_compatibility@texwrap formats bordercolor-swizzled@GL_RGB565- swizzled- border color only,Fail + spec@arb_program_interface_query@arb_program_interface_query-getprogramresourceindex@'vs_input2[1][0]' on GL_PROGRAM_INPUT,Fail spec@arb_program_interface_query@arb_program_interface_query-getprogramresourceindex,Fail spec@arb_shader_texture_lod@execution@arb_shader_texture_lod-texgradcube,Fail @@ -70,7 +82,21 @@ spec@ext_texture_compression_s3tc@texwrap formats bordercolor-swizzled@GL_COMPRE spec@ext_texture_compression_s3tc@texwrap formats bordercolor-swizzled@GL_COMPRESSED_RGBA_S3TC_DXT5_EXT- swizzled- border color only,Fail spec@ext_texture_compression_s3tc@texwrap formats bordercolor-swizzled@GL_COMPRESSED_RGB_S3TC_DXT1_EXT- swizzled- border color only,Fail spec@ext_texture_integer@fbo-integer,Fail + spec@ext_texture_integer@texwrap formats bordercolor-swizzled,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGB16I- swizzled- border color only,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGB16UI- swizzled- border color only,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGB32I- swizzled- border color only,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGB32UI- swizzled- border color only,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGB8I- swizzled- border color only,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGB8UI- swizzled- border color only,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGBA16I- swizzled- border color only,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGBA16UI- swizzled- border color only,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGBA32I- swizzled- border color only,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGBA32UI- swizzled- border color only,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGBA8I- swizzled- border color only,Fail +spec@ext_texture_integer@texwrap formats bordercolor-swizzled@GL_RGBA8UI- swizzled- border color only,Fail + spec@ext_texture_shared_exponent@texwrap formats bordercolor-swizzled,Fail spec@ext_texture_snorm@texwrap formats bordercolor-swizzled,Fail spec@ext_texture_snorm@texwrap formats bordercolor-swizzled@GL_R16_SNORM- swizzled- border color only,Fail