From d173ed2e9c7c0d40448903976ce1e560ce2a62ab Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Tue, 19 Jan 2021 14:00:15 +0100 Subject: [PATCH] radv: do not enable TC-compat CMASK if the image isn't readable by a shader Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen Part-of: --- src/amd/vulkan/radv_image.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index 1b61bd4277a..466bb338df9 100644 --- a/src/amd/vulkan/radv_image.c +++ b/src/amd/vulkan/radv_image.c @@ -273,6 +273,14 @@ radv_use_tc_compat_cmask_for_image(struct radv_device *device, if (image->usage & VK_IMAGE_USAGE_STORAGE_BIT) return false; + /* Do not enable TC-compatible if the image isn't readable by a shader + * because no texture fetches will happen. + */ + if (!(image->usage & (VK_IMAGE_USAGE_SAMPLED_BIT | + VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT | + VK_IMAGE_USAGE_TRANSFER_SRC_BIT))) + return false; + if (radv_image_has_dcc(image)) return false;