KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

aco: Emit zero for the derivatives of uniforms. 

Observed in a shader from Resident Evil Village.
This also helps prevent emitting invalid IR.

Cc: mesa-stable
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12599>
This commit is contained in:
Timur Kristóf 2021-08-26 16:36:28 +02:00 committed by Marge Bot
parent 1454955e5d
commit cfb0d931f2
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/amd/compiler/aco_instruction_selection.cpp
View File

@ -3487,6 +3487,14 @@ visit_alu_instr(isel_context* ctx, nir_alu_instr* instr)
case nir_op_fddy_fine:
case nir_op_fddx_coarse:
case nir_op_fddy_coarse: {
if (!nir_src_is_divergent(instr->src[0].src)) {
/* Source is the same in all lanes, so the derivative is zero.
* This also avoids emitting invalid IR.
*/
bld.copy(Definition(dst), Operand::zero());
break;
}
Temp src = as_vgpr(ctx, get_alu_src(ctx, instr->src[0]));
uint16_t dpp_ctrl1, dpp_ctrl2;
if (instr->op == nir_op_fddx_fine) {