KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

panfrost: Identify additional SFBD flags 

These are analogues to the flags we have in the blend structure on
T760+, which enables us to fix shaderless and sRGB operation on T720.

Closes #2771

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Fixes: a64599a303 ("panfrost: Pass the sampler view format when creating a tex descriptor")
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6440>
This commit is contained in:
Alyssa Rosenzweig 2020-08-21 09:12:54 -04:00 committed by Tomeu Vizoso
parent 7a95ed2ecf
commit c9858fb941
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/gallium/drivers/panfrost/pan_cmdstream.c
View File

@ -723,6 +723,14 @@ panfrost_emit_frag_shader(struct panfrost_context *ctx,
* need to signal CAN_DISCARD for nontrivial blend modes (so
* we're able to read back the destination buffer) */
if (blend[0].no_colour)
return;
fragmeta->unknown2_4 |= MALI_SFBD_ENABLE;
SET_BIT(fragmeta->unknown2_4, MALI_SFBD_SRGB,
util_format_is_srgb(ctx->pipe_framebuffer.cbufs[0]->format));
SET_BIT(fragmeta->unknown2_3, MALI_HAS_BLEND_SHADER,
blend[0].is_shader);
@ -737,7 +745,6 @@ panfrost_emit_frag_shader(struct panfrost_context *ctx,
SET_BIT(fragmeta->unknown2_3, MALI_CAN_DISCARD,
blend[0].load_dest);
fragmeta->unknown2_4 |= 0x10;
SET_BIT(fragmeta->unknown2_4, MALI_NO_DITHER, !ctx->blend->base.dither);
} else if (!(dev->quirks & IS_BIFROST)) {
/* Bug where MRT-capable hw apparently reads the last blend

2
src/panfrost/include/panfrost-job.h
View File

@ -80,6 +80,8 @@ typedef uint64_t mali_ptr;
#define MALI_ALPHA_TO_COVERAGE (1 << 1)
#define MALI_SFBD_ENABLE (1 << 4)
#define MALI_SFBD_SRGB (1 << 8)
#define MALI_NO_DITHER (1 << 9)
#define MALI_DEPTH_RANGE_A (1 << 12)
#define MALI_DEPTH_RANGE_B (1 << 13)