KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

v3dv: Fix assert. 

Fix defect reported by Coverity Scan.

Side effect in assertion (ASSERT_SIDE_EFFECT)
assignment_where_comparison_intended: Assignment job->ez_state =
VC5_EZ_DISABLED has a side effect. This code will work differently in a
non-debug build.

Fixes: cec2ed7c80 ("v3dv: fix disabling Early Z for the whole frame")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8666>
This commit is contained in:
Vinson Lee 2021-01-22 18:49:12 -08:00 committed by Marge Bot
parent 70652885e3
commit c897f7a722
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/broadcom/vulkan/v3dv_cmd_buffer.c
View File

@ -3005,7 +3005,7 @@ job_update_ez_state(struct v3dv_job *job,
* packet, so ez_state must also be VC5_EZ_DISABLED;
*/
if (job->first_ez_state == VC5_EZ_DISABLED) {
assert(job->ez_state = VC5_EZ_DISABLED);
assert(job->ez_state == VC5_EZ_DISABLED);
return;
}