KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nvc0/ir: Initialize CodeEmitterGK110 member progType in constructor. 

Fix defect reported by Coverity Scan.

Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member progType is not initialized in
this constructor nor in any functions that it calls.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10715>
This commit is contained in:
Vinson Lee 2021-05-08 17:23:52 -07:00
parent 77d959814c
commit c892412111
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
View File

@ -29,14 +29,12 @@ namespace nv50_ir {
class CodeEmitterGK110 : public CodeEmitter
{
public:
CodeEmitterGK110(const TargetNVC0 *);
CodeEmitterGK110(const TargetNVC0 *, Program::Type);
virtual bool emitInstruction(Instruction *);
virtual uint32_t getMinEncodingSize(const Instruction *) const;
virtual void prepareEmission(Function *);
inline void setProgramType(Program::Type pType) { progType = pType; }
private:
const TargetNVC0 *targNVC0;
@ -2793,9 +2791,10 @@ CodeEmitterGK110::prepareEmission(Function *func)
calculateSchedDataNVC0(targ, func);
}
CodeEmitterGK110::CodeEmitterGK110(const TargetNVC0 *target)
CodeEmitterGK110::CodeEmitterGK110(const TargetNVC0 *target, Program::Type type)
: CodeEmitter(target),
targNVC0(target),
progType(type),
writeIssueDelays(target->hasSWSched)
{
code = NULL;
@ -2806,8 +2805,7 @@ CodeEmitterGK110::CodeEmitterGK110(const TargetNVC0 *target)
CodeEmitter *
TargetNVC0::createCodeEmitterGK110(Program::Type type)
{
CodeEmitterGK110 *emit = new CodeEmitterGK110(this);
emit->setProgramType(type);
CodeEmitterGK110 *emit = new CodeEmitterGK110(this, type);
return emit;
}