KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel/mi_builder: Fix a misleading comment 

This doesn't actually assume the top 32 bits of the source value are
zero.  Instead, it does (src >> shift) & UINT32_MAX regardless of what
the top bits of src are.

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9116>
This commit is contained in:
Jason Ekstrand 2021-02-18 09:37:44 -06:00 committed by Marge Bot
parent 40df12d4ce
commit c64d7aa8e3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/intel/common/gen_mi_builder.h
View File

@ -868,7 +868,7 @@ gen_mi_ushr32_imm(struct gen_mi_builder *b,
struct gen_mi_value src, uint32_t shift)
{
/* We right-shift by left-shifting by 32 - shift and taking the top 32 bits
* of the result. This assumes the top 32 bits are zero.
* of the result.
*/
if (shift > 64)
return gen_mi_imm(0);