pan/midgard: Extract simple source mod check

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
This commit is contained in:
Alyssa Rosenzweig 2019-07-26 11:52:30 -07:00
parent 2d2abb08d0
commit c45487b770
3 changed files with 15 additions and 4 deletions

View File

@ -443,8 +443,8 @@ void mir_print_instruction(midgard_instruction *ins);
void mir_print_bundle(midgard_bundle *ctx);
void mir_print_block(midgard_block *block);
void mir_print_shader(compiler_context *ctx);
bool mir_nontrivial_raw_mod(midgard_vector_alu_src src, bool is_int);
bool mir_nontrivial_source2_mod(midgard_instruction *ins);
bool mir_nontrivial_source2_mod_simple(midgard_instruction *ins);
bool mir_nontrivial_mod(midgard_vector_alu_src src, bool is_int, unsigned mask);
bool mir_nontrivial_outmod(midgard_instruction *ins);

View File

@ -1877,8 +1877,7 @@ embedded_to_inline_constant(compiler_context *ctx)
/* We don't know how to handle these with a constant */
bool is_int = midgard_is_integer_op(ins->alu.op);
if (mir_nontrivial_raw_mod(*src, is_int) || src->half || src->rep_low || src->rep_high) {
if (mir_nontrivial_source2_mod_simple(ins) || src->rep_low || src->rep_high) {
DBG("Bailing inline constant...\n");
continue;
}

View File

@ -108,7 +108,7 @@ mir_single_use(compiler_context *ctx, unsigned value)
return mir_use_count(ctx, value) <= 1;
}
bool
static bool
mir_nontrivial_raw_mod(midgard_vector_alu_src src, bool is_int)
{
if (is_int)
@ -133,6 +133,7 @@ mir_nontrivial_mod(midgard_vector_alu_src src, bool is_int, unsigned mask)
return false;
}
bool
mir_nontrivial_source2_mod(midgard_instruction *ins)
{
@ -144,6 +145,17 @@ mir_nontrivial_source2_mod(midgard_instruction *ins)
return mir_nontrivial_mod(src2, is_int, ins->mask);
}
bool
mir_nontrivial_source2_mod_simple(midgard_instruction *ins)
{
bool is_int = midgard_is_integer_op(ins->alu.op);
midgard_vector_alu_src src2 =
vector_alu_from_unsigned(ins->alu.src2);
return mir_nontrivial_raw_mod(src2, is_int) && !src2.half;
}
bool
mir_nontrivial_outmod(midgard_instruction *ins)
{