KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mesa: compute gl_program_parameter_list::UniformBytes accurately 

The previous code didn't do it correctly.
(e.g.  _mesa_recompute_parameter_bounds didn't do anything)

Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8183>
This commit is contained in:
Marek Olšák 2020-12-12 01:39:29 -05:00 committed by Marge Bot
parent fb73058ad2
commit bddb4f9e1e
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/mesa/program/prog_parameter.c
View File

@ -336,7 +336,9 @@ _mesa_add_parameter(struct gl_program_parameter_list *paramList,
if (type == PROGRAM_UNIFORM || type == PROGRAM_CONSTANT) {
paramList->UniformBytes =
MAX2(paramList->UniformBytes, paramList->NumParameterValues * 4);
MAX2(paramList->UniformBytes,
(paramList->Parameters[oldNum].ValueOffset +
paramList->Parameters[oldNum].Size) * 4);
} else if (type == PROGRAM_STATE_VAR) {
paramList->FirstStateVarIndex =
MIN2(paramList->FirstStateVarIndex, oldNum);
@ -457,6 +459,7 @@ _mesa_add_state_reference(struct gl_program_parameter_list *paramList,
void
_mesa_recompute_parameter_bounds(struct gl_program_parameter_list *list)
{
list->UniformBytes = 0;
list->FirstStateVarIndex = INT_MAX;
list->LastStateVarIndex = 0;
@ -465,7 +468,9 @@ _mesa_recompute_parameter_bounds(struct gl_program_parameter_list *list)
list->FirstStateVarIndex = MIN2(list->FirstStateVarIndex, i);
list->LastStateVarIndex = MAX2(list->LastStateVarIndex, i);
} else {
list->UniformBytes = MAX2(list->UniformBytes, list->NumParameterValues * 4);
list->UniformBytes = MAX2(list->UniformBytes,
(list->Parameters[i].ValueOffset +
list->Parameters[i].Size) * 4);
}
}
}